Title: [123815] trunk/Source/WebKit/blackberry
- Revision
- 123815
- Author
- commit-qu...@webkit.org
- Date
- 2012-07-26 17:01:08 -0700 (Thu, 26 Jul 2012)
Log Message
[BlackBerry] Remove synchronous spellchecking code
https://bugs.webkit.org/show_bug.cgi?id=92415
Removing synchronous spellchecking code path.
Patch by Nima Ghanavatian <nghanavat...@rim.com> on 2012-07-26
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
* Api/WebPageClient.h:
* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::checkSpellingOfString):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPageClient.h (123814 => 123815)
--- trunk/Source/WebKit/blackberry/Api/WebPageClient.h 2012-07-26 23:55:10 UTC (rev 123814)
+++ trunk/Source/WebKit/blackberry/Api/WebPageClient.h 2012-07-27 00:01:08 UTC (rev 123815)
@@ -143,9 +143,7 @@
virtual void showVirtualKeyboard(bool) = 0;
- virtual void checkSpellingOfString(const unsigned short* text, int length, int& misspellingLocation, int& misspellingLength) = 0;
virtual void requestSpellingSuggestionsForString(unsigned start, unsigned end) = 0;
-
virtual int32_t checkSpellingOfStringAsync(wchar_t* text, int length) = 0;
virtual void notifySelectionDetailsChanged(const Platform::IntRect& start, const Platform::IntRect& end, const Platform::IntRectRegion&, bool overrideTouchHandling = false) = 0;
Modified: trunk/Source/WebKit/blackberry/ChangeLog (123814 => 123815)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-07-26 23:55:10 UTC (rev 123814)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-07-27 00:01:08 UTC (rev 123815)
@@ -1,5 +1,20 @@
2012-07-26 Nima Ghanavatian <nghanavat...@rim.com>
+ [BlackBerry] Remove synchronous spellchecking code
+ https://bugs.webkit.org/show_bug.cgi?id=92415
+
+ Removing synchronous spellchecking code path.
+
+ Reviewed by Rob Buis.
+
+ Internally reviewed by Mike Fenton.
+
+ * Api/WebPageClient.h:
+ * WebCoreSupport/EditorClientBlackBerry.cpp:
+ (WebCore::EditorClientBlackBerry::checkSpellingOfString):
+
+2012-07-26 Nima Ghanavatian <nghanavat...@rim.com>
+
[BlackBerry] Support async spellcheck for the blackberry port
https://bugs.webkit.org/show_bug.cgi?id=92160
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.cpp (123814 => 123815)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.cpp 2012-07-26 23:55:10 UTC (rev 123814)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.cpp 2012-07-27 00:01:08 UTC (rev 123815)
@@ -556,7 +556,7 @@
void EditorClientBlackBerry::checkSpellingOfString(const UChar* text, int textLength, int* misspellLocation, int* misspellLength)
{
- m_webPagePrivate->m_client->checkSpellingOfString(text, textLength, *misspellLocation, *misspellLength);
+ notImplemented();
}
WTF::String EditorClientBlackBerry::getAutoCorrectSuggestionForMisspelledWord(const WTF::String& misspelledWord)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
