Title: [138978] trunk/Source/WebCore
Revision
138978
Author
eric.carl...@apple.com
Date
2013-01-07 12:53:58 -0800 (Mon, 07 Jan 2013)

Log Message

LayoutUnit(unsigned long long value) compile failure
https://bugs.webkit.org/show_bug.cgi?id=106239

Cast the result of ('unsigned long long' * 'int') to an int before storing in m_value
to avoid compile failure on some platforms.

Reviewed by Ryosuke Niwa.

* platform/LayoutUnit.h:
(WebCore::LayoutUnit::LayoutUnit): Cast to int after multiplication.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (138977 => 138978)


--- trunk/Source/WebCore/ChangeLog	2013-01-07 20:47:54 UTC (rev 138977)
+++ trunk/Source/WebCore/ChangeLog	2013-01-07 20:53:58 UTC (rev 138978)
@@ -1,3 +1,16 @@
+2013-01-07  Eric Carlson  <eric.carl...@apple.com>
+
+        LayoutUnit(unsigned long long value) compile failure
+        https://bugs.webkit.org/show_bug.cgi?id=106239
+
+        Cast the result of ('unsigned long long' * 'int') to an int before storing in m_value
+        to avoid compile failure on some platforms.
+
+        Reviewed by Ryosuke Niwa.
+
+        * platform/LayoutUnit.h:
+        (WebCore::LayoutUnit::LayoutUnit): Cast to int after multiplication.
+
 2013-01-07  Joe Mason  <jma...@rim.com>
 
         [BlackBerry] Handle the new AuthRetry result code in NetworkJob::notifyAuthReceived

Modified: trunk/Source/WebCore/platform/LayoutUnit.h (138977 => 138978)


--- trunk/Source/WebCore/platform/LayoutUnit.h	2013-01-07 20:47:54 UTC (rev 138977)
+++ trunk/Source/WebCore/platform/LayoutUnit.h	2013-01-07 20:53:58 UTC (rev 138978)
@@ -86,7 +86,7 @@
         m_value = clampTo<int>(value * kEffectiveFixedPointDenominator);
 #else
         REPORT_OVERFLOW(isInBounds(static_cast<unsigned>(value)));
-        m_value = value * kEffectiveFixedPointDenominator;
+        m_value = static_cast<int>(value * kEffectiveFixedPointDenominator);
 #endif
     }
     LayoutUnit(float value)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to