Title: [139321] trunk
- Revision
- 139321
- Author
- apav...@chromium.org
- Date
- 2013-01-10 08:27:04 -0800 (Thu, 10 Jan 2013)
Log Message
The "outline-offset" property is not found in the computed style property list
https://bugs.webkit.org/show_bug.cgi?id=106561
Reviewed by Alexis Menard.
Source/WebCore:
Listed CSSPropertyOutlineOffset in the CSSComputedStyleDeclaration's computedProperties[].
Test: fast/css/getComputedStyle/getComputedStyle-outline-offset.html
* css/CSSComputedStyleDeclaration.cpp:
LayoutTests:
* fast/css/getComputedStyle/getComputedStyle-outline-offset-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-outline-offset.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (139320 => 139321)
--- trunk/LayoutTests/ChangeLog 2013-01-10 15:53:25 UTC (rev 139320)
+++ trunk/LayoutTests/ChangeLog 2013-01-10 16:27:04 UTC (rev 139321)
@@ -1,5 +1,15 @@
2013-01-10 Alexander Pavlov <apav...@chromium.org>
+ The "outline-offset" property is not found in the computed style property list
+ https://bugs.webkit.org/show_bug.cgi?id=106561
+
+ Reviewed by Alexis Menard.
+
+ * fast/css/getComputedStyle/getComputedStyle-outline-offset-expected.txt: Added.
+ * fast/css/getComputedStyle/getComputedStyle-outline-offset.html: Added.
+
+2013-01-10 Alexander Pavlov <apav...@chromium.org>
+
CSSParser does not allow the absence of whitespace between "and" and "_expression_"
https://bugs.webkit.org/show_bug.cgi?id=106458
Added: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-outline-offset-expected.txt (0 => 139321)
--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-outline-offset-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-outline-offset-expected.txt 2013-01-10 16:27:04 UTC (rev 139321)
@@ -0,0 +1,11 @@
+Test to make sure outline-offset is found in the computed style.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS computedStyle.getPropertyValue('outline-offset') is '2px'
+PASS computedStyle.getPropertyCSSValue('outline-offset').getFloatValue(CSSPrimitiveValue.CSS_PX) is 2
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-outline-offset.html (0 => 139321)
--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-outline-offset.html (rev 0)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-outline-offset.html 2013-01-10 16:27:04 UTC (rev 139321)
@@ -0,0 +1,30 @@
+<!DOCTYPE html>
+<html>
+<head>
+<meta charset="utf-8">
+<script src=""
+</head>
+<body>
+<script>
+
+description("Test to make sure outline-offset is found in the computed style.")
+
+var testContainer = document.createElement("div");
+document.body.appendChild(testContainer);
+
+testContainer.innerHTML = '<div id="test" style="outline: 2px solid black">hello</div>';
+
+e = document.getElementById('test');
+e.contentEditable = true;
+
+e.style.outlineOffset = "2px";
+computedStyle = window.getComputedStyle(e);
+shouldBe("computedStyle.getPropertyValue('outline-offset')", "'2px'");
+shouldBe("computedStyle.getPropertyCSSValue('outline-offset').getFloatValue(CSSPrimitiveValue.CSS_PX)", "2");
+
+document.body.removeChild(testContainer);
+
+</script>
+<script src=""
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (139320 => 139321)
--- trunk/Source/WebCore/ChangeLog 2013-01-10 15:53:25 UTC (rev 139320)
+++ trunk/Source/WebCore/ChangeLog 2013-01-10 16:27:04 UTC (rev 139321)
@@ -1,3 +1,16 @@
+2013-01-10 Alexander Pavlov <apav...@chromium.org>
+
+ The "outline-offset" property is not found in the computed style property list
+ https://bugs.webkit.org/show_bug.cgi?id=106561
+
+ Reviewed by Alexis Menard.
+
+ Listed CSSPropertyOutlineOffset in the CSSComputedStyleDeclaration's computedProperties[].
+
+ Test: fast/css/getComputedStyle/getComputedStyle-outline-offset.html
+
+ * css/CSSComputedStyleDeclaration.cpp:
+
2013-01-10 David Faure <fa...@kde.org>
PluginPackage::freeLibraryTimerFired asserts if plugin got loaded again meanwhile
Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (139320 => 139321)
--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2013-01-10 15:53:25 UTC (rev 139320)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2013-01-10 16:27:04 UTC (rev 139321)
@@ -164,6 +164,7 @@
CSSPropertyOpacity,
CSSPropertyOrphans,
CSSPropertyOutlineColor,
+ CSSPropertyOutlineOffset,
CSSPropertyOutlineStyle,
CSSPropertyOutlineWidth,
CSSPropertyOverflowWrap,
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
