Title: [143408] trunk/Source/_javascript_Core
- Revision
- 143408
- Author
- oli...@apple.com
- Date
- 2013-02-19 16:42:22 -0800 (Tue, 19 Feb 2013)
Log Message
Don't force everything to be blinded in debug builds
https://bugs.webkit.org/show_bug.cgi?id=110279
Reviewed by Mark Hahnenberg.
Switch to an explicit flag for indicating that we want
every constant to be blinded.
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::shouldBlind):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (143407 => 143408)
--- trunk/Source/_javascript_Core/ChangeLog 2013-02-20 00:35:51 UTC (rev 143407)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-02-20 00:42:22 UTC (rev 143408)
@@ -1,3 +1,16 @@
+2013-02-19 Oliver Hunt <oli...@apple.com>
+
+ Don't force everything to be blinded in debug builds
+ https://bugs.webkit.org/show_bug.cgi?id=110279
+
+ Reviewed by Mark Hahnenberg.
+
+ Switch to an explicit flag for indicating that we want
+ every constant to be blinded.
+
+ * assembler/MacroAssembler.h:
+ (JSC::MacroAssembler::shouldBlind):
+
2013-02-19 Filip Pizlo <fpi...@apple.com>
Fix indentation of Opcode.h
Modified: trunk/Source/_javascript_Core/assembler/MacroAssembler.h (143407 => 143408)
--- trunk/Source/_javascript_Core/assembler/MacroAssembler.h 2013-02-20 00:35:51 UTC (rev 143407)
+++ trunk/Source/_javascript_Core/assembler/MacroAssembler.h 2013-02-20 00:42:22 UTC (rev 143408)
@@ -876,7 +876,7 @@
bool shouldBlind(ImmPtr imm)
{
-#if !defined(NDEBUG)
+#if ENABLE(FORCED_JIT_BLINDING)
UNUSED_PARAM(imm);
// Debug always blind all constants, if only so we know
// if we've broken blinding during patch development.
@@ -934,8 +934,8 @@
}
bool shouldBlind(Imm64 imm)
- {
-#if !defined(NDEBUG)
+ {
+#if ENABLE(FORCED_JIT_BLINDING)
UNUSED_PARAM(imm);
// Debug always blind all constants, if only so we know
// if we've broken blinding during patch development.
@@ -1073,8 +1073,8 @@
#if ENABLE(JIT_CONSTANT_BLINDING)
bool shouldBlind(Imm32 imm)
- {
-#if !defined(NDEBUG)
+ {
+#if ENABLE(FORCED_JIT_BLINDING)
UNUSED_PARAM(imm);
// Debug always blind all constants, if only so we know
// if we've broken blinding during patch development.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
