Title: [143413] branches/chromium/1410/Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp
- Revision
- 143413
- Author
- dgro...@chromium.org
- Date
- 2013-02-19 16:55:49 -0800 (Tue, 19 Feb 2013)
Log Message
Merge 142890
> IndexedDB: Add a few more histogram calls
> https://bugs.webkit.org/show_bug.cgi?id=109762
>
> Reviewed by Tony Chang.
>
> A few places where commits could fail weren't being logged.
>
> * Modules/indexeddb/IDBBackingStore.cpp:
> (WebCore::IDBBackingStore::deleteDatabase):
> (WebCore::IDBBackingStore::Transaction::commit):
>
TBR=dgro...@chromium.org
Review URL: https://codereview.chromium.org/12288067
Modified Paths
Diff
Modified: branches/chromium/1410/Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp (143412 => 143413)
--- branches/chromium/1410/Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp 2013-02-20 00:48:25 UTC (rev 143412)
+++ branches/chromium/1410/Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp 2013-02-20 00:55:49 UTC (rev 143413)
@@ -71,6 +71,8 @@
GetNewDatabaseId,
GetNewVersionNumber,
CreateIDBDatabaseMetaData,
+ DeleteDatabase,
+ TransactionCommit,
IDBLevelDBBackingStoreInternalErrorMax,
};
@@ -587,7 +589,11 @@
const Vector<char> key = DatabaseNameKey::encode(m_identifier, name);
transaction->remove(key);
- return transaction->commit();
+ if (!transaction->commit()) {
+ INTERNAL_WRITE_ERROR(DeleteDatabase);
+ return false;
+ }
+ return true;
}
static bool checkObjectStoreAndMetaDataType(const LevelDBIterator* it, const Vector<char>& stopKey, int64_t objectStoreId, int64_t metaDataType)
@@ -1843,6 +1849,8 @@
ASSERT(m_transaction);
bool result = m_transaction->commit();
m_transaction.clear();
+ if (!result)
+ INTERNAL_WRITE_ERROR(TransactionCommit);
return result;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
