Title: [143455] trunk/Source/WebCore
- Revision
- 143455
- Author
- loi...@chromium.org
- Date
- 2013-02-20 05:40:19 -0800 (Wed, 20 Feb 2013)
Log Message
Web Inspector: fix for frontend closure compile errors.
https://bugs.webkit.org/show_bug.cgi?id=110329
Reviewed by Vsevolod Vlasov.
It has no tests because it has no code changes.
* inspector/front-end/HeapSnapshot.js:
(HeapSnapshotMetainfo):
* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (143454 => 143455)
--- trunk/Source/WebCore/ChangeLog 2013-02-20 13:38:02 UTC (rev 143454)
+++ trunk/Source/WebCore/ChangeLog 2013-02-20 13:40:19 UTC (rev 143455)
@@ -1,3 +1,18 @@
+2013-02-20 Ilya Tikhonovsky <loi...@chromium.org>
+
+ Web Inspector: fix for frontend closure compile errors.
+ https://bugs.webkit.org/show_bug.cgi?id=110329
+
+ Reviewed by Vsevolod Vlasov.
+
+ It has no tests because it has no code changes.
+
+ * inspector/front-end/HeapSnapshot.js:
+ (HeapSnapshotMetainfo):
+ * inspector/front-end/NativeMemorySnapshotView.js:
+ (WebInspector.NativeSnapshotProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
+ (WebInspector.NativeSnapshotProfileType.prototype.buttonClicked):
+
2013-02-20 Florin Malita <fmal...@chromium.org>
Clear SVGPathSeg role on removal.
Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js (143454 => 143455)
--- trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js 2013-02-20 13:38:02 UTC (rev 143454)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js 2013-02-20 13:40:19 UTC (rev 143455)
@@ -508,6 +508,7 @@
this.node_types = [];
this.edge_fields = [];
this.edge_types = [];
+ this.type_strings = {};
// Old format.
this.fields = [];
Modified: trunk/Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js (143454 => 143455)
--- trunk/Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js 2013-02-20 13:38:02 UTC (rev 143454)
+++ trunk/Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js 2013-02-20 13:40:19 UTC (rev 143455)
@@ -266,16 +266,18 @@
/**
* @param {?string} error
* @param {?MemoryAgent.MemoryBlock} memoryBlock
+ * @param {Object=} graphMetaInformation
*/
function didReceiveMemorySnapshot(error, memoryBlock, graphMetaInformation)
{
+ var metaInformation = /** @type{HeapSnapshotMetainfo} */(graphMetaInformation);
this.isTemporary = false;
this.sidebarElement.subtitle = Number.bytesToString(/** @type{number} */(memoryBlock.size));
- var edgeFieldCount = graphMetaInformation.edge_fields.length;
- var nodeFieldCount = graphMetaInformation.node_fields.length;
- var nodeIdFieldOffset = graphMetaInformation.node_fields.indexOf("id");
- var toNodeIdFieldOffset = graphMetaInformation.edge_fields.indexOf("to_node");
+ var edgeFieldCount = metaInformation.edge_fields.length;
+ var nodeFieldCount = metaInformation.node_fields.length;
+ var nodeIdFieldOffset = metaInformation.node_fields.indexOf("id");
+ var toNodeIdFieldOffset = metaInformation.edge_fields.indexOf("to_node");
var baseToRealNodeIdMap = {};
for (var i = 0; i < this._baseToRealNodeId.length; i += 2)
@@ -295,7 +297,7 @@
var heapSnapshot = {
"snapshot": {
- "meta": graphMetaInformation,
+ "meta": metaInformation,
node_count: this._nodes.length / nodeFieldCount,
edge_count: this._edges.length / edgeFieldCount,
root_index: this._nodes.length - nodeFieldCount
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
