Title: [143473] trunk/Source/WebKit/chromium
- Revision
- 143473
- Author
- pilg...@chromium.org
- Date
- 2013-02-20 10:21:39 -0800 (Wed, 20 Feb 2013)
Log Message
[Chromium] Remove idbFactory from WebKitPlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=106457
Reviewed by Adam Barth.
Now that https://codereview.chromium.org/12230054 has landed, the
idbFactory method is no longer needed. (Embedders must now call
the new setIDBFactory method upon initialization.) Part of a
larger refactoring series; see tracking bug 82948.
* public/platform/WebKitPlatformSupport.h:
(WebKit):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (143472 => 143473)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-02-20 18:10:22 UTC (rev 143472)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-02-20 18:21:39 UTC (rev 143473)
@@ -1,3 +1,20 @@
+2013-02-20 Mark Pilgrim <pilg...@chromium.org>
+
+ [Chromium] Remove idbFactory from WebKitPlatformSupport
+ https://bugs.webkit.org/show_bug.cgi?id=106457
+
+ Reviewed by Adam Barth.
+
+ Now that https://codereview.chromium.org/12230054 has landed, the
+ idbFactory method is no longer needed. (Embedders must now call
+ the new setIDBFactory method upon initialization.) Part of a
+ larger refactoring series; see tracking bug 82948.
+
+ * public/platform/WebKitPlatformSupport.h:
+ (WebKit):
+ * src/IDBFactoryBackendProxy.cpp:
+ (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
+
2013-02-20 Mark Lam <mark....@apple.com>
Rename DatabaseBackend to DatabaseBackendBase.
Modified: trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h (143472 => 143473)
--- trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h 2013-02-20 18:10:22 UTC (rev 143472)
+++ trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h 2013-02-20 18:21:39 UTC (rev 143473)
@@ -35,15 +35,7 @@
namespace WebKit {
-class WebIDBFactory; // FIXME: Does this belong in platform?
-
-// FIXME: Eventually all these API will need to move to WebKit::Platform.
class WebKitPlatformSupport : public Platform {
-public:
- // Indexed Database ----------------------------------------------------
-
- virtual WebIDBFactory* idbFactory() { return 0; }
-
protected:
~WebKitPlatformSupport() { }
};
Modified: trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp (143472 => 143473)
--- trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp 2013-02-20 18:10:22 UTC (rev 143472)
+++ trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp 2013-02-20 18:21:39 UTC (rev 143473)
@@ -53,7 +53,6 @@
#include "WorkerLoaderProxy.h"
#include "WorkerScriptController.h"
#include "WorkerThread.h"
-#include "platform/WebKitPlatformSupport.h"
#include <public/WebVector.h>
@@ -75,10 +74,8 @@
IDBFactoryBackendProxy::IDBFactoryBackendProxy()
{
- if (s_webIDBFactory)
- m_webIDBFactory = s_webIDBFactory;
- else
- m_webIDBFactory = webKitPlatformSupport()->idbFactory();
+ ASSERT(s_webIDBFactory);
+ m_webIDBFactory = s_webIDBFactory;
}
IDBFactoryBackendProxy::~IDBFactoryBackendProxy()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
