Title: [151991] trunk/Source/WebInspectorUI
- Revision
- 151991
- Author
- grao...@apple.com
- Date
- 2013-06-26 09:00:18 -0700 (Wed, 26 Jun 2013)
Log Message
Web Inspector: stepping through while paused in debugger makes a popover appear
https://bugs.webkit.org/show_bug.cgi?id=117994
There is no obvious need to call tokenTrackingControllerNewHighlightCandidate when the
active call frame changes and it leads to an extraneous display of the popover.
Reviewed by Timothy Hatcher.
* UserInterface/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._activeCallFrameDidChange):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (151990 => 151991)
--- trunk/Source/WebInspectorUI/ChangeLog 2013-06-26 15:38:58 UTC (rev 151990)
+++ trunk/Source/WebInspectorUI/ChangeLog 2013-06-26 16:00:18 UTC (rev 151991)
@@ -1,3 +1,16 @@
+2013-06-26 Antoine Quint <grao...@apple.com>
+
+ Web Inspector: stepping through while paused in debugger makes a popover appear
+ https://bugs.webkit.org/show_bug.cgi?id=117994
+
+ There is no obvious need to call tokenTrackingControllerNewHighlightCandidate when the
+ active call frame changes and it leads to an extraneous display of the popover.
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/SourceCodeTextEditor.js:
+ (WebInspector.SourceCodeTextEditor.prototype._activeCallFrameDidChange):
+
2013-06-24 Antoine Quint <grao...@apple.com>
Web Inspector: WebInspector.displayNameForURL() failure prevents DOM inspection
Modified: trunk/Source/WebInspectorUI/UserInterface/SourceCodeTextEditor.js (151990 => 151991)
--- trunk/Source/WebInspectorUI/UserInterface/SourceCodeTextEditor.js 2013-06-26 15:38:58 UTC (rev 151990)
+++ trunk/Source/WebInspectorUI/UserInterface/SourceCodeTextEditor.js 2013-06-26 16:00:18 UTC (rev 151991)
@@ -443,9 +443,6 @@
return;
}
- if (this.tokenTrackingController.tracking && this.tokenTrackingController.candidate)
- this.tokenTrackingControllerNewHighlightCandidate(this.tokenTrackingController, this.tokenTrackingController.candidate);
-
this._dismissPopover();
this._activeCallFrameSourceCodeLocation = activeCallFrame.sourceCodeLocation;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes