Title: [157459] trunk/Source/WebInspectorUI
Revision
157459
Author
grao...@apple.com
Date
2013-10-15 12:40:50 -0700 (Tue, 15 Oct 2013)

Log Message

Web Inspector: can't select text inside a text node
https://bugs.webkit.org/show_bug.cgi?id=122828

Reviewed by Timothy Hatcher.

Cancel the default user interaction when a drag action starts if the
element is being edited.

* UserInterface/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype.onattach):
(WebInspector.DOMTreeElement.prototype.handleEvent):

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (157458 => 157459)


--- trunk/Source/WebInspectorUI/ChangeLog	2013-10-15 18:45:29 UTC (rev 157458)
+++ trunk/Source/WebInspectorUI/ChangeLog	2013-10-15 19:40:50 UTC (rev 157459)
@@ -1,3 +1,17 @@
+2013-10-15  Antoine Quint  <grao...@apple.com>
+
+        Web Inspector: can't select text inside a text node
+        https://bugs.webkit.org/show_bug.cgi?id=122828
+
+        Reviewed by Timothy Hatcher.
+
+        Cancel the default user interaction when a drag action starts if the
+        element is being edited.
+
+        * UserInterface/DOMTreeElement.js:
+        (WebInspector.DOMTreeElement.prototype.onattach):
+        (WebInspector.DOMTreeElement.prototype.handleEvent):
+
 2013-10-10  Brian J. Burg  <b...@cs.washington.edu>
 
         Web Inspector: content views and managers should save/restore view state.

Modified: trunk/Source/WebInspectorUI/UserInterface/DOMTreeElement.js (157458 => 157459)


--- trunk/Source/WebInspectorUI/UserInterface/DOMTreeElement.js	2013-10-15 18:45:29 UTC (rev 157458)
+++ trunk/Source/WebInspectorUI/UserInterface/DOMTreeElement.js	2013-10-15 19:40:50 UTC (rev 157459)
@@ -256,6 +256,7 @@
 
         this.updateTitle();
         this.listItemElement.draggable = true;
+        this.listItemElement.addEventListener("dragstart", this);
     },
 
     onpopulate: function()
@@ -1301,6 +1302,12 @@
 
         this._highlightResult = [];
         highlightSearchResults(this.listItemElement, matchRanges, this._highlightResult);
+    },
+
+    handleEvent: function(event)
+    {
+        if (event.type === "dragstart" && this._editing)
+            event.preventDefault();
     }
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to