Title: [160288] trunk/Source/WebCore
Revision
160288
Author
carlo...@webkit.org
Date
2013-12-08 10:16:04 -0800 (Sun, 08 Dec 2013)

Log Message

[GTK] Do not generate new dispatch_event methods marked as deprecated
https://bugs.webkit.org/show_bug.cgi?id=125416

Reviewed by Gustavo Noronha Silva.

* bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction): Skip dispatch_event methods for objects
implementing EventTarget interface unless they are already
deprecated.
(GenerateFunction): Pass also the parentNode to SkipFunction().

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (160287 => 160288)


--- trunk/Source/WebCore/ChangeLog	2013-12-08 16:51:28 UTC (rev 160287)
+++ trunk/Source/WebCore/ChangeLog	2013-12-08 18:16:04 UTC (rev 160288)
@@ -1,3 +1,16 @@
+2013-12-08  Carlos Garcia Campos  <cgar...@igalia.com>
+
+        [GTK] Do not generate new dispatch_event methods marked as deprecated
+        https://bugs.webkit.org/show_bug.cgi?id=125416
+
+        Reviewed by Gustavo Noronha Silva.
+
+        * bindings/scripts/CodeGeneratorGObject.pm:
+        (SkipFunction): Skip dispatch_event methods for objects
+        implementing EventTarget interface unless they are already
+        deprecated.
+        (GenerateFunction): Pass also the parentNode to SkipFunction().
+
 2013-12-05  Jer Noble  <jer.no...@apple.com>
 
         [MSE] Bring end-of-stream algorithm section up to current spec.

Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (160287 => 160288)


--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm	2013-12-08 16:51:28 UTC (rev 160287)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm	2013-12-08 18:16:04 UTC (rev 160288)
@@ -245,6 +245,7 @@
 sub SkipFunction {
     my $object = shift;
     my $function = shift;
+    my $parentNode = shift;
     my $decamelize = shift;
     my $prefix = shift;
 
@@ -288,6 +289,21 @@
         return 1;
     }
 
+    # Skip dispatch_event methods, except the one already deprecated.
+    if ($parentNode->extendedAttributes->{"EventTarget"} && $function->signature->name eq "dispatchEvent"
+        && $functionName ne "webkit_dom_audio_track_list_dispatch_event"
+        && $functionName ne "webkit_dom_battery_manager_dispatch_event"
+        && $functionName ne "webkit_dom_dom_application_cache_dispatch_event"
+        && $functionName ne "webkit_dom_dom_window_dispatch_event"
+        && $functionName ne "webkit_dom_node_dispatch_event"
+        && $functionName ne "webkit_dom_text_track_cue_dispatch_event"
+        && $functionName ne "webkit_dom_text_track_dispatch_event"
+        && $functionName ne "webkit_dom_text_track_list_dispatch_event"
+        && $functionName ne "webkit_dom_video_track_list_dispatch_event"
+        && $functionName ne "webkit_dom_webkit_named_flow_dispatch_event"
+        && $functionName ne "webkit_dom_test_event_target_dispatch_event") {
+        return 1;
+    }
 
     if ($function->signature->name eq "set" and $parentNode->extendedAttributes->{"TypedArray"}) {
         return 1;
@@ -913,7 +929,7 @@
 
     my $decamelize = decamelize($interfaceName);
 
-    if (SkipFunction($object, $function, $decamelize, $prefix)) {
+    if (SkipFunction($object, $function, $parentNode, $decamelize, $prefix)) {
         return;
     }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to