Diff
Modified: trunk/LayoutTests/ChangeLog (160322 => 160323)
--- trunk/LayoutTests/ChangeLog 2013-12-09 19:45:21 UTC (rev 160322)
+++ trunk/LayoutTests/ChangeLog 2013-12-09 20:16:50 UTC (rev 160323)
@@ -1,3 +1,32 @@
+2013-12-09 Mario Sanchez Prada <mario.pr...@samsung.com>
+
+ [ATK] Translate ATK_ROLE_SECTION into "AXSection" in DRT/WKTR
+ https://bugs.webkit.org/show_bug.cgi?id=125456
+
+ Reviewed by Chris Fleizach.
+
+ Update expectations for GTK and EFL that were expecting AXDiv for
+ section roles, so they now expect AXSection.
+
+ * accessibility/adjacent-continuations-cause-assertion-failure-expected.txt:
+ * accessibility/div-within-anchors-causes-crash-expected.txt:
+ * platform/efl-wk1/accessibility/image-map2-expected.txt:
+ * platform/efl-wk1/accessibility/transformed-element-expected.txt:
+ * platform/efl-wk2/accessibility/image-map2-expected.txt:
+ * platform/efl-wk2/accessibility/transformed-element-expected.txt:
+ * platform/efl/accessibility/media-emits-object-replacement-expected.txt:
+ * platform/gtk/accessibility/aria-roles-unignored-expected.txt:
+ * platform/gtk/accessibility/aria-roles-unignored.html:
+ * platform/gtk/accessibility/entry-and-password-expected.txt:
+ * platform/gtk/accessibility/image-map2-expected.txt:
+ * platform/gtk/accessibility/media-emits-object-replacement-expected.txt:
+ * platform/gtk/accessibility/object-with-title-expected.txt:
+ * platform/gtk/accessibility/object-with-title.html:
+ * platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt:
+ * platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt:
+ * platform/gtk/accessibility/spans-paragraphs-and-divs.html:
+ * platform/gtk/accessibility/transformed-element-expected.txt:
+
2013-12-09 Peter Molnar <pmolnar.u-sze...@partner.samsung.com>
Fix handling of 'inherit' and 'initial' for grid lines.
Modified: trunk/LayoutTests/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt (160322 => 160323)
--- trunk/LayoutTests/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt 2013-12-09 19:45:21 UTC (rev 160322)
+++ trunk/LayoutTests/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt 2013-12-09 20:16:50 UTC (rev 160323)
@@ -8,8 +8,8 @@
AXRole: AXWebArea
- AXRole: AXDiv AXValue: y
- AXRole: AXDiv AXValue: End of test
+ AXRole: AXSection AXValue: y
+ AXRole: AXSection AXValue: End of test
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/accessibility/div-within-anchors-causes-crash-expected.txt (160322 => 160323)
--- trunk/LayoutTests/accessibility/div-within-anchors-causes-crash-expected.txt 2013-12-09 19:45:21 UTC (rev 160322)
+++ trunk/LayoutTests/accessibility/div-within-anchors-causes-crash-expected.txt 2013-12-09 20:16:50 UTC (rev 160323)
@@ -2,10 +2,10 @@
Before:
AXRole: AXWebArea
AXRole: AXLink AXValue:
- AXRole: AXDiv AXValue: End of test
+ AXRole: AXSection AXValue: End of test
After:
AXRole: AXWebArea
- AXRole: AXDiv AXValue: End of test
+ AXRole: AXSection AXValue: End of test
This can cause a crash.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Modified: trunk/LayoutTests/platform/efl/accessibility/media-emits-object-replacement-expected.txt (160322 => 160323)
--- trunk/LayoutTests/platform/efl/accessibility/media-emits-object-replacement-expected.txt 2013-12-09 19:45:21 UTC (rev 160322)
+++ trunk/LayoutTests/platform/efl/accessibility/media-emits-object-replacement-expected.txt 2013-12-09 20:16:50 UTC (rev 160323)
@@ -3,20 +3,20 @@
a b
End of test
AXRole: AXWebArea
- AXRole: AXDiv AXValue: a <obj> b
+ AXRole: AXSection AXValue: a <obj> b
AXRole: AXEmbedded
AXRole: AXToolbar
AXRole: AXToolbar
AXRole: AXButton
AXRole: AXSlider
AXRole: AXGroup AXValue: <\n>
- AXRole: AXDiv AXValue: a <obj> b
+ AXRole: AXSection AXValue: a <obj> b
AXRole: AXEmbedded
AXRole: AXToolbar
AXRole: AXToolbar
AXRole: AXButton
AXRole: AXSlider
- AXRole: AXDiv AXValue: End of test
+ AXRole: AXSection AXValue: End of test
This tests ensures that if video or audio tags are used, they will emit an object replacement character in a range for string operation.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Modified: trunk/LayoutTests/platform/efl-wk1/accessibility/image-map2-expected.txt (160322 => 160323)
--- trunk/LayoutTests/platform/efl-wk1/accessibility/image-map2-expected.txt 2013-12-09 19:45:21 UTC (rev 160322)
+++ trunk/LayoutTests/platform/efl-wk1/accessibility/image-map2-expected.txt 2013-12-09 20:16:50 UTC (rev 160323)
@@ -1,6 +1,6 @@
Image map - test 2 - 2 Links (alt tags)
----------------------
-AXRole: AXDiv
+AXRole: AXSection
AXParent: AXWebArea
AXChildren: 0
AXPosition: { 8.000000, 8.000000 }
Modified: trunk/LayoutTests/platform/efl-wk1/accessibility/transformed-element-expected.txt (160322 => 160323)
--- trunk/LayoutTests/platform/efl-wk1/accessibility/transformed-element-expected.txt 2013-12-09 19:45:21 UTC (rev 160322)
+++ trunk/LayoutTests/platform/efl-wk1/accessibility/transformed-element-expected.txt 2013-12-09 20:16:50 UTC (rev 160323)
@@ -1,5 +1,5 @@
hello
-AXRole: AXDiv
+AXRole: AXSection
AXParent: AXWebArea
AXChildren: 1
AXPosition: { 8.000000, 9.000000 }
Modified: trunk/LayoutTests/platform/efl-wk2/accessibility/image-map2-expected.txt (160322 => 160323)
--- trunk/LayoutTests/platform/efl-wk2/accessibility/image-map2-expected.txt 2013-12-09 19:45:21 UTC (rev 160322)
+++ trunk/LayoutTests/platform/efl-wk2/accessibility/image-map2-expected.txt 2013-12-09 20:16:50 UTC (rev 160323)
@@ -1,6 +1,6 @@
Image map - test 2 - 2 Links (alt tags)
----------------------
-AXRole: AXDiv
+AXRole: AXSection
AXParent: AXWebArea
AXChildren: 0
AXPosition: { 0.000000, 0.000000 }
Modified: trunk/LayoutTests/platform/efl-wk2/accessibility/transformed-element-expected.txt (160322 => 160323)
--- trunk/LayoutTests/platform/efl-wk2/accessibility/transformed-element-expected.txt 2013-12-09 19:45:21 UTC (rev 160322)
+++ trunk/LayoutTests/platform/efl-wk2/accessibility/transformed-element-expected.txt 2013-12-09 20:16:50 UTC (rev 160323)
@@ -1,5 +1,5 @@
hello
-AXRole: AXDiv
+AXRole: AXSection
AXParent: AXWebArea
AXChildren: 1
AXPosition: { 0.000000, 0.000000 }
Modified: trunk/LayoutTests/platform/gtk/accessibility/aria-roles-unignored-expected.txt (160322 => 160323)
--- trunk/LayoutTests/platform/gtk/accessibility/aria-roles-unignored-expected.txt 2013-12-09 19:45:21 UTC (rev 160322)
+++ trunk/LayoutTests/platform/gtk/accessibility/aria-roles-unignored-expected.txt 2013-12-09 20:16:50 UTC (rev 160323)
@@ -18,7 +18,7 @@
PASS element.role is 'AXRole: AXHeading'
PASS element.role is 'AXRole: AXForm'
PASS element.role is 'AXRole: AXButton'
-PASS element.role is 'AXRole: AXDiv'
+PASS element.role is 'AXRole: AXSection'
PASS element.role is 'AXRole: AXTextField'
PASS successfullyParsed is true
Modified: trunk/LayoutTests/platform/gtk/accessibility/aria-roles-unignored.html (160322 => 160323)
--- trunk/LayoutTests/platform/gtk/accessibility/aria-roles-unignored.html 2013-12-09 19:45:21 UTC (rev 160322)
+++ trunk/LayoutTests/platform/gtk/accessibility/aria-roles-unignored.html 2013-12-09 20:16:50 UTC (rev 160323)
@@ -51,7 +51,7 @@
// Divs
element = webArea.childAtIndex(5);
- shouldBe("element.role", "'AXRole: AXDiv'");
+ shouldBe("element.role", "'AXRole: AXSection'");
element = webArea.childAtIndex(6);
shouldBe("element.role", "'AXRole: AXTextField'");
}
Modified: trunk/LayoutTests/platform/gtk/accessibility/entry-and-password-expected.txt (160322 => 160323)
--- trunk/LayoutTests/platform/gtk/accessibility/entry-and-password-expected.txt 2013-12-09 19:45:21 UTC (rev 160322)
+++ trunk/LayoutTests/platform/gtk/accessibility/entry-and-password-expected.txt 2013-12-09 20:16:50 UTC (rev 160323)
@@ -4,7 +4,7 @@
AXRole: AXForm AXValue: <obj> <obj>
AXRole: AXTextField AXValue: 123
AXRole: AXPasswordField AXValue: •••
- AXRole: AXDiv AXValue: End of test
+ AXRole: AXSection AXValue: End of test
This tests that the text associated with entry and password fields is correct.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Modified: trunk/LayoutTests/platform/gtk/accessibility/image-map2-expected.txt (160322 => 160323)
--- trunk/LayoutTests/platform/gtk/accessibility/image-map2-expected.txt 2013-12-09 19:45:21 UTC (rev 160322)
+++ trunk/LayoutTests/platform/gtk/accessibility/image-map2-expected.txt 2013-12-09 20:16:50 UTC (rev 160323)
@@ -1,6 +1,6 @@
Image map - test 2 - 2 Links (alt tags)
----------------------
-AXRole: AXDiv
+AXRole: AXSection
AXParent: AXWebArea
AXChildren: 0
AXPosition: { 8.000000, 8.000000 }
Modified: trunk/LayoutTests/platform/gtk/accessibility/media-emits-object-replacement-expected.txt (160322 => 160323)
--- trunk/LayoutTests/platform/gtk/accessibility/media-emits-object-replacement-expected.txt 2013-12-09 19:45:21 UTC (rev 160322)
+++ trunk/LayoutTests/platform/gtk/accessibility/media-emits-object-replacement-expected.txt 2013-12-09 20:16:50 UTC (rev 160323)
@@ -3,20 +3,20 @@
a b
End of test
AXRole: AXWebArea
- AXRole: AXDiv AXValue: a <obj> b
+ AXRole: AXSection AXValue: a <obj> b
AXRole: AXEmbedded
AXRole: AXToolbar
AXRole: AXToolbar
AXRole: AXButton
AXRole: AXSlider
AXRole: AXGroup AXValue: <\n>
- AXRole: AXDiv AXValue: a <obj> b
+ AXRole: AXSection AXValue: a <obj> b
AXRole: AXEmbedded
AXRole: AXToolbar
AXRole: AXToolbar
AXRole: AXButton
AXRole: AXSlider
- AXRole: AXDiv AXValue: End of test
+ AXRole: AXSection AXValue: End of test
This tests ensures that if video or audio tags are used, they will emit an object replacement character in a range for string operation.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Modified: trunk/LayoutTests/platform/gtk/accessibility/object-with-title-expected.txt (160322 => 160323)
--- trunk/LayoutTests/platform/gtk/accessibility/object-with-title-expected.txt 2013-12-09 19:45:21 UTC (rev 160322)
+++ trunk/LayoutTests/platform/gtk/accessibility/object-with-title-expected.txt 2013-12-09 20:16:50 UTC (rev 160323)
@@ -8,7 +8,7 @@
PASS child.role is 'AXRole: AXList'
-PASS child.role is 'AXRole: AXDiv'
+PASS child.role is 'AXRole: AXSection'
PASS child.role is 'AXRole: AXList'
PASS successfullyParsed is true
Modified: trunk/LayoutTests/platform/gtk/accessibility/object-with-title.html (160322 => 160323)
--- trunk/LayoutTests/platform/gtk/accessibility/object-with-title.html 2013-12-09 19:45:21 UTC (rev 160322)
+++ trunk/LayoutTests/platform/gtk/accessibility/object-with-title.html 2013-12-09 20:16:50 UTC (rev 160323)
@@ -23,7 +23,7 @@
shouldBe("child.role", "'AXRole: AXList'");
child = webArea.childAtIndex(1);
- shouldBe("child.role", "'AXRole: AXDiv'");
+ shouldBe("child.role", "'AXRole: AXSection'");
child = child.childAtIndex(0);
shouldBe("child.role", "'AXRole: AXList'");
Modified: trunk/LayoutTests/platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt (160322 => 160323)
--- trunk/LayoutTests/platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt 2013-12-09 19:45:21 UTC (rev 160322)
+++ trunk/LayoutTests/platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt 2013-12-09 20:16:50 UTC (rev 160323)
@@ -20,12 +20,12 @@
AXRole: AXWebArea
AXRole: AXGroup AXValue: <obj>
AXRole: AXTextField AXValue: text area
- AXRole: AXDiv AXValue: Div<\n><obj>
+ AXRole: AXSection AXValue: Div<\n><obj>
AXRole: AXButton
AXRole: AXHeading AXValue: Heading<\n><obj><\n><obj>
AXRole: AXButton
AXRole: AXImage
- AXRole: AXDiv AXValue: End of test
+ AXRole: AXSection AXValue: End of test
This tests that the text associated with replaced objects in an anonymous block is correct.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Modified: trunk/LayoutTests/platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt (160322 => 160323)
--- trunk/LayoutTests/platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt 2013-12-09 19:45:21 UTC (rev 160322)
+++ trunk/LayoutTests/platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt 2013-12-09 20:16:50 UTC (rev 160323)
@@ -34,17 +34,17 @@
PASS link.childrenCount is 0
PASS element.role is 'AXRole: AXParagraph'
PASS element.childrenCount is 0
-PASS element.role is 'AXRole: AXDiv'
+PASS element.role is 'AXRole: AXSection'
PASS element.childrenCount is 1
PASS link.role is 'AXRole: AXLink'
PASS link.childrenCount is 0
-PASS element.role is 'AXRole: AXDiv'
+PASS element.role is 'AXRole: AXSection'
PASS element.childrenCount is 0
-PASS element.role is 'AXRole: AXDiv'
+PASS element.role is 'AXRole: AXSection'
PASS element.childrenCount is 1
PASS link.role is 'AXRole: AXLink'
PASS link.childrenCount is 0
-PASS element.role is 'AXRole: AXDiv'
+PASS element.role is 'AXRole: AXSection'
PASS element.childrenCount is 0
PASS successfullyParsed is true
Modified: trunk/LayoutTests/platform/gtk/accessibility/spans-paragraphs-and-divs.html (160322 => 160323)
--- trunk/LayoutTests/platform/gtk/accessibility/spans-paragraphs-and-divs.html 2013-12-09 19:45:21 UTC (rev 160322)
+++ trunk/LayoutTests/platform/gtk/accessibility/spans-paragraphs-and-divs.html 2013-12-09 20:16:50 UTC (rev 160323)
@@ -83,7 +83,7 @@
shouldBe("element.childrenCount", "0");
element = webArea.childAtIndex(4);
- shouldBe("element.role", "'AXRole: AXDiv'");
+ shouldBe("element.role", "'AXRole: AXSection'");
shouldBe("element.childrenCount", "1");
link = element.childAtIndex(0);
@@ -91,11 +91,11 @@
shouldBe("link.childrenCount", "0");
element = webArea.childAtIndex(5);
- shouldBe("element.role", "'AXRole: AXDiv'");
+ shouldBe("element.role", "'AXRole: AXSection'");
shouldBe("element.childrenCount", "0");
element = webArea.childAtIndex(6);
- shouldBe("element.role", "'AXRole: AXDiv'");
+ shouldBe("element.role", "'AXRole: AXSection'");
shouldBe("element.childrenCount", "1");
link = element.childAtIndex(0);
@@ -103,7 +103,7 @@
shouldBe("link.childrenCount", "0");
element = webArea.childAtIndex(7);
- shouldBe("element.role", "'AXRole: AXDiv'");
+ shouldBe("element.role", "'AXRole: AXSection'");
shouldBe("element.childrenCount", "0");
}
Modified: trunk/LayoutTests/platform/gtk/accessibility/transformed-element-expected.txt (160322 => 160323)
--- trunk/LayoutTests/platform/gtk/accessibility/transformed-element-expected.txt 2013-12-09 19:45:21 UTC (rev 160322)
+++ trunk/LayoutTests/platform/gtk/accessibility/transformed-element-expected.txt 2013-12-09 20:16:50 UTC (rev 160323)
@@ -1,5 +1,5 @@
hello
-AXRole: AXDiv
+AXRole: AXSection
AXParent: AXWebArea
AXChildren: 1
AXPosition: { 8.000000, 9.000000 }
Modified: trunk/Tools/ChangeLog (160322 => 160323)
--- trunk/Tools/ChangeLog 2013-12-09 19:45:21 UTC (rev 160322)
+++ trunk/Tools/ChangeLog 2013-12-09 20:16:50 UTC (rev 160323)
@@ -1,3 +1,15 @@
+2013-12-09 Mario Sanchez Prada <mario.pr...@samsung.com>
+
+ [ATK] Translate ATK_ROLE_SECTION into "AXSection" in DRT/WKTR
+ https://bugs.webkit.org/show_bug.cgi?id=125456
+
+ Reviewed by Chris Fleizach.
+
+ Return 'AXSection' for section roles instead of 'AXDiv'.
+
+ * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
+ * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+
2013-12-09 Brian J. Burg <b...@cs.washington.edu>
check-webkit-style should check for extra newlines at EOF
Modified: trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp (160322 => 160323)
--- trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp 2013-12-09 19:45:21 UTC (rev 160322)
+++ trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp 2013-12-09 20:16:50 UTC (rev 160323)
@@ -258,7 +258,7 @@
case ATK_ROLE_SCROLL_PANE:
return "AXScrollArea";
case ATK_ROLE_SECTION:
- return "AXDiv";
+ return "AXSection";
case ATK_ROLE_SEPARATOR:
return "AXHorizontalRule";
case ATK_ROLE_SLIDER:
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp (160322 => 160323)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2013-12-09 19:45:21 UTC (rev 160322)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2013-12-09 20:16:50 UTC (rev 160323)
@@ -347,7 +347,7 @@
case ATK_ROLE_SCROLL_PANE:
return "AXScrollArea";
case ATK_ROLE_SECTION:
- return "AXDiv";
+ return "AXSection";
case ATK_ROLE_SEPARATOR:
return "AXHorizontalRule";
case ATK_ROLE_SLIDER:
