Title: [161231] trunk/Source/WebCore
- Revision
- 161231
- Author
- commit-qu...@webkit.org
- Date
- 2014-01-02 15:14:07 -0800 (Thu, 02 Jan 2014)
Log Message
Video-seek-with-negative-playback was flaky.
https://bugs.webkit.org/show_bug.cgi?id=126379
Patch by Piotr Grad <p.g...@samsung.com> on 2014-01-02
Reviewed by Eric Carlson.
No new tests. Covered by existing tests.
m_player->setRate() should be called before updating m_playbackRate, because potentiallyPlaying() depends
on endedPlayback(), which checks m_playbackRate.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setPlaybackRate):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (161230 => 161231)
--- trunk/Source/WebCore/ChangeLog 2014-01-02 22:57:14 UTC (rev 161230)
+++ trunk/Source/WebCore/ChangeLog 2014-01-02 23:14:07 UTC (rev 161231)
@@ -1,3 +1,18 @@
+2014-01-02 Piotr Grad <p.g...@samsung.com>
+
+ Video-seek-with-negative-playback was flaky.
+ https://bugs.webkit.org/show_bug.cgi?id=126379
+
+ Reviewed by Eric Carlson.
+
+ No new tests. Covered by existing tests.
+
+ m_player->setRate() should be called before updating m_playbackRate, because potentiallyPlaying() depends
+ on endedPlayback(), which checks m_playbackRate.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::setPlaybackRate):
+
2014-01-02 Daniel Bates <daba...@apple.com>
[iOS] Tapping any link crashes in WebCore::EventHandler::mouseMoved()
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (161230 => 161231)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-01-02 22:57:14 UTC (rev 161230)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-01-02 23:14:07 UTC (rev 161231)
@@ -2565,15 +2565,15 @@
void HTMLMediaElement::setPlaybackRate(double rate)
{
LOG(Media, "HTMLMediaElement::setPlaybackRate(%f)", rate);
-
+
+ if (m_player && potentiallyPlaying() && m_player->rate() != rate && !m_mediaController)
+ m_player->setRate(rate);
+
if (m_playbackRate != rate) {
m_playbackRate = rate;
invalidateCachedTime();
scheduleEvent(eventNames().ratechangeEvent);
}
-
- if (m_player && potentiallyPlaying() && m_player->rate() != rate && !m_mediaController)
- m_player->setRate(rate);
}
void HTMLMediaElement::updatePlaybackRate()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
