Title: [164292] trunk/Source/WebInspectorUI
- Revision
- 164292
- Author
- grao...@webkit.org
- Date
- 2014-02-18 08:13:23 -0800 (Tue, 18 Feb 2014)
Log Message
Web Inspector: color picker sliders sometime look wrong on Retina display
https://bugs.webkit.org/show_bug.cgi?id=128963
Reviewed by Timothy Hatcher.
Round the values used to position and size popovers in order to ensure that their content don't suffer
from poor pixel alignment on Retina displays.
* UserInterface/Popover.js:
(WebInspector.Popover.prototype.set frame):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (164291 => 164292)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-02-18 15:21:05 UTC (rev 164291)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-02-18 16:13:23 UTC (rev 164292)
@@ -1,3 +1,16 @@
+2014-02-18 Antoine Quint <grao...@webkit.org>
+
+ Web Inspector: color picker sliders sometime look wrong on Retina display
+ https://bugs.webkit.org/show_bug.cgi?id=128963
+
+ Reviewed by Timothy Hatcher.
+
+ Round the values used to position and size popovers in order to ensure that their content don't suffer
+ from poor pixel alignment on Retina displays.
+
+ * UserInterface/Popover.js:
+ (WebInspector.Popover.prototype.set frame):
+
2014-02-17 Antoine Quint <grao...@webkit.org>
Web Inspector: CSS selectors containing a color name shouldn't be considered for color editing
Modified: trunk/Source/WebInspectorUI/UserInterface/Popover.js (164291 => 164292)
--- trunk/Source/WebInspectorUI/UserInterface/Popover.js 2014-02-18 15:21:05 UTC (rev 164291)
+++ trunk/Source/WebInspectorUI/UserInterface/Popover.js 2014-02-18 16:13:23 UTC (rev 164292)
@@ -78,11 +78,11 @@
set frame(frame)
{
- this._element.style.left = frame.origin.x + "px";
- this._element.style.top = frame.origin.y + "px";
- this._element.style.width = frame.size.width + "px";
- this._element.style.height = frame.size.height + "px";
- this._element.style.backgroundSize = frame.size.width + "px " + frame.size.height + "px";
+ this._element.style.left = Math.round(frame.origin.x) + "px";
+ this._element.style.top = Math.round(frame.origin.y) + "px";
+ this._element.style.width = Math.ceil(frame.size.width) + "px";
+ this._element.style.height = Math.ceil(frame.size.height) + "px";
+ this._element.style.backgroundSize = Math.ceil(frame.size.width) + "px " + Math.ceil(frame.size.height) + "px";
this._frame = frame;
},
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
