Title: [164429] trunk/Source/WebInspectorUI
- Revision
- 164429
- Author
- grao...@webkit.org
- Date
- 2014-02-20 08:43:35 -0800 (Thu, 20 Feb 2014)
Log Message
Web Inspector: clicking on a color swatch in the Computed styles tab shouldn't show the color editing popover
https://bugs.webkit.org/show_bug.cgi?id=129093
Reviewed by Timothy Hatcher.
If the current editor is read-only, only allow cycling between color types since it wouldn't make sense to edit
such colors.
* UserInterface/CSSStyleDeclarationTextEditor.js:
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (164428 => 164429)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-02-20 15:23:48 UTC (rev 164428)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-02-20 16:43:35 UTC (rev 164429)
@@ -1,3 +1,15 @@
+2014-02-20 Antoine Quint <grao...@webkit.org>
+
+ Web Inspector: clicking on a color swatch in the Computed styles tab shouldn't show the color editing popover
+ https://bugs.webkit.org/show_bug.cgi?id=129093
+
+ Reviewed by Timothy Hatcher.
+
+ If the current editor is read-only, only allow cycling between color types since it wouldn't make sense to edit
+ such colors.
+
+ * UserInterface/CSSStyleDeclarationTextEditor.js:
+
2014-02-19 Joseph Pecoraro <pecor...@apple.com>
Web Inspector: Remove unused InspectorBackend member variable
Modified: trunk/Source/WebInspectorUI/UserInterface/CSSStyleDeclarationTextEditor.js (164428 => 164429)
--- trunk/Source/WebInspectorUI/UserInterface/CSSStyleDeclarationTextEditor.js 2014-02-20 15:23:48 UTC (rev 164428)
+++ trunk/Source/WebInspectorUI/UserInterface/CSSStyleDeclarationTextEditor.js 2014-02-20 16:43:35 UTC (rev 164429)
@@ -679,7 +679,7 @@
this._codeMirror.operation(update.bind(this));
}
- if (event.shiftKey) {
+ if (event.shiftKey || this._codeMirror.getOption("readOnly")) {
var nextFormat = color.nextFormat();
console.assert(nextFormat);
if (!nextFormat)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
