Title: [164528] trunk/Source/WebCore
- Revision
- 164528
- Author
- a...@apple.com
- Date
- 2014-02-21 22:07:41 -0800 (Fri, 21 Feb 2014)
Log Message
CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify contains seemingly accidental unreachable code
https://bugs.webkit.org/show_bug.cgi?id=129193
Reviewed by Joseph Pecoraro.
* crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify): Fix the accidental code.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (164527 => 164528)
--- trunk/Source/WebCore/ChangeLog 2014-02-22 05:05:53 UTC (rev 164527)
+++ trunk/Source/WebCore/ChangeLog 2014-02-22 06:07:41 UTC (rev 164528)
@@ -1,3 +1,13 @@
+2014-02-21 Alexey Proskuryakov <a...@apple.com>
+
+ CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify contains seemingly accidental unreachable code
+ https://bugs.webkit.org/show_bug.cgi?id=129193
+
+ Reviewed by Joseph Pecoraro.
+
+ * crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
+ (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify): Fix the accidental code.
+
2014-02-21 Brent Fulgham <bfulg...@apple.com>
Extend media support for WebVTT sources
Modified: trunk/Source/WebCore/crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp (164527 => 164528)
--- trunk/Source/WebCore/crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp 2014-02-22 05:05:53 UTC (rev 164527)
+++ trunk/Source/WebCore/crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp 2014-02-22 06:07:41 UTC (rev 164528)
@@ -88,7 +88,7 @@
CCCryptorStatus status = CCRSACryptorVerify(key.platformKey(), ccPKCS1Padding, digestData.data(), digestData.size(), digestAlgorithm, 0, signature.first, signature.second);
if (!status)
callback(true);
- else if (status == kCCNotVerified || kCCDecodeError) // <rdar://problem/15464982> CCRSACryptorVerify returns kCCDecodeError instead of kCCNotVerified sometimes
+ else if (status == kCCNotVerified || status == kCCDecodeError) // <rdar://problem/15464982> CCRSACryptorVerify returns kCCDecodeError instead of kCCNotVerified sometimes
callback(false);
else
failureCallback();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
