Title: [164980] trunk/Source/WebCore
- Revision
- 164980
- Author
- commit-qu...@webkit.org
- Date
- 2014-03-03 02:16:55 -0800 (Mon, 03 Mar 2014)
Log Message
[GTK] webkit_dom_range_compare_boundary_points fails when 0 is passed as how parameter
https://bugs.webkit.org/show_bug.cgi?id=129145
Patch by Tomas Popela <tpop...@redhat.com> on 2014-03-03
Reviewed by Carlos Garcia Campos.
While generating GObject DOM API the generator should skip non pointer
types while generating the g_return_val_if_fail macro.
This will avoid the situation when Range.START_TO_START is defined as 0,
thus the webkit_dom_range_compare_boundary_points function will fail
everytime it is called with 0 as how value.
* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (164979 => 164980)
--- trunk/Source/WebCore/ChangeLog 2014-03-03 10:15:52 UTC (rev 164979)
+++ trunk/Source/WebCore/ChangeLog 2014-03-03 10:16:55 UTC (rev 164980)
@@ -1,3 +1,19 @@
+2014-03-03 Tomas Popela <tpop...@redhat.com>
+
+ [GTK] webkit_dom_range_compare_boundary_points fails when 0 is passed as how parameter
+ https://bugs.webkit.org/show_bug.cgi?id=129145
+
+ Reviewed by Carlos Garcia Campos.
+
+ While generating GObject DOM API the generator should skip non pointer
+ types while generating the g_return_val_if_fail macro.
+ This will avoid the situation when Range.START_TO_START is defined as 0,
+ thus the webkit_dom_range_compare_boundary_points function will fail
+ everytime it is called with 0 as how value.
+
+ * bindings/scripts/CodeGeneratorGObject.pm:
+ (GenerateFunction):
+
2014-03-03 Jozsef Berta <jberta.u-sze...@partner.samsung.com>
[cmake] *Names.cpp file should be regenerated after touching StaticString.pm
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (164979 => 164980)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2014-03-03 10:15:52 UTC (rev 164979)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2014-03-03 10:16:55 UTC (rev 164980)
@@ -1053,9 +1053,8 @@
foreach my $param (@{$function->parameters}) {
my $paramName = $param->name;
my $paramIDLType = $param->type;
- my $paramTypeIsPrimitive = $codeGenerator->IsPrimitiveType($paramIDLType);
- my $paramIsGDOMType = IsGDOMClassType($paramIDLType);
- if (!$paramTypeIsPrimitive) {
+ my $paramTypeIsPointer = !$codeGenerator->IsNonPointerType($paramIDLType);
+ if ($paramTypeIsPointer) {
$gReturnMacro = GetGReturnMacro($paramName, $paramIDLType, $returnType, $functionName);
push(@cBody, $gReturnMacro);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
