Title: [165809] trunk/Tools
- Revision
- 165809
- Author
- be...@igalia.com
- Date
- 2014-03-18 06:44:28 -0700 (Tue, 18 Mar 2014)
Log Message
[GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
https://bugs.webkit.org/show_bug.cgi?id=130388
Reviewed by Sergio Villar Senin.
* Scripts/webkitdirs.pm:
(shouldRemoveCMakeCache): make sure that the build directory
exists before attempting to create a file in it.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (165808 => 165809)
--- trunk/Tools/ChangeLog 2014-03-18 12:51:19 UTC (rev 165808)
+++ trunk/Tools/ChangeLog 2014-03-18 13:44:28 UTC (rev 165809)
@@ -1,3 +1,14 @@
+2014-03-18 Alberto Garcia <be...@igalia.com>
+
+ [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
+ https://bugs.webkit.org/show_bug.cgi?id=130388
+
+ Reviewed by Sergio Villar Senin.
+
+ * Scripts/webkitdirs.pm:
+ (shouldRemoveCMakeCache): make sure that the build directory
+ exists before attempting to create a file in it.
+
2014-03-18 Robert Plociennik <r.plocien...@samsung.com>
[EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
Modified: trunk/Tools/Scripts/webkitdirs.pm (165808 => 165809)
--- trunk/Tools/Scripts/webkitdirs.pm 2014-03-18 12:51:19 UTC (rev 165808)
+++ trunk/Tools/Scripts/webkitdirs.pm 2014-03-18 13:44:28 UTC (rev 165809)
@@ -1933,9 +1933,11 @@
}
# We check this first, because we always want to create this file for a fresh build.
- my $optionsCache = File::Spec->catdir(baseProductDir(), configuration(), "build-webkit-options.txt");
+ my $productDir = File::Spec->catdir(baseProductDir(), configuration());
+ my $optionsCache = File::Spec->catdir($productDir, "build-webkit-options.txt");
my $joinedBuildArgs = join(" ", @buildArgs);
if (isCachedArgumentfileOutOfDate($optionsCache, $joinedBuildArgs)) {
+ File::Path::mkpath($productDir) unless -d $productDir;
open(CACHED_ARGUMENTS, ">", $optionsCache);
print CACHED_ARGUMENTS $joinedBuildArgs;
close(CACHED_ARGUMENTS);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
