Title: [167834] trunk/Tools
- Revision
- 167834
- Author
- jcr...@apple.com
- Date
- 2014-04-25 16:48:10 -0700 (Fri, 25 Apr 2014)
Log Message
Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
https://bugs.webkit.org/show_bug.cgi?id=132209
Reviewed by Daniel Bates.
Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
Run check-webkit-style before generating changelogs to avoid additional spurious errors.
* Scripts/prepare-ChangeLog:
(main):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (167833 => 167834)
--- trunk/Tools/ChangeLog 2014-04-25 23:43:15 UTC (rev 167833)
+++ trunk/Tools/ChangeLog 2014-04-25 23:48:10 UTC (rev 167834)
@@ -1,3 +1,16 @@
+2014-04-25 James Craig <jcr...@apple.com>
+
+ Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
+ https://bugs.webkit.org/show_bug.cgi?id=132209
+
+ Reviewed by Daniel Bates.
+
+ Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
+ Run check-webkit-style before generating changelogs to avoid additional spurious errors.
+
+ * Scripts/prepare-ChangeLog:
+ (main):
+
2014-04-25 Michael Saboff <msab...@apple.com>
Crash in platform/mac/accessibility/table-visible-rows.html
Modified: trunk/Tools/Scripts/prepare-ChangeLog (167833 => 167834)
--- trunk/Tools/Scripts/prepare-ChangeLog 2014-04-25 23:43:15 UTC (rev 167833)
+++ trunk/Tools/Scripts/prepare-ChangeLog 2014-04-25 23:48:10 UTC (rev 167834)
@@ -128,7 +128,7 @@
my $gitCommit = 0;
my $gitIndex = "";
my $gitReviewer = "";
- my $checkWebKitStyle = 1;
+ my $checkWebKitStyle;
my $openChangeLogs = 0;
my $writeChangeLogs = 1;
my $showHelp = 0;
@@ -168,6 +168,11 @@
return 1;
}
+ if ($checkWebKitStyle) {
+ print STDERR " Running check-webkit-style.\n ";
+ system "$FindBin::Bin/check-webkit-style";
+ }
+
die "--git-commit and --git-index are incompatible." if ($gitIndex && $gitCommit);
isSVN() || isGit() || die "Couldn't determine your version control system.";
@@ -228,11 +233,6 @@
printDiff($changedFiles, $gitCommit, $gitIndex, $mergeBase);
}
- if ($checkWebKitStyle) {
- print STDERR " Running check-webkit-style.\n ";
- system "$FindBin::Bin/check-webkit-style";
- }
-
# Open ChangeLogs.
if ($openChangeLogs && @$changeLogs) {
openChangeLogs($changeLogs);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
