Title: [167929] trunk/Source/_javascript_Core
- Revision
- 167929
- Author
- commit-qu...@webkit.org
- Date
- 2014-04-29 07:06:05 -0700 (Tue, 29 Apr 2014)
Log Message
LLINT loadisFromInstruction doesn't need special case for big endians
https://bugs.webkit.org/show_bug.cgi?id=132330
Patch by Tomas Popela <tpop...@redhat.com> on 2014-04-29
Reviewed by Mark Lam.
The change introduced in r167076 was wrong. We should not apply the offset
adjustment on loadisFromInstruction usage as the instruction
(UnlinkedInstruction) is declared as an union (i.e. with the int32_t
operand variable). The offset of the other union members will be the
same as the offset of the first one, that is 0. The behavior here is the
same on little and big endian architectures. Thus we don't need
special case for big endians.
* llint/LowLevelInterpreter.asm:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (167928 => 167929)
--- trunk/Source/_javascript_Core/ChangeLog 2014-04-29 12:38:20 UTC (rev 167928)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-04-29 14:06:05 UTC (rev 167929)
@@ -1,3 +1,20 @@
+2014-04-29 Tomas Popela <tpop...@redhat.com>
+
+ LLINT loadisFromInstruction doesn't need special case for big endians
+ https://bugs.webkit.org/show_bug.cgi?id=132330
+
+ Reviewed by Mark Lam.
+
+ The change introduced in r167076 was wrong. We should not apply the offset
+ adjustment on loadisFromInstruction usage as the instruction
+ (UnlinkedInstruction) is declared as an union (i.e. with the int32_t
+ operand variable). The offset of the other union members will be the
+ same as the offset of the first one, that is 0. The behavior here is the
+ same on little and big endian architectures. Thus we don't need
+ special case for big endians.
+
+ * llint/LowLevelInterpreter.asm:
+
2014-04-28 Mark Hahnenberg <mhahnenb...@apple.com>
Simplify tryCacheGetById
Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm (167928 => 167929)
--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm 2014-04-29 12:38:20 UTC (rev 167928)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm 2014-04-29 14:06:05 UTC (rev 167929)
@@ -106,11 +106,7 @@
const tagMask = csr2
macro loadisFromInstruction(offset, dest)
-if BIG_ENDIAN
- loadis 4 + offset * 8[PB, PC, 8], dest
-else
loadis offset * 8[PB, PC, 8], dest
-end
end
macro loadpFromInstruction(offset, dest)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
