Title: [170101] trunk/Source/WebKit2
Revision
170101
Author
m...@apple.com
Date
2014-06-18 10:02:18 -0700 (Wed, 18 Jun 2014)

Log Message

Remove the unused _WKBackForwardListDidChangeNotification.

Reviewed by Anders Carlsson.

* UIProcess/API/Cocoa/WKBackForwardList.mm:
* UIProcess/API/Cocoa/WKBackForwardListInternal.h:
* UIProcess/API/Cocoa/WKBackForwardListPrivate.h: Removed.
* UIProcess/Cocoa/NavigationState.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::LoaderClient::didChangeBackForwardList): Deleted.
* WebKit2.xcodeproj/project.pbxproj:

Modified Paths

Removed Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (170100 => 170101)


--- trunk/Source/WebKit2/ChangeLog	2014-06-18 15:09:26 UTC (rev 170100)
+++ trunk/Source/WebKit2/ChangeLog	2014-06-18 17:02:18 UTC (rev 170101)
@@ -1,3 +1,17 @@
+2014-06-18  Dan Bernstein  <m...@apple.com>
+
+        Remove the unused _WKBackForwardListDidChangeNotification.
+
+        Reviewed by Anders Carlsson.
+
+        * UIProcess/API/Cocoa/WKBackForwardList.mm:
+        * UIProcess/API/Cocoa/WKBackForwardListInternal.h:
+        * UIProcess/API/Cocoa/WKBackForwardListPrivate.h: Removed.
+        * UIProcess/Cocoa/NavigationState.h:
+        * UIProcess/Cocoa/NavigationState.mm:
+        (WebKit::NavigationState::LoaderClient::didChangeBackForwardList): Deleted.
+        * WebKit2.xcodeproj/project.pbxproj:
+
 2014-06-18  Andreas Kling  <akl...@apple.com>
 
         Set main thread QoS policies after IPC initialization.

Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.mm (170100 => 170101)


--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.mm	2014-06-18 15:09:26 UTC (rev 170100)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.mm	2014-06-18 17:02:18 UTC (rev 170101)
@@ -31,12 +31,6 @@
 #import "WKBackForwardListItemInternal.h"
 #import "WKNSArray.h"
 
-// FIXME: Remove this when nobody depends on it.
-WK_EXTERN NSString * const WKBackForwardListDidChangeNotification;
-NSString * const WKBackForwardListDidChangeNotification = @"_WKBackForwardListDidChangeNotification";
-
-NSString * const _WKBackForwardListDidChangeNotification = @"_WKBackForwardListDidChangeNotification";
-
 using namespace WebKit;
 
 @implementation WKBackForwardList {

Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardListInternal.h (170100 => 170101)


--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardListInternal.h	2014-06-18 15:09:26 UTC (rev 170100)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardListInternal.h	2014-06-18 17:02:18 UTC (rev 170101)
@@ -23,7 +23,7 @@
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#import "WKBackForwardListPrivate.h"
+#import "WKBackForwardList.h"
 
 #if WK_API_ENABLED
 

Deleted: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardListPrivate.h (170100 => 170101)


--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardListPrivate.h	2014-06-18 15:09:26 UTC (rev 170100)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardListPrivate.h	2014-06-18 17:02:18 UTC (rev 170101)
@@ -1,32 +0,0 @@
-/*
- * Copyright (C) 2014 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#import <WebKit/WKBackForwardList.h>
-
-#if WK_API_ENABLED
-
-WK_EXTERN NSString * const _WKBackForwardListDidChangeNotification WK_AVAILABLE(10_0, 8_0);
-
-#endif

Modified: trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.h (170100 => 170101)


--- trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.h	2014-06-18 15:09:26 UTC (rev 170100)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.h	2014-06-18 17:02:18 UTC (rev 170101)
@@ -106,7 +106,6 @@
         virtual bool canAuthenticateAgainstProtectionSpaceInFrame(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, WebKit::WebProtectionSpace*) override;
         virtual void didReceiveAuthenticationChallengeInFrame(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, WebKit::AuthenticationChallengeProxy*) override;
         virtual void processDidCrash(WebKit::WebPageProxy*) override;
-        virtual void didChangeBackForwardList(WebKit::WebPageProxy*, WebKit::WebBackForwardListItem* addedItem, Vector<RefPtr<WebKit::WebBackForwardListItem>> removedItems) override;
         virtual PassRefPtr<API::Data> webCryptoMasterKey(WebKit::WebPageProxy&) override;
 #if USE(QUICK_LOOK)
         virtual void didStartLoadForQuickLookDocumentInMainFrame(const WTF::String& fileName, const WTF::String& uti) override;

Modified: trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm (170100 => 170101)


--- trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm	2014-06-18 15:09:26 UTC (rev 170100)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm	2014-06-18 17:02:18 UTC (rev 170101)
@@ -629,11 +629,6 @@
     [static_cast<id <WKNavigationDelegatePrivate>>(navigationDelegate.get()) _webViewWebProcessDidCrash:m_navigationState.m_webView];
 }
 
-void NavigationState::LoaderClient::didChangeBackForwardList(WebKit::WebPageProxy*, WebKit::WebBackForwardListItem* addedItem, Vector<RefPtr<WebKit::WebBackForwardListItem>> removedItems)
-{
-    [[NSNotificationCenter defaultCenter] postNotificationName:_WKBackForwardListDidChangeNotification object:wrapper(m_navigationState.m_webView->_page->backForwardList())];
-}
-
 PassRefPtr<API::Data> NavigationState::LoaderClient::webCryptoMasterKey(WebKit::WebPageProxy&)
 {
     if (!m_navigationState.m_navigationDelegateMethods.webCryptoMasterKeyForWebView)

Modified: trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (170100 => 170101)


--- trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj	2014-06-18 15:09:26 UTC (rev 170100)
+++ trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj	2014-06-18 17:02:18 UTC (rev 170101)
@@ -265,7 +265,6 @@
 		1A6FBD2911E69BC200DB1371 /* NetscapePlugin.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A6FBD2711E69BC200DB1371 /* NetscapePlugin.cpp */; };
 		1A7865B916CAC71500ACE83A /* PluginProcessConnectionManagerMessageReceiver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A7865B716CAC71500ACE83A /* PluginProcessConnectionManagerMessageReceiver.cpp */; };
 		1A7865BA16CAC71500ACE83A /* PluginProcessConnectionManagerMessages.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A7865B816CAC71500ACE83A /* PluginProcessConnectionManagerMessages.h */; };
-		1A79D9F218EB5EF100914CC5 /* WKBackForwardListPrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A79D9F118EB5EF100914CC5 /* WKBackForwardListPrivate.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		1A7C6CDA1378950800B9C04D /* EnvironmentVariables.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A7C6CD81378950800B9C04D /* EnvironmentVariables.cpp */; };
 		1A7C6CDB1378950800B9C04D /* EnvironmentVariables.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A7C6CD91378950800B9C04D /* EnvironmentVariables.h */; };
 		1A7E377518E4A33A003D0FFF /* WKScriptMessageHandler.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A7E377418E4A33A003D0FFF /* WKScriptMessageHandler.h */; settings = {ATTRIBUTES = (Public, ); }; };
@@ -2204,7 +2203,6 @@
 		1A7865B616CAC6FD00ACE83A /* PluginProcessConnectionManager.messages.in */ = {isa = PBXFileReference; lastKnownFileType = text; path = PluginProcessConnectionManager.messages.in; sourceTree = "<group>"; };
 		1A7865B716CAC71500ACE83A /* PluginProcessConnectionManagerMessageReceiver.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = PluginProcessConnectionManagerMessageReceiver.cpp; sourceTree = "<group>"; };
 		1A7865B816CAC71500ACE83A /* PluginProcessConnectionManagerMessages.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PluginProcessConnectionManagerMessages.h; sourceTree = "<group>"; };
-		1A79D9F118EB5EF100914CC5 /* WKBackForwardListPrivate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKBackForwardListPrivate.h; sourceTree = "<group>"; };
 		1A7C6CD81378950800B9C04D /* EnvironmentVariables.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = EnvironmentVariables.cpp; sourceTree = "<group>"; };
 		1A7C6CD91378950800B9C04D /* EnvironmentVariables.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EnvironmentVariables.h; sourceTree = "<group>"; };
 		1A7E377418E4A33A003D0FFF /* WKScriptMessageHandler.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKScriptMessageHandler.h; sourceTree = "<group>"; };
@@ -4971,7 +4969,6 @@
 				37C4C08518149C5B003688B9 /* WKBackForwardListItem.h */,
 				37C4C08418149C5B003688B9 /* WKBackForwardListItem.mm */,
 				37C4C08818149F23003688B9 /* WKBackForwardListItemInternal.h */,
-				1A79D9F118EB5EF100914CC5 /* WKBackForwardListPrivate.h */,
 				1AF4592D19464B2000F9D4A2 /* WKError.h */,
 				1A2D252A194688FD004537B0 /* WKErrorInternal.h */,
 				1AF4592C19464B2000F9D4A2 /* WKError.mm */,
@@ -7117,7 +7114,6 @@
 				C0CE72AD1247E78D00BC0EC4 /* HandleMessage.h in Headers */,
 				512C06891638F67E00ABB911 /* HostRecord.h in Headers */,
 				37F90DE31376560E0051CF68 /* HTTPCookieAcceptPolicy.h in Headers */,
-				1A79D9F218EB5EF100914CC5 /* WKBackForwardListPrivate.h in Headers */,
 				BCCF6B2512C93E7A008F9C35 /* ImageOptions.h in Headers */,
 				1A1E093418861D3800D2DC49 /* WebProgressTrackerClient.h in Headers */,
 				1AAF08AE1926936700B6390C /* WebUserContentController.h in Headers */,
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to