Title: [170116] trunk/Source/WebKit2
- Revision
- 170116
- Author
- benja...@webkit.org
- Date
- 2014-06-18 14:40:26 -0700 (Wed, 18 Jun 2014)
Log Message
[iOS][WK2] Do not add padding when magnifying replaced elements
https://bugs.webkit.org/show_bug.cgi?id=134019
Reviewed by Tim Horton.
Having margins for regular blocks make sense to improve readability. For replaced elements,
we should follow iOS's UI and display edge to edge.
* UIProcess/ios/SmartMagnificationController.mm:
(WebKit::SmartMagnificationController::didCollectGeometryForSmartMagnificationGesture):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (170115 => 170116)
--- trunk/Source/WebKit2/ChangeLog 2014-06-18 21:38:04 UTC (rev 170115)
+++ trunk/Source/WebKit2/ChangeLog 2014-06-18 21:40:26 UTC (rev 170116)
@@ -1,3 +1,16 @@
+2014-06-18 Benjamin Poulain <benja...@webkit.org>
+
+ [iOS][WK2] Do not add padding when magnifying replaced elements
+ https://bugs.webkit.org/show_bug.cgi?id=134019
+
+ Reviewed by Tim Horton.
+
+ Having margins for regular blocks make sense to improve readability. For replaced elements,
+ we should follow iOS's UI and display edge to edge.
+
+ * UIProcess/ios/SmartMagnificationController.mm:
+ (WebKit::SmartMagnificationController::didCollectGeometryForSmartMagnificationGesture):
+
2014-06-18 Benjamin Poulain <bpoul...@apple.com>
[iOS][WK2] Re-sync didCommitLoadForMainFrame with its corresponding tile update
Modified: trunk/Source/WebKit2/UIProcess/ios/SmartMagnificationController.mm (170115 => 170116)
--- trunk/Source/WebKit2/UIProcess/ios/SmartMagnificationController.mm 2014-06-18 21:38:04 UTC (rev 170115)
+++ trunk/Source/WebKit2/UIProcess/ios/SmartMagnificationController.mm 2014-06-18 21:40:26 UTC (rev 170116)
@@ -87,8 +87,10 @@
return;
}
- targetRect.inflateX(smartMagnificationElementPadding * targetRect.width());
- targetRect.inflateY(smartMagnificationElementPadding * targetRect.height());
+ if (!isReplacedElement) {
+ targetRect.inflateX(smartMagnificationElementPadding * targetRect.width());
+ targetRect.inflateY(smartMagnificationElementPadding * targetRect.height());
+ }
double maximumScale = std::min(viewportMaximumScale, smartMagnificationMaximumScale);
double minimumScale = std::max(viewportMinimumScale, smartMagnificationMinimumScale);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
