Title: [170135] trunk
- Revision
- 170135
- Author
- jp...@apple.com
- Date
- 2014-06-18 17:20:25 -0700 (Wed, 18 Jun 2014)
Log Message
Fix flaky beforeload tests
https://bugs.webkit.org/show_bug.cgi?id=133685
Reviewed by David Kilzer.
Source/WebCore:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURL):
LayoutTests:
* platform/wk2/TestExpectations: Unskip tests that are no longer flaky
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (170134 => 170135)
--- trunk/LayoutTests/ChangeLog 2014-06-19 00:13:20 UTC (rev 170134)
+++ trunk/LayoutTests/ChangeLog 2014-06-19 00:20:25 UTC (rev 170135)
@@ -1,3 +1,12 @@
+2014-06-11 Jeffrey Pfau <jp...@apple.com>
+
+ Fix flaky beforeload tests
+ https://bugs.webkit.org/show_bug.cgi?id=133685
+
+ Reviewed by David Kilzer.
+
+ * platform/wk2/TestExpectations: Unskip tests that are no longer flaky
+
2014-06-18 Benjamin Poulain <benja...@webkit.org>
Subtrees with :first-child and :last-child are not invalidated when siblings are added/removed
Modified: trunk/LayoutTests/platform/wk2/TestExpectations (170134 => 170135)
--- trunk/LayoutTests/platform/wk2/TestExpectations 2014-06-19 00:13:20 UTC (rev 170134)
+++ trunk/LayoutTests/platform/wk2/TestExpectations 2014-06-19 00:20:25 UTC (rev 170135)
@@ -240,10 +240,6 @@
webkit.org/b/132297 svg/custom/bug79798.html [ Skip ]
-webkit.org/b/133685 fast/dom/beforeload/remove-frame-in-beforeload-listener.html [ Skip ]
-webkit.org/b/133685 fast/parser/remove-misnested-iframe-in-beforeload.html [ Skip ]
-webkit.org/b/133685 fast/parser/remove-misnested-iframe-parent-in-beforeload.html [ Skip ]
-
webkit.org/b/133696 fast/frames/iframe-onload-remove-self-no-crash.html [ Skip ]
webkit.org/b/133696 fast/loader/create-frame-in-DOMContentLoaded.html [ Skip ]
webkit.org/b/133696 fast/loader/frame-creation-removal.html [ Skip ]
Modified: trunk/Source/WebCore/ChangeLog (170134 => 170135)
--- trunk/Source/WebCore/ChangeLog 2014-06-19 00:13:20 UTC (rev 170134)
+++ trunk/Source/WebCore/ChangeLog 2014-06-19 00:20:25 UTC (rev 170135)
@@ -1,3 +1,13 @@
+2014-06-11 Jeffrey Pfau <jp...@apple.com>
+
+ Fix flaky beforeload tests
+ https://bugs.webkit.org/show_bug.cgi?id=133685
+
+ Reviewed by David Kilzer.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::loadURL):
+
2014-06-18 Anders Carlsson <ander...@apple.com>
Make FrameLoadType a strongly typed enum
Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (170134 => 170135)
--- trunk/Source/WebCore/loader/FrameLoader.cpp 2014-06-19 00:13:20 UTC (rev 170134)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp 2014-06-19 00:20:25 UTC (rev 170135)
@@ -1252,6 +1252,8 @@
if (m_inStopAllLoaders)
return;
+ Ref<Frame> protect(m_frame);
+
RefPtr<FormState> formState = prpFormState;
bool isFormSubmission = formState;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
