Title: [170375] branches/ftlopt/Source/_javascript_Core
- Revision
- 170375
- Author
- fpi...@apple.com
- Date
- 2014-06-24 12:04:05 -0700 (Tue, 24 Jun 2014)
Log Message
[ftlopt][REGRESSION] PutById AI is introducing watchable structures without watching them
https://bugs.webkit.org/show_bug.cgi?id=134260
Reviewed by Geoffrey Garen.
This was causing loads of assertion failures in debug builds.
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
Modified Paths
Diff
Modified: branches/ftlopt/Source/_javascript_Core/ChangeLog (170374 => 170375)
--- branches/ftlopt/Source/_javascript_Core/ChangeLog 2014-06-24 18:23:10 UTC (rev 170374)
+++ branches/ftlopt/Source/_javascript_Core/ChangeLog 2014-06-24 19:04:05 UTC (rev 170375)
@@ -1,3 +1,15 @@
+2014-06-24 Filip Pizlo <fpi...@apple.com>
+
+ [ftlopt][REGRESSION] PutById AI is introducing watchable structures without watching them
+ https://bugs.webkit.org/show_bug.cgi?id=134260
+
+ Reviewed by Geoffrey Garen.
+
+ This was causing loads of assertion failures in debug builds.
+
+ * dfg/DFGAbstractInterpreterInlines.h:
+ (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
+
2014-06-21 Filip Pizlo <fpi...@apple.com>
[ftlopt] Fold GetById/PutById to MultiGetByOffset/GetByOffset or MultiPutByOffset/PutByOffset, which implies handling non-singleton sets
Modified: branches/ftlopt/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h (170374 => 170375)
--- branches/ftlopt/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h 2014-06-24 18:23:10 UTC (rev 170374)
+++ branches/ftlopt/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h 2014-06-24 19:04:05 UTC (rev 170375)
@@ -1704,6 +1704,7 @@
transitions.append(
Transition(
variant.oldStructureForTransition(), variant.newStructure()));
+ m_graph.watchpoints().consider(variant.newStructure());
newSet.add(variant.newStructure());
} else {
ASSERT(variant.kind() == PutByIdVariant::Replace);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
