Title: [170442] trunk/Source/WebKit2
- Revision
- 170442
- Author
- m...@apple.com
- Date
- 2014-06-25 15:37:37 -0700 (Wed, 25 Jun 2014)
Log Message
<rdar://problem/17448049> REGRESSION (r170254): Input methods don’t work
https://bugs.webkit.org/show_bug.cgi?id=134311
Reviewed by Tim Horton.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getSelectedRangeAsync): Removed code that accidentally put the
callback function into a throwaway EditingRangeCallback.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (170441 => 170442)
--- trunk/Source/WebKit2/ChangeLog 2014-06-25 21:59:54 UTC (rev 170441)
+++ trunk/Source/WebKit2/ChangeLog 2014-06-25 22:37:37 UTC (rev 170442)
@@ -1,3 +1,14 @@
+2014-06-25 Dan Bernstein <m...@apple.com>
+
+ <rdar://problem/17448049> REGRESSION (r170254): Input methods don’t work
+ https://bugs.webkit.org/show_bug.cgi?id=134311
+
+ Reviewed by Tim Horton.
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::getSelectedRangeAsync): Removed code that accidentally put the
+ callback function into a throwaway EditingRangeCallback.
+
2014-06-25 Timothy Horton <timothy_hor...@apple.com>
[iOS][WK2] Rotating a zoomed PDF leads to weird scrolling behavior
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (170441 => 170442)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-06-25 21:59:54 UTC (rev 170441)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-06-25 22:37:37 UTC (rev 170442)
@@ -4972,10 +4972,8 @@
void WebPageProxy::getSelectedRangeAsync(std::function<void (EditingRange, CallbackBase::Error)> callbackFunction)
{
- RefPtr<EditingRangeCallback> callback = EditingRangeCallback::create(std::move(callbackFunction));
-
if (!isValid()) {
- callback->invalidate();
+ callbackFunction(EditingRange(), CallbackBase::Error::Unknown);
return;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
