Title: [170870] trunk/Source/WebKit2
Revision
170870
Author
timothy_hor...@apple.com
Date
2014-07-07 18:56:28 -0700 (Mon, 07 Jul 2014)

Log Message

Don't leak _WKRemoteObjectRegistry in WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=134703

Reviewed by Simon Fraser.

* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController _remoteObjectRegistry]):
Adoption is important!!

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (170869 => 170870)


--- trunk/Source/WebKit2/ChangeLog	2014-07-08 01:52:37 UTC (rev 170869)
+++ trunk/Source/WebKit2/ChangeLog	2014-07-08 01:56:28 UTC (rev 170870)
@@ -1,3 +1,14 @@
+2014-07-07  Timothy Horton  <timothy_hor...@apple.com>
+
+        Don't leak _WKRemoteObjectRegistry in WKBrowsingContextController
+        https://bugs.webkit.org/show_bug.cgi?id=134703
+
+        Reviewed by Simon Fraser.
+
+        * UIProcess/API/Cocoa/WKBrowsingContextController.mm:
+        (-[WKBrowsingContextController _remoteObjectRegistry]):
+        Adoption is important!!
+
 2014-07-07  Simon Fraser  <simon.fra...@apple.com>
 
         [UI-side compositing] Support reflections on custom layers like video

Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm (170869 => 170870)


--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm	2014-07-08 01:52:37 UTC (rev 170869)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm	2014-07-08 01:56:28 UTC (rev 170870)
@@ -859,7 +859,7 @@
 - (_WKRemoteObjectRegistry *)_remoteObjectRegistry
 {
     if (!_remoteObjectRegistry) {
-        _remoteObjectRegistry = [[_WKRemoteObjectRegistry alloc] _initWithMessageSender:*_page];
+        _remoteObjectRegistry = adoptNS([[_WKRemoteObjectRegistry alloc] _initWithMessageSender:*_page]);
         _page->process().context().addMessageReceiver(Messages::RemoteObjectRegistry::messageReceiverName(), _page->pageID(), [_remoteObjectRegistry remoteObjectRegistry]);
     }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to