Title: [172646] trunk/Source/WebKit2
- Revision
- 172646
- Author
- barraclo...@apple.com
- Date
- 2014-08-15 13:37:15 -0700 (Fri, 15 Aug 2014)
Log Message
Fix plugin visibility check.
https://bugs.webkit.org/show_bug.cgi?id=135991
Unreviewed typo fix.
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::PluginControllerProxy):
(WebKit::PluginControllerProxy::visibilityDidChange):
(WebKit::PluginControllerProxy::windowVisibilityChanged):
(WebKit::PluginControllerProxy::updateVisiblityActivity):
* PluginProcess/PluginControllerProxy.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (172645 => 172646)
--- trunk/Source/WebKit2/ChangeLog 2014-08-15 20:32:14 UTC (rev 172645)
+++ trunk/Source/WebKit2/ChangeLog 2014-08-15 20:37:15 UTC (rev 172646)
@@ -3,6 +3,20 @@
Fix plugin visibility check.
https://bugs.webkit.org/show_bug.cgi?id=135991
+ Unreviewed typo fix.
+
+ * PluginProcess/PluginControllerProxy.cpp:
+ (WebKit::PluginControllerProxy::PluginControllerProxy):
+ (WebKit::PluginControllerProxy::visibilityDidChange):
+ (WebKit::PluginControllerProxy::windowVisibilityChanged):
+ (WebKit::PluginControllerProxy::updateVisiblityActivity):
+ * PluginProcess/PluginControllerProxy.h:
+
+2014-08-15 Gavin Barraclough <barraclo...@apple.com>
+
+ Fix plugin visibility check.
+ https://bugs.webkit.org/show_bug.cgi?id=135991
+
Reviewed by Andreas Kling.
We should only take a UserActivity if the plugin is in a visible window,
Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp (172645 => 172646)
--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp 2014-08-15 20:32:14 UTC (rev 172645)
+++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp 2014-08-15 20:37:15 UTC (rev 172646)
@@ -61,8 +61,8 @@
, m_isPrivateBrowsingEnabled(creationParameters.isPrivateBrowsingEnabled)
, m_isAcceleratedCompositingEnabled(creationParameters.isAcceleratedCompositingEnabled)
, m_isInitializing(false)
- , m_isVisibile(false)
- , m_isWindowVisibile(false)
+ , m_isVisible(false)
+ , m_isWindowVisible(false)
, m_paintTimer(RunLoop::main(), this, &PluginControllerProxy::paint)
, m_pluginDestructionProtectCount(0)
, m_pluginDestroyTimer(RunLoop::main(), this, &PluginControllerProxy::destroy)
@@ -432,7 +432,7 @@
void PluginControllerProxy::visibilityDidChange(bool isVisible)
{
- m_isVisibile = isVisible;
+ m_isVisible = isVisible;
ASSERT(m_plugin);
m_plugin->visibilityDidChange(isVisible);
@@ -448,7 +448,7 @@
void PluginControllerProxy::windowVisibilityChanged(bool isVisible)
{
- m_isWindowVisibile = isVisible;
+ m_isWindowVisible = isVisible;
ASSERT(m_plugin);
m_plugin->windowVisibilityChanged(isVisible);
@@ -458,7 +458,7 @@
void PluginControllerProxy::updateVisiblityActivity()
{
- if (m_isVisibile && m_isWindowVisibile)
+ if (m_isVisible && m_isWindowVisible)
m_visiblityActivity.start();
else
m_visiblityActivity.stop();
Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h (172645 => 172646)
--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h 2014-08-15 20:32:14 UTC (rev 172645)
+++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h 2014-08-15 20:37:15 UTC (rev 172646)
@@ -177,8 +177,8 @@
bool m_isPrivateBrowsingEnabled;
bool m_isAcceleratedCompositingEnabled;
bool m_isInitializing;
- bool m_isVisibile;
- bool m_isWindowVisibile;
+ bool m_isVisible;
+ bool m_isWindowVisible;
RefPtr<Messages::WebProcessConnection::CreatePlugin::DelayedReply> m_initializationReply;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
