Title: [173605] trunk/Source/WebCore
- Revision
- 173605
- Author
- cdu...@apple.com
- Date
- 2014-09-13 16:21:28 -0700 (Sat, 13 Sep 2014)
Log Message
Un-inline Element constructor
https://bugs.webkit.org/show_bug.cgi?id=136786
Reviewed by Benjamin Poulain.
Un-inline Element constructor as it is non-trivial and it does not seem
to impact performance based on my testing:
http://dromaeo.com/?id=226865,226869
This reduces the stripped binary size by 8 Kb.
No new tests, no behavior change.
* dom/Element.cpp:
(WebCore::Element::Element):
* dom/Element.h:
(WebCore::Element::Element): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (173604 => 173605)
--- trunk/Source/WebCore/ChangeLog 2014-09-13 18:59:50 UTC (rev 173604)
+++ trunk/Source/WebCore/ChangeLog 2014-09-13 23:21:28 UTC (rev 173605)
@@ -1,3 +1,23 @@
+2014-09-13 Chris Dumez <cdu...@apple.com>
+
+ Un-inline Element constructor
+ https://bugs.webkit.org/show_bug.cgi?id=136786
+
+ Reviewed by Benjamin Poulain.
+
+ Un-inline Element constructor as it is non-trivial and it does not seem
+ to impact performance based on my testing:
+ http://dromaeo.com/?id=226865,226869
+
+ This reduces the stripped binary size by 8 Kb.
+
+ No new tests, no behavior change.
+
+ * dom/Element.cpp:
+ (WebCore::Element::Element):
+ * dom/Element.h:
+ (WebCore::Element::Element): Deleted.
+
2014-09-12 Jon Honeycutt <jhoneyc...@apple.com>
Build fix with REQUEST_AUTOCOMPLETE enabled
Modified: trunk/Source/WebCore/dom/Element.cpp (173604 => 173605)
--- trunk/Source/WebCore/dom/Element.cpp 2014-09-13 18:59:50 UTC (rev 173604)
+++ trunk/Source/WebCore/dom/Element.cpp 2014-09-13 23:21:28 UTC (rev 173605)
@@ -142,6 +142,12 @@
return adoptRef(new Element(tagName, document, CreateElement));
}
+Element::Element(const QualifiedName& tagName, Document& document, ConstructionType type)
+ : ContainerNode(document, type)
+ , m_tagName(tagName)
+{
+}
+
Element::~Element()
{
#ifndef NDEBUG
Modified: trunk/Source/WebCore/dom/Element.h (173604 => 173605)
--- trunk/Source/WebCore/dom/Element.h 2014-09-13 18:59:50 UTC (rev 173604)
+++ trunk/Source/WebCore/dom/Element.h 2014-09-13 23:21:28 UTC (rev 173605)
@@ -560,11 +560,7 @@
WEBCORE_EXPORT URL absoluteLinkURL() const;
protected:
- Element(const QualifiedName& tagName, Document& document, ConstructionType type)
- : ContainerNode(document, type)
- , m_tagName(tagName)
- {
- }
+ Element(const QualifiedName&, Document&, ConstructionType);
virtual InsertionNotificationRequest insertedInto(ContainerNode&) override;
virtual void removedFrom(ContainerNode&) override;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
