Title: [174285] trunk/Tools
Revision
174285
Author
roger_f...@apple.com
Date
2014-10-03 13:29:29 -0700 (Fri, 03 Oct 2014)

Log Message

[Windows] Include batch size argument to layout tests on Windows.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunWebKitTests.start): 
This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
These crashes seem to happen on random tests though generally in a spread out fashion.
It seems possible that the DRT instance is being clobbered somehow after running too many
tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (174284 => 174285)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2014-10-03 20:28:04 UTC (rev 174284)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2014-10-03 20:29:29 UTC (rev 174285)
@@ -373,7 +373,7 @@
             self.setCommand(self.command + ['--no-build'])
         if platform == "win":
             rootArgument = ['--root=' + os.path.join("WebKitBuild", self.getProperty('configuration'), "bin32")]
-            self.setCommand(self.command + ['--no-build'])
+            self.setCommand(self.command + ['--no-build', '--batch-size', '100'])
         else:
             rootArgument = ['--root=WebKitBuild/bin']
         if not self.buildJSCTool:

Modified: trunk/Tools/ChangeLog (174284 => 174285)


--- trunk/Tools/ChangeLog	2014-10-03 20:28:04 UTC (rev 174284)
+++ trunk/Tools/ChangeLog	2014-10-03 20:29:29 UTC (rev 174285)
@@ -1,5 +1,16 @@
 2014-10-03  Roger Fong  <roger_f...@apple.com>
 
+        [Windows] Include batch size argument to layout tests on Windows.
+
+        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
+        (RunWebKitTests.start): 
+        This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
+        These crashes seem to happen on random tests though generally in a spread out fashion.
+        It seems possible that the DRT instance is being clobbered somehow after running too many
+        tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
+
+2014-10-03  Roger Fong  <roger_f...@apple.com>
+
         [Windows] Settle for 2 chid processes running NRWT on Windows.
 
         * Scripts/webkitpy/port/win.py:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to