Title: [177436] trunk/Source/WebCore
- Revision
- 177436
- Author
- cdu...@apple.com
- Date
- 2014-12-17 00:03:44 -0800 (Wed, 17 Dec 2014)
Log Message
Drop useless 'clipToContents' argument for windowClipRect()
https://bugs.webkit.org/show_bug.cgi?id=139722
Reviewed by Darin Adler.
Drop useless 'clipToContents' argument for windowClipRect(). This
argument is never used.
No new tests, no behavior change.
* page/FrameView.cpp:
(WebCore::FrameView::windowClipRect):
* page/FrameView.h:
* platform/ScrollView.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (177435 => 177436)
--- trunk/Source/WebCore/ChangeLog 2014-12-17 05:20:09 UTC (rev 177435)
+++ trunk/Source/WebCore/ChangeLog 2014-12-17 08:03:44 UTC (rev 177436)
@@ -1,3 +1,20 @@
+2014-12-17 Chris Dumez <cdu...@apple.com>
+
+ Drop useless 'clipToContents' argument for windowClipRect()
+ https://bugs.webkit.org/show_bug.cgi?id=139722
+
+ Reviewed by Darin Adler.
+
+ Drop useless 'clipToContents' argument for windowClipRect(). This
+ argument is never used.
+
+ No new tests, no behavior change.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::windowClipRect):
+ * page/FrameView.h:
+ * platform/ScrollView.h:
+
2014-12-16 Shivakumar JM <shiva...@samsung.com>
text node should not be created, On setting document.title to the empty string.
Modified: trunk/Source/WebCore/page/FrameView.cpp (177435 => 177436)
--- trunk/Source/WebCore/page/FrameView.cpp 2014-12-17 05:20:09 UTC (rev 177435)
+++ trunk/Source/WebCore/page/FrameView.cpp 2014-12-17 08:03:44 UTC (rev 177436)
@@ -3208,7 +3208,7 @@
frame().document()->styleResolverChanged(DeferRecalcStyle);
}
-IntRect FrameView::windowClipRect(bool clipToContents) const
+IntRect FrameView::windowClipRect() const
{
ASSERT(frame().view() == this);
@@ -3216,11 +3216,8 @@
return contentsToWindow(IntRect(IntPoint(), totalContentsSize()));
// Set our clip rect to be our contents.
- IntRect clipRect;
- if (clipToContents)
- clipRect = contentsToWindow(visibleContentRect(LegacyIOSDocumentVisibleRect));
- else
- clipRect = contentsToWindow(visibleContentRectIncludingScrollbars(LegacyIOSDocumentVisibleRect));
+ IntRect clipRect = contentsToWindow(visibleContentRect(LegacyIOSDocumentVisibleRect));
+
if (!frame().ownerElement())
return clipRect;
Modified: trunk/Source/WebCore/page/FrameView.h (177435 => 177436)
--- trunk/Source/WebCore/page/FrameView.h 2014-12-17 05:20:09 UTC (rev 177435)
+++ trunk/Source/WebCore/page/FrameView.h 2014-12-17 08:03:44 UTC (rev 177436)
@@ -224,7 +224,7 @@
WEBCORE_EXPORT void setViewportSizeForCSSViewportUnits(IntSize);
IntSize viewportSizeForCSSViewportUnits() const;
- virtual IntRect windowClipRect(bool clipToContents = true) const override;
+ virtual IntRect windowClipRect() const override;
WEBCORE_EXPORT IntRect windowClipRectForFrameOwner(const HTMLFrameOwnerElement*, bool clipToLayerContents) const;
virtual IntRect windowResizerRect() const override;
Modified: trunk/Source/WebCore/platform/ScrollView.h (177435 => 177436)
--- trunk/Source/WebCore/platform/ScrollView.h 2014-12-17 05:20:09 UTC (rev 177435)
+++ trunk/Source/WebCore/platform/ScrollView.h 2014-12-17 08:03:44 UTC (rev 177436)
@@ -85,7 +85,7 @@
virtual HostWindow* hostWindow() const = 0;
// Returns a clip rect in host window coordinates. Used to clip the blit on a scroll.
- virtual IntRect windowClipRect(bool clipToContents = true) const = 0;
+ virtual IntRect windowClipRect() const = 0;
// Functions for child manipulation and inspection.
const HashSet<RefPtr<Widget>>& children() const { return m_children; }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
