Title: [180121] trunk/Source/WebCore
- Revision
- 180121
- Author
- commit-qu...@webkit.org
- Date
- 2015-02-14 21:14:31 -0800 (Sat, 14 Feb 2015)
Log Message
[Mac] RetainPtr member cleanup, possible leaks
https://bugs.webkit.org/show_bug.cgi?id=141616
Patch by Joseph Pecoraro <pecor...@apple.com> on 2015-02-14
Reviewed by Andreas Kling.
* platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:]):
Adopt the allocated object to avoid a possible leak.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
Adopt to avoid unnecessary retain/autorelease.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (180120 => 180121)
--- trunk/Source/WebCore/ChangeLog 2015-02-15 05:08:48 UTC (rev 180120)
+++ trunk/Source/WebCore/ChangeLog 2015-02-15 05:14:31 UTC (rev 180121)
@@ -1,5 +1,20 @@
2015-02-14 Joseph Pecoraro <pecor...@apple.com>
+ [Mac] RetainPtr member cleanup, possible leaks
+ https://bugs.webkit.org/show_bug.cgi?id=141616
+
+ Reviewed by Andreas Kling.
+
+ * platform/mac/PlatformSpeechSynthesizerMac.mm:
+ (-[WebSpeechSynthesisWrapper speakUtterance:]):
+ Adopt the allocated object to avoid a possible leak.
+
+ * platform/mac/ScrollAnimatorMac.mm:
+ (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
+ Adopt to avoid unnecessary retain/autorelease.
+
+2015-02-14 Joseph Pecoraro <pecor...@apple.com>
+
IncompleteMetaDataCue leak seen on leaks bot
https://bugs.webkit.org/show_bug.cgi?id=141611
Modified: trunk/Source/WebCore/platform/mac/PlatformSpeechSynthesizerMac.mm (180120 => 180121)
--- trunk/Source/WebCore/platform/mac/PlatformSpeechSynthesizerMac.mm 2015-02-15 05:08:48 UTC (rev 180120)
+++ trunk/Source/WebCore/platform/mac/PlatformSpeechSynthesizerMac.mm 2015-02-15 05:14:31 UTC (rev 180121)
@@ -90,7 +90,7 @@
ASSERT(utterance);
if (!m_synthesizer) {
- m_synthesizer = [[NSSpeechSynthesizer alloc] initWithVoice:nil];
+ m_synthesizer = adoptNS([[NSSpeechSynthesizer alloc] initWithVoice:nil]);
[m_synthesizer setDelegate:self];
}
Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (180120 => 180121)
--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2015-02-15 05:08:48 UTC (rev 180120)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2015-02-15 05:14:31 UTC (rev 180121)
@@ -654,7 +654,7 @@
m_scrollAnimationHelper = adoptNS([[NSClassFromString(@"NSScrollAnimationHelper") alloc] initWithDelegate:m_scrollAnimationHelperDelegate.get()]);
m_scrollbarPainterControllerDelegate = adoptNS([[WebScrollbarPainterControllerDelegate alloc] initWithScrollableArea:scrollableArea]);
- m_scrollbarPainterController = [[[NSClassFromString(@"NSScrollerImpPair") alloc] init] autorelease];
+ m_scrollbarPainterController = adoptNS([[NSClassFromString(@"NSScrollerImpPair") alloc] init]);
[m_scrollbarPainterController setDelegate:(id)m_scrollbarPainterControllerDelegate.get()];
[m_scrollbarPainterController setScrollerStyle:recommendedScrollerStyle()];
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
