Diff
Modified: trunk/LayoutTests/ChangeLog (183681 => 183682)
--- trunk/LayoutTests/ChangeLog 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/LayoutTests/ChangeLog 2015-05-01 18:19:58 UTC (rev 183682)
@@ -1,3 +1,15 @@
+2015-05-01 Brady Eidson <beid...@apple.com>
+
+ Add API to disable meta refreshes.
+ <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
+
+ Reviewed by Alexey Proskuryakov.
+
+ * loader/meta-refresh-disabled-expected.txt: Added.
+ * loader/meta-refresh-disabled.html: Added.
+ * loader/resources/notify-done.html: Added.
+ * platform/win/TestExpectations:
+
2015-05-01 Martin Robinson <mrobin...@igalia.com>
Unreviewed gardening for WebKitGTK+
Added: trunk/LayoutTests/loader/meta-refresh-disabled-expected.txt (0 => 183682)
--- trunk/LayoutTests/loader/meta-refresh-disabled-expected.txt (rev 0)
+++ trunk/LayoutTests/loader/meta-refresh-disabled-expected.txt 2015-05-01 18:19:58 UTC (rev 183682)
@@ -0,0 +1,4 @@
+This test makes sure the preference to disable meta refreshes works as expected.
+You should see this text when the test is done.
+If you do not see this text, and instead you see a blank page, then the redirect happened, which it should not have.
+
Added: trunk/LayoutTests/loader/meta-refresh-disabled.html (0 => 183682)
--- trunk/LayoutTests/loader/meta-refresh-disabled.html (rev 0)
+++ trunk/LayoutTests/loader/meta-refresh-disabled.html 2015-05-01 18:19:58 UTC (rev 183682)
@@ -0,0 +1,39 @@
+<head>
+<script>
+if (window.testRunner) {
+ testRunner.overridePreference("WebKitMetaRefreshEnabled", "0");
+ testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+}
+
+// This bizarre practice of continuously delaying notifyDone() by multiple 0-delay timers
+// is meant to work around a few 0-delays in the meta refresh process.
+// The refresh itself is on a timer, and then the policy delegate's reply might be on a timer.
+// The goal here is to give a successfully scheduled meta refresh long enough to occur,
+// but to not also wait an arbitrary amount of clock time before concluding the test.
+function notifyDoneDelayer(iteration)
+{
+ if (iteration == 10) {
+ if (window.testRunner)
+ testRunner.notifyDone();
+ else
+ document.body.innerHTML = "This test can only be run under DRT/WKTR";
+ return;
+ }
+
+ setTimeout("notifyDoneDelayer(" + ++iteration + ");", 0);
+}
+
+function loaded()
+{
+ setTimeout("notifyDoneDelayer(1);", 0);
+}
+
+</script>
+<meta http-equiv="refresh" content="0;url=""
+</head>
+<body _onload_="loaded();">
+This test makes sure the preference to disable meta refreshes works as expected.<br>
+You should see this text when the test is done.<br>
+If you do not see this text, and instead you see a blank page, then the redirect happened, which it should not have.<br>
+</body>
Added: trunk/LayoutTests/loader/resources/notify-done.html (0 => 183682)
--- trunk/LayoutTests/loader/resources/notify-done.html (rev 0)
+++ trunk/LayoutTests/loader/resources/notify-done.html 2015-05-01 18:19:58 UTC (rev 183682)
@@ -0,0 +1,4 @@
+<script>
+if (window.testRunner)
+ testRunner.notifyDone();
+</script>
Modified: trunk/LayoutTests/platform/win/TestExpectations (183681 => 183682)
--- trunk/LayoutTests/platform/win/TestExpectations 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/LayoutTests/platform/win/TestExpectations 2015-05-01 18:19:58 UTC (rev 183682)
@@ -3083,6 +3083,9 @@
[ Release ] inspector-protocol/layers/layers-for-node.html [ Skip ] # Timeouts
[ Release ] inspector-protocol/layers/layers-generated-content.html [ Skip ] # Timeouts
+# Windows doesn't have API for disabling meta refresh
+loader/meta-refresh-disabled.html [ Skip ]
+
# Started failing recently.
webkit.org/b/143275 accessibility/aria-hidden-hides-all-elements.html [ Pass Failure ]
Modified: trunk/Source/WebCore/ChangeLog (183681 => 183682)
--- trunk/Source/WebCore/ChangeLog 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebCore/ChangeLog 2015-05-01 18:19:58 UTC (rev 183682)
@@ -1,3 +1,16 @@
+2015-05-01 Brady Eidson <beid...@apple.com>
+
+ Add API to disable meta refreshes.
+ <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
+
+ Reviewed by Alexey Proskuryakov.
+
+ Test: loader/meta-refresh-disabled.html
+
+ * dom/Document.cpp:
+ (WebCore::Document::processHttpEquiv): Bail early if Settings have meta refreshes disabled.
+ * page/Settings.in:
+
2015-05-01 Martin Robinson <mrobin...@igalia.com>
[Freetype] Properly support synthetic oblique in vertical text
Modified: trunk/Source/WebCore/dom/Document.cpp (183681 => 183682)
--- trunk/Source/WebCore/dom/Document.cpp 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebCore/dom/Document.cpp 2015-05-01 18:19:58 UTC (rev 183682)
@@ -3002,6 +3002,9 @@
break;
case HTTPHeaderName::Refresh: {
+ if (page() && !page()->settings().metaRefreshEnabled())
+ break;
+
double delay;
String urlString;
if (frame && parseHTTPRefresh(content, true, delay, urlString)) {
Modified: trunk/Source/WebCore/page/Settings.in (183681 => 183682)
--- trunk/Source/WebCore/page/Settings.in 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebCore/page/Settings.in 2015-05-01 18:19:58 UTC (rev 183682)
@@ -241,3 +241,4 @@
newBlockInsideInlineModelEnabled initial=false, setNeedsStyleRecalcInAllFrames=1
+metaRefreshEnabled initial=true
Modified: trunk/Source/WebKit/mac/ChangeLog (183681 => 183682)
--- trunk/Source/WebKit/mac/ChangeLog 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebKit/mac/ChangeLog 2015-05-01 18:19:58 UTC (rev 183682)
@@ -1,3 +1,21 @@
+2015-05-01 Brady Eidson <beid...@apple.com>
+
+ Add API to disable meta refreshes.
+ <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
+
+ Reviewed by Alexey Proskuryakov.
+
+ Add a preference to enable/disable meta refreshes, enabled by default.
+
+ * WebView/WebPreferenceKeysPrivate.h:
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]):
+ (-[WebPreferences setMetaRefreshEnabled:]):
+ (-[WebPreferences metaRefreshEnabled]):
+ * WebView/WebPreferencesPrivate.h:
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
2015-04-30 Jon Davis <j...@apple.com>
Web Inspector: console should show an icon for console.info() messages
Modified: trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h (183681 => 183682)
--- trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2015-05-01 18:19:58 UTC (rev 183682)
@@ -172,6 +172,7 @@
#define WebKitDebugFullPageZoomPreferenceKey @"WebKitDebugFullPageZoomPreferenceKey"
#define WebKitMinimumZoomFontSizePreferenceKey @"WebKitMinimumZoomFontSizePreferenceKey"
#define WebKitAntialiasedFontDilationEnabledKey @"AntialiasedFontDilationEnabled"
+#define WebKitMetaRefreshEnabledPreferenceKey @"WebKitMetaRefreshEnabled"
#if TARGET_OS_IPHONE
#define WebKitStandalonePreferenceKey @"WebKitStandalonePreferenceKey"
Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (183681 => 183682)
--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2015-05-01 18:19:58 UTC (rev 183682)
@@ -444,6 +444,7 @@
#endif
[NSNumber numberWithBool:YES], WebKitPluginsEnabledPreferenceKey,
[NSNumber numberWithBool:YES], WebKitDatabasesEnabledPreferenceKey,
+ [NSNumber numberWithBool:YES], WebKitMetaRefreshEnabledPreferenceKey,
#if PLATFORM(IOS)
[NSNumber numberWithBool:NO], WebKitStorageTrackerEnabledPreferenceKey,
#endif
@@ -2496,6 +2497,16 @@
return [self _boolValueForKey:WebKitAntialiasedFontDilationEnabledKey];
}
+- (void)setMetaRefreshEnabled:(BOOL)enabled
+{
+ [self _setBoolValue:enabled forKey:WebKitMetaRefreshEnabledPreferenceKey];
+}
+
+- (BOOL)metaRefreshEnabled
+{
+ return [self _boolValueForKey:WebKitMetaRefreshEnabledPreferenceKey];
+}
+
- (BOOL)_javascript_MarkupEnabled
{
return [self _boolValueForKey:WebKitJavaScriptMarkupEnabledPreferenceKey];
Modified: trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h (183681 => 183682)
--- trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2015-05-01 18:19:58 UTC (rev 183682)
@@ -439,6 +439,9 @@
- (void)setAntialiasedFontDilationEnabled:(BOOL)flag;
- (BOOL)antialiasedFontDilationEnabled;
+- (void)setMetaRefreshEnabled:(BOOL)flag;
+- (BOOL)metaRefreshEnabled;
+
@property (nonatomic) BOOL _javascript_MarkupEnabled;
#if TARGET_OS_IPHONE && __IPHONE_OS_VERSION_MIN_REQUIRED < 80000
Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (183681 => 183682)
--- trunk/Source/WebKit/mac/WebView/WebView.mm 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2015-05-01 18:19:58 UTC (rev 183682)
@@ -2330,6 +2330,7 @@
}
settings.setPlugInSnapshottingEnabled([preferences plugInSnapshottingEnabled]);
+ settings.setMetaRefreshEnabled([preferences metaRefreshEnabled]);
settings.setFixedPositionCreatesStackingContext(true);
#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
Modified: trunk/Source/WebKit2/ChangeLog (183681 => 183682)
--- trunk/Source/WebKit2/ChangeLog 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebKit2/ChangeLog 2015-05-01 18:19:58 UTC (rev 183682)
@@ -1,3 +1,23 @@
+2015-05-01 Brady Eidson <beid...@apple.com>
+
+ Add API to disable meta refreshes.
+ <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
+
+ Reviewed by Alexey Proskuryakov.
+
+ Add a preference to enable/disable meta refreshes, enabled by default.
+
+ * Shared/WebPreferencesDefinitions.h:
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesSetMetaRefreshEnabled):
+ (WKPreferencesGetMetaRefreshEnabled):
+ (WKPreferencesGetIgnoreViewportScalingConstraints): Deleted.
+ * UIProcess/API/C/WKPreferencesRefPrivate.h:
+ * WebProcess/InjectedBundle/InjectedBundle.cpp:
+ (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences):
+
2015-05-01 Antti Koivisto <an...@apple.com>
Remove network process load serialization code
Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (183681 => 183682)
--- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2015-05-01 18:19:58 UTC (rev 183682)
@@ -196,6 +196,7 @@
macro(LongMousePressEnabled, longMousePressEnabled, Bool, bool, false) \
macro(NewBlockInsideInlineModelEnabled, newBlockInsideInlineModelEnabled, Bool, bool, false) \
macro(AntialiasedFontDilationEnabled, antialiasedFontDilationEnabled, Bool, bool, true) \
+ macro(MetaRefreshEnabled, metaRefreshEnabled, Bool, bool, true) \
#define FOR_EACH_WEBKIT_DOUBLE_PREFERENCE(macro) \
macro(IncrementalRenderingSuppressionTimeout, incrementalRenderingSuppressionTimeout, Double, double, 5) \
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (183681 => 183682)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2015-05-01 18:19:58 UTC (rev 183682)
@@ -1356,3 +1356,13 @@
{
return toImpl(preferencesRef)->ignoreViewportScalingConstraints();
}
+
+void WKPreferencesSetMetaRefreshEnabled(WKPreferencesRef preferencesRef, bool enabled)
+{
+ toImpl(preferencesRef)->setMetaRefreshEnabled(enabled);
+}
+
+bool WKPreferencesGetMetaRefreshEnabled(WKPreferencesRef preferencesRef)
+{
+ return toImpl(preferencesRef)->metaRefreshEnabled();
+}
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h (183681 => 183682)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2015-05-01 18:19:58 UTC (rev 183682)
@@ -369,6 +369,10 @@
WK_EXPORT void WKPreferencesSetJavaScriptRuntimeFlags(WKPreferencesRef preferences, WKJavaScriptRuntimeFlagSet _javascript_RuntimeFlagSet);
WK_EXPORT WKJavaScriptRuntimeFlagSet WKPreferencesGetJavaScriptRuntimeFlags(WKPreferencesRef preferences);
+// Defaults to true.
+WK_EXPORT void WKPreferencesSetMetaRefreshEnabled(WKPreferencesRef preferences, bool enabled);
+WK_EXPORT bool WKPreferencesGetMetaRefreshEnabled(WKPreferencesRef preferences);
+
#ifdef __cplusplus
}
#endif
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (183681 => 183682)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2015-05-01 18:19:58 UTC (rev 183682)
@@ -206,7 +206,8 @@
macro(WebKitShouldRespectImageOrientation, ShouldRespectImageOrientation, shouldRespectImageOrientation) \
macro(WebKitEnableCaretBrowsing, CaretBrowsingEnabled, caretBrowsingEnabled) \
macro(WebKitDisplayImagesKey, LoadsImagesAutomatically, loadsImagesAutomatically) \
- macro(WebKitMediaStreamEnabled, MediaStreamEnabled, mediaStreamEnabled)
+ macro(WebKitMediaStreamEnabled, MediaStreamEnabled, mediaStreamEnabled) \
+ macro(WebKitMetaRefreshEnabled, MetaRefreshEnabled, metaRefreshEnabled)
#define OVERRIDE_PREFERENCE_AND_SET_IN_EXISTING_PAGES(TestRunnerName, SettingsName, WebPreferencesName) \
if (preference == #TestRunnerName) { \
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (183681 => 183682)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2015-05-01 18:19:58 UTC (rev 183682)
@@ -2757,6 +2757,8 @@
settings.setInteractiveFormValidationEnabled(store.getBoolValueForKey(WebPreferencesKey::interactiveFormValidationEnabledKey()));
settings.setSpatialNavigationEnabled(store.getBoolValueForKey(WebPreferencesKey::spatialNavigationEnabledKey()));
+ settings.setMetaRefreshEnabled(store.getBoolValueForKey(WebPreferencesKey::metaRefreshEnabledKey()));
+
DatabaseManager::singleton().setIsAvailable(store.getBoolValueForKey(WebPreferencesKey::databasesEnabledKey()));
#if ENABLE(FULLSCREEN_API)
Modified: trunk/Tools/ChangeLog (183681 => 183682)
--- trunk/Tools/ChangeLog 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Tools/ChangeLog 2015-05-01 18:19:58 UTC (rev 183682)
@@ -1,3 +1,13 @@
+2015-05-01 Brady Eidson <beid...@apple.com>
+
+ Add API to disable meta refreshes.
+ <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
+
+ Reviewed by Alexey Proskuryakov.
+
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
+
2015-05-01 Brent Fulgham <bfulg...@apple.com>
Provide a runtime flag to run-webkit-tests that shows the test view
Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (183681 => 183682)
--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2015-05-01 17:55:48 UTC (rev 183681)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2015-05-01 18:19:58 UTC (rev 183682)
@@ -928,6 +928,8 @@
[preferences setLoadsSiteIconsIgnoringImageLoadingPreference:NO];
[preferences setFrameFlatteningEnabled:NO];
[preferences setSpatialNavigationEnabled:NO];
+ [preferences setMetaRefreshEnabled:YES];
+
if (persistentUserStyleSheetLocation) {
[preferences setUserStyleSheetLocation:[NSURL URLWithString:(NSString *)(persistentUserStyleSheetLocation.get())]];
[preferences setUserStyleSheetEnabled:YES];
