Title: [184360] trunk/Source/WebCore
Revision
184360
Author
d...@apple.com
Date
2015-05-14 16:35:42 -0700 (Thu, 14 May 2015)

Log Message

MediaControls: controls are live even when invisible
https://bugs.webkit.org/show_bug.cgi?id=145029
<rdar://problem/20865442>

Reviewed by Jer Noble.

When the controls are invisible they should ignore touch/mouse
events.

* Modules/mediacontrols/mediaControlsiOS.css: Add pointer-events: none where appropriate.
(video::-webkit-media-controls-panel-container):
(video::-webkit-media-controls-panel-background):
(video::-webkit-media-controls-panel):
(video::-webkit-media-controls-panel.paused):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (184359 => 184360)


--- trunk/Source/WebCore/ChangeLog	2015-05-14 23:27:35 UTC (rev 184359)
+++ trunk/Source/WebCore/ChangeLog	2015-05-14 23:35:42 UTC (rev 184360)
@@ -1,3 +1,20 @@
+2015-05-14  Dean Jackson  <d...@apple.com>
+
+        MediaControls: controls are live even when invisible
+        https://bugs.webkit.org/show_bug.cgi?id=145029
+        <rdar://problem/20865442>
+
+        Reviewed by Jer Noble.
+
+        When the controls are invisible they should ignore touch/mouse
+        events.
+
+        * Modules/mediacontrols/mediaControlsiOS.css: Add pointer-events: none where appropriate.
+        (video::-webkit-media-controls-panel-container):
+        (video::-webkit-media-controls-panel-background):
+        (video::-webkit-media-controls-panel):
+        (video::-webkit-media-controls-panel.paused):
+
 2015-05-14  Jer Noble  <jer.no...@apple.com>
 
         [MediaControls] Refactor media controls & bring improvements made to iOS controls to Mac.

Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css (184359 => 184360)


--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css	2015-05-14 23:27:35 UTC (rev 184359)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css	2015-05-14 23:35:42 UTC (rev 184360)
@@ -100,6 +100,7 @@
     height: 50px;
     position: absolute;
     bottom: 0;
+    pointer-events: none;
 }
 
 audio::-webkit-media-controls-panel-container {
@@ -118,6 +119,7 @@
     -webkit-appearance: media-controls-light-bar-background;
     transition: opacity 0.25s linear;
     opacity: 0;
+    pointer-events: none;
 }
 
 audio::-webkit-media-controls-panel-background {
@@ -157,6 +159,7 @@
 video::-webkit-media-controls-panel {
     height: 50px;
     opacity: 0;
+    pointer-events: none;
     -webkit-transform: translate3d(0, 0, 0);
 }
 
@@ -167,6 +170,7 @@
 
 video::-webkit-media-controls-panel.show,
 video::-webkit-media-controls-panel.paused {
+    pointer-events: auto;
     opacity: 1;
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to