[webkit-changes] [184804] trunk/Tools

Fri, 22 May 2015 17:12:07 -0700

Title: [184804] trunk/Tools
Revision
184804
Author
dburk...@apple.com
Date
2015-05-22 17:11:30 -0700 (Fri, 22 May 2015)

Log Message

Add support to the botwatchers dashboard for a static analyzer bot.
https://bugs.webkit.org/show_bug.cgi?id=144814

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
scan-build should be considered a productive step.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue):
Adds support for the staticAnalyzer property

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
(BuildbotTestResults.prototype._parseResults):
Get bug count from the scan-build step output

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
(documentReady):
Rename the performance column 'Other', and merge the current 'Other' column with it.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
Now that performance bots are part of the 'Other' column, give them better headings.

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (184803 => 184804)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js	2015-05-22 23:57:59 UTC (rev 184803)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js	2015-05-23 00:11:30 UTC (rev 184804)
@@ -75,7 +75,8 @@
     "webkitpy-test": 1,
     "webkitperl-test": 1,
     "bindings-generation-tests": 1,
-    "perf-test": 1
+    "perf-test": 1,
+    "scan build": 1,
 };
 
 BuildbotIteration.TestSteps = {

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js (184803 => 184804)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js	2015-05-22 23:57:59 UTC (rev 184803)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js	2015-05-23 00:11:30 UTC (rev 184804)
@@ -39,6 +39,7 @@
     this.builder = info.builder || false;
     this.tester = info.tester || false;
     this.performance = info.performance || false;
+    this.staticAnalyzer = info.staticAnalyzer || false;
     this.leaks = info.leaks || false;
     this.architecture = info.architecture || null;
     this.testCategory = info.testCategory || null;

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js (184803 => 184804)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js	2015-05-22 23:57:59 UTC (rev 184803)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js	2015-05-23 00:11:30 UTC (rev 184804)
@@ -93,6 +93,7 @@
         this.newPassesCount = testStep.results[1].reduce(resultSummarizer.bind(null, "new pass"), undefined);
         this.missingCount = testStep.results[1].reduce(resultSummarizer.bind(null, "missing"), undefined);
         this.crashCount = testStep.results[1].reduce(resultSummarizer.bind(null, "crash"), undefined);
+        this.issueCount = testStep.results[1].reduce(resultSummarizer.bind(null, "issue"), undefined);
 
         if (!this.failureCount && !this.flakyCount && !this.totalLeakCount && !this.uniqueLeakCount && !this.newPassesCount && !this.missingCount) {
             // This step exited with a non-zero exit status, but we didn't find any output about the number of failed tests.
@@ -146,7 +147,7 @@
 
                         // FIXME (bug 127186): It is particularly unfortunate for image diffs, because we currently only check image results
                         // on retry (except for reftests), so many times, you will see images on buildbot page, but not on the dashboard.
-                        // FIXME: Find a way to display expected mismatch reftest failures. 
+                        // FIXME: Find a way to display expected mismatch reftest failures.
                         if (value.actual.split(" ")[0].contains("IMAGE") && value.reftest_type != "!=")
                             item.has_image_diff = true;

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js (184803 => 184804)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js	2015-05-22 23:57:59 UTC (rev 184803)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js	2015-05-23 00:11:30 UTC (rev 184804)
@@ -47,6 +47,8 @@
             categoryName = "performance";
         else if (queue.leaks)
             categoryName = "leaks";
+        else if (queue.staticAnalyzer)
+            categoryName = "staticAnalyzer";
         else {
             console.assert("Unknown queue type.");
             continue;
@@ -147,16 +149,9 @@
     }
 
     var header = document.createElement("th");
-    header.textContent = "Performance";
+    header.textContent = "Other";
     row.appendChild(header);
 
-    if (hasBubbles) {
-        // Currently, EWS and commit queues are the only items in Other category.
-        var header = document.createElement("th");
-        header.textContent = "Other";
-        row.appendChild(header);
-    }
-
     table.appendChild(row);
 
     var platforms = sortedPlatforms();
@@ -215,6 +210,11 @@
             cell.appendChild(view.element);
         }
 
+        if (platformQueues.staticAnalyzer) {
+            var view = new BuildbotStaticAnalyzerQueueView(platformQueues.staticAnalyzer.release);
+            cell.appendChild(view.element);
+        }
+
         if (platformQueues.leaks) {
             var view = new BuildbotLeaksQueueView(platformQueues.leaks);
             cell.appendChild(view.element);
@@ -223,8 +223,6 @@
         row.appendChild(cell);
 
         if (hasBubbles) {
-            var cell = document.createElement("td");
-
             if (platformQueues[BubblesCategory]) {
                 var view = new BubbleQueueView(platformQueues[BubblesCategory]);
                 cell.appendChild(view.element);

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js (184803 => 184804)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js	2015-05-22 23:57:59 UTC (rev 184803)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js	2015-05-23 00:11:30 UTC (rev 184804)
@@ -32,7 +32,7 @@
         "Apple Mavericks Debug WK2 (Tests)": {platform: Dashboard.Platform.MacOSXMavericks, debug: true, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
         "Apple Mavericks Release WK1 (Tests)": {platform: Dashboard.Platform.MacOSXMavericks, debug: false, tester: true, testCategory: Buildbot.TestCategory.WebKit1},
         "Apple Mavericks Release WK2 (Tests)": {platform: Dashboard.Platform.MacOSXMavericks, debug: false, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
-        "Apple Mavericks Release WK2 (Perf)": {platform: Dashboard.Platform.MacOSXMavericks, debug: false, performance: true},
+        "Apple Mavericks Release WK2 (Perf)": {platform: Dashboard.Platform.MacOSXMavericks, debug: false, performance: true, heading: "Performance"},
         "Apple Yosemite Debug (Build)": {platform: Dashboard.Platform.MacOSXYosemite, debug: true, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit},
         "Apple Yosemite Release (Build)": {platform: Dashboard.Platform.MacOSXYosemite, debug: false, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit},
         "Apple Yosemite Release (32-bit Build)": {platform: Dashboard.Platform.MacOSXYosemite, builder: true, architecture: Buildbot.BuildArchitecture.ThirtyTwoBit},
@@ -40,7 +40,7 @@
         "Apple Yosemite Debug WK2 (Tests)": {platform: Dashboard.Platform.MacOSXYosemite, debug: true, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
         "Apple Yosemite Release WK1 (Tests)": {platform: Dashboard.Platform.MacOSXYosemite, debug: false, tester: true, testCategory: Buildbot.TestCategory.WebKit1},
         "Apple Yosemite Release WK2 (Tests)": {platform: Dashboard.Platform.MacOSXYosemite, debug: false, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
-        "Apple Yosemite Release WK2 (Perf)": {platform: Dashboard.Platform.MacOSXYosemite, debug: false, performance: true},
+        "Apple Yosemite Release WK2 (Perf)": {platform: Dashboard.Platform.MacOSXYosemite, debug: false, performance: true, heading: "Performance"},
         "Apple Yosemite (Leaks)": {platform: Dashboard.Platform.MacOSXYosemite, debug: true, leaks: true},
         "Apple Win Debug (Build)": {platform: Dashboard.Platform.Windows7, debug: true, builder: true, architecture: Buildbot.BuildArchitecture.ThirtyTwoBit},
         "Apple Win Release (Build)": {platform: Dashboard.Platform.Windows7, builder: true, architecture: Buildbot.BuildArchitecture.ThirtyTwoBit},
@@ -50,9 +50,9 @@
         "GTK Linux 64-bit Release (Tests)": {platform: Dashboard.Platform.LinuxGTK, debug: false, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
         "GTK Linux 64-bit Debug (Build)": {platform: Dashboard.Platform.LinuxGTK, debug: true, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit},
         "GTK Linux 64-bit Debug (Tests)": {platform: Dashboard.Platform.LinuxGTK, debug: true, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
-        "GTK Linux 64-bit Release (Perf)": {platform: Dashboard.Platform.LinuxGTK, debug: false, performance: true},
+        "GTK Linux 64-bit Release (Perf)": {platform: Dashboard.Platform.LinuxGTK, debug: false, performance: true, heading: "Performance"},
         "EFL Linux 64-bit Release WK2": {platform: Dashboard.Platform.LinuxEFL, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
-        "EFL Linux 64-bit Release WK2 (Perf)": {platform: Dashboard.Platform.LinuxEFL, performance: true}
+        "EFL Linux 64-bit Release WK2 (Perf)": {platform: Dashboard.Platform.LinuxEFL, performance: true, heading: "Performance"}
     };
 
     Buildbot.call(this, "https://build.webkit.org/", queueInfo);

Modified: trunk/Tools/ChangeLog (184803 => 184804)


--- trunk/Tools/ChangeLog	2015-05-22 23:57:59 UTC (rev 184803)
+++ trunk/Tools/ChangeLog	2015-05-23 00:11:30 UTC (rev 184804)
@@ -1,3 +1,29 @@
+2015-05-22  Dana Burkart  <dburk...@apple.com>
+
+        Add support to the botwatchers dashboard for a static analyzer bot.
+        https://bugs.webkit.org/show_bug.cgi?id=144814
+
+        Reviewed by Alexey Proskuryakov.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+        scan-build should be considered a productive step.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
+        (BuildbotQueue):
+        Adds support for the staticAnalyzer property
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
+        (BuildbotTestResults.prototype._parseResults):
+        Get bug count from the scan-build step output
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
+        (documentReady):
+        Rename the performance column 'Other', and merge the current 'Other' column with it.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
+        (WebKitBuildbot):
+        Now that performance bots are part of the 'Other' column, give them better headings.
+
 2015-05-22  Tim Horton  <timothy_hor...@apple.com>
 
         Turn on autosaving of toolbar configuration in MiniBrowser

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to