Title: [186369] trunk/Source/WebCore
- Revision
- 186369
- Author
- beid...@apple.com
- Date
- 2015-07-06 12:45:26 -0700 (Mon, 06 Jul 2015)
Log Message
Remove unused "m_isPrivate" flag on NetworkStorageSession.
https://bugs.webkit.org/show_bug.cgi?id=146648
Reviewed by Alex Christensen.
No new tests (No behavior change).
* platform/network/NetworkStorageSession.h:
(WebCore::NetworkStorageSession::isPrivateBrowsingSession): Deleted.
* platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::NetworkStorageSession): Deleted.
(WebCore::NetworkStorageSession::createPrivateBrowsingSession): Deleted.
* platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::NetworkStorageSession::NetworkStorageSession): Deleted.
(WebCore::NetworkStorageSession::createPrivateBrowsingSession): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (186368 => 186369)
--- trunk/Source/WebCore/ChangeLog 2015-07-06 19:44:23 UTC (rev 186368)
+++ trunk/Source/WebCore/ChangeLog 2015-07-06 19:45:26 UTC (rev 186369)
@@ -1,3 +1,23 @@
+2015-07-06 Brady Eidson <beid...@apple.com>
+
+ Remove unused "m_isPrivate" flag on NetworkStorageSession.
+ https://bugs.webkit.org/show_bug.cgi?id=146648
+
+ Reviewed by Alex Christensen.
+
+ No new tests (No behavior change).
+
+ * platform/network/NetworkStorageSession.h:
+ (WebCore::NetworkStorageSession::isPrivateBrowsingSession): Deleted.
+
+ * platform/network/cf/NetworkStorageSessionCFNet.cpp:
+ (WebCore::NetworkStorageSession::NetworkStorageSession): Deleted.
+ (WebCore::NetworkStorageSession::createPrivateBrowsingSession): Deleted.
+
+ * platform/network/soup/NetworkStorageSessionSoup.cpp:
+ (WebCore::NetworkStorageSession::NetworkStorageSession): Deleted.
+ (WebCore::NetworkStorageSession::createPrivateBrowsingSession): Deleted.
+
2015-07-04 Timothy Hatcher <timo...@apple.com>
Web Inspector: Add a dedicated Network tab that is always live
Modified: trunk/Source/WebCore/platform/network/NetworkStorageSession.h (186368 => 186369)
--- trunk/Source/WebCore/platform/network/NetworkStorageSession.h 2015-07-06 19:44:23 UTC (rev 186368)
+++ trunk/Source/WebCore/platform/network/NetworkStorageSession.h 2015-07-06 19:45:26 UTC (rev 186369)
@@ -47,10 +47,6 @@
WEBCORE_EXPORT static void switchToNewTestingSession();
-#if PLATFORM(COCOA) || USE(CFNETWORK) || USE(SOUP)
- bool isPrivateBrowsingSession() const { return m_isPrivate; }
-#endif
-
#if PLATFORM(COCOA) || USE(CFNETWORK)
NetworkStorageSession(RetainPtr<CFURLStorageSessionRef>);
// May be null, in which case a Foundation default should be used.
@@ -76,10 +72,6 @@
#else
RefPtr<NetworkingContext> m_context;
#endif
-
-#if PLATFORM(COCOA) || USE(CFNETWORK) || USE(SOUP)
- bool m_isPrivate;
-#endif
};
}
Modified: trunk/Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp (186368 => 186369)
--- trunk/Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp 2015-07-06 19:44:23 UTC (rev 186368)
+++ trunk/Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp 2015-07-06 19:45:26 UTC (rev 186369)
@@ -40,7 +40,6 @@
NetworkStorageSession::NetworkStorageSession(RetainPtr<CFURLStorageSessionRef> platformSession)
: m_platformSession(platformSession)
- , m_isPrivate(false)
{
}
@@ -78,7 +77,6 @@
#else
auto session = std::make_unique<NetworkStorageSession>(adoptCF(wkCreatePrivateStorageSession(cfIdentifier.get(), defaultNetworkStorageSession()->platformSession())));
#endif
- session->m_isPrivate = true;
return session;
}
Modified: trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp (186368 => 186369)
--- trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp 2015-07-06 19:44:23 UTC (rev 186368)
+++ trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp 2015-07-06 19:45:26 UTC (rev 186369)
@@ -38,7 +38,6 @@
NetworkStorageSession::NetworkStorageSession(std::unique_ptr<SoupNetworkSession> session)
: m_session(WTF::move(session))
- , m_isPrivate(false)
{
}
@@ -63,7 +62,6 @@
std::unique_ptr<NetworkStorageSession> NetworkStorageSession::createPrivateBrowsingSession(const String&)
{
auto session = std::make_unique<NetworkStorageSession>(SoupNetworkSession::createPrivateBrowsingSession());
- session->m_isPrivate = true;
return session;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
