Title: [186524] trunk/Source/WebInspectorUI
- Revision
- 186524
- Author
- drou...@apple.com
- Date
- 2015-07-08 13:40:24 -0700 (Wed, 08 Jul 2015)
Log Message
Web Inspector: Clicking style checkbox selects the property name while mouse down
https://bugs.webkit.org/show_bug.cgi?id=146728
Reviewed by Timothy Hatcher.
* UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._handleMouseDown):
Now returns if the click was not at the end of the line.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (186523 => 186524)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-07-08 20:36:09 UTC (rev 186523)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-07-08 20:40:24 UTC (rev 186524)
@@ -1,3 +1,14 @@
+2015-07-08 Devin Rousso <drou...@apple.com>
+
+ Web Inspector: Clicking style checkbox selects the property name while mouse down
+ https://bugs.webkit.org/show_bug.cgi?id=146728
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
+ (WebInspector.CSSStyleDeclarationTextEditor.prototype._handleMouseDown):
+ Now returns if the click was not at the end of the line.
+
2015-07-08 Timothy Hatcher <timo...@apple.com>
REGRESSION (r185629): Web Inspector: Filtering doesn't display any items if folders are used to organize the web page resources
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js (186523 => 186524)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js 2015-07-08 20:36:09 UTC (rev 186523)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js 2015-07-08 20:40:24 UTC (rev 186524)
@@ -446,14 +446,9 @@
var line = this._codeMirror.getLine(cursor.line);
var trimmedLine = line.trimRight();
- if (!trimmedLine.trimLeft().length)
+ if (!trimmedLine.trimLeft().length || cursor.ch !== trimmedLine.length)
return;
- if (cursor.ch !== trimmedLine.length) {
- this._highlightNextNameOrValue(this._codeMirror, cursor, line);
- return;
- }
-
this._mouseDownCursorPosition = cursor;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
