Title: [186826] trunk
Revision
186826
Author
ander...@apple.com
Date
2015-07-14 16:50:39 -0700 (Tue, 14 Jul 2015)

Log Message

Assertions.h should include ExportMacros.h
https://bugs.webkit.org/show_bug.cgi?id=146948

Reviewed by Tim Horton.

Source/_javascript_Core:

Remove now unneeded WTF_EXPORT_PRIVATE define.

* API/JSBase.h:

Source/WTF:

* wtf/Assertions.h:

Tools:

Remove now unneeded WTF_EXPORT_PRIVATE define.

* DumpRenderTree/cg/ImageDiffCG.cpp:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/API/JSBase.h (186825 => 186826)


--- trunk/Source/_javascript_Core/API/JSBase.h	2015-07-14 23:50:16 UTC (rev 186825)
+++ trunk/Source/_javascript_Core/API/JSBase.h	2015-07-14 23:50:39 UTC (rev 186826)
@@ -84,11 +84,6 @@
 #define JS_EXPORT
 #endif /* defined(JS_NO_EXPORT) */
 
-/* JS tests uses WTF but has no config.h, so we need to set the export defines here. */
-#ifndef WTF_EXPORT_PRIVATE
-#define WTF_EXPORT_PRIVATE JS_EXPORT
-#endif
-
 #ifdef __cplusplus
 extern "C" {
 #endif

Modified: trunk/Source/_javascript_Core/ChangeLog (186825 => 186826)


--- trunk/Source/_javascript_Core/ChangeLog	2015-07-14 23:50:16 UTC (rev 186825)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-07-14 23:50:39 UTC (rev 186826)
@@ -1,3 +1,14 @@
+2015-07-14  Anders Carlsson  <ander...@apple.com>
+
+        Assertions.h should include ExportMacros.h
+        https://bugs.webkit.org/show_bug.cgi?id=146948
+
+        Reviewed by Tim Horton.
+
+        Remove now unneeded WTF_EXPORT_PRIVATE define.
+
+        * API/JSBase.h:
+
 2015-07-14  Matthew Mirman  <mmir...@apple.com>
 
         Repatch. Makes compileArithSub in the DFG ensure that the constant is an int32.

Modified: trunk/Source/WTF/ChangeLog (186825 => 186826)


--- trunk/Source/WTF/ChangeLog	2015-07-14 23:50:16 UTC (rev 186825)
+++ trunk/Source/WTF/ChangeLog	2015-07-14 23:50:39 UTC (rev 186826)
@@ -1,3 +1,12 @@
+2015-07-14  Anders Carlsson  <ander...@apple.com>
+
+        Assertions.h should include ExportMacros.h
+        https://bugs.webkit.org/show_bug.cgi?id=146948
+
+        Reviewed by Tim Horton.
+
+        * wtf/Assertions.h:
+
 2015-07-11  Joseph Pecoraro  <pecor...@apple.com>
 
         Unreviewed build fix, restrict APP_LINKS to just iOS.

Modified: trunk/Source/WTF/wtf/Assertions.h (186825 => 186826)


--- trunk/Source/WTF/wtf/Assertions.h	2015-07-14 23:50:16 UTC (rev 186825)
+++ trunk/Source/WTF/wtf/Assertions.h	2015-07-14 23:50:39 UTC (rev 186826)
@@ -42,6 +42,7 @@
 #include <stdarg.h>
 #include <stdbool.h>
 #include <stddef.h>
+#include <wtf/ExportMacros.h>
 
 #ifdef NDEBUG
 /* Disable ASSERT* macros in release mode. */

Modified: trunk/Tools/ChangeLog (186825 => 186826)


--- trunk/Tools/ChangeLog	2015-07-14 23:50:16 UTC (rev 186825)
+++ trunk/Tools/ChangeLog	2015-07-14 23:50:39 UTC (rev 186826)
@@ -1,3 +1,14 @@
+2015-07-14  Anders Carlsson  <ander...@apple.com>
+
+        Assertions.h should include ExportMacros.h
+        https://bugs.webkit.org/show_bug.cgi?id=146948
+
+        Reviewed by Tim Horton.
+
+        Remove now unneeded WTF_EXPORT_PRIVATE define.
+
+        * DumpRenderTree/cg/ImageDiffCG.cpp:
+
 2015-07-14  Carlos Alberto Lopez Perez  <clo...@igalia.com>
 
         [GTK] [Wayland] Build by default the X11 and Wayland targets.

Modified: trunk/Tools/DumpRenderTree/cg/ImageDiffCG.cpp (186825 => 186826)


--- trunk/Tools/DumpRenderTree/cg/ImageDiffCG.cpp	2015-07-14 23:50:16 UTC (rev 186825)
+++ trunk/Tools/DumpRenderTree/cg/ImageDiffCG.cpp	2015-07-14 23:50:39 UTC (rev 186826)
@@ -26,7 +26,6 @@
 
 // FIXME: We need to be able to include these defines from a config.h somewhere.
 #define JS_EXPORT_PRIVATE
-#define WTF_EXPORT_PRIVATE
 
 #include <stdio.h>
 #include <wtf/Platform.h>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to