Title: [187693] trunk/Source/WebCore
Revision
187693
Author
mmaxfi...@apple.com
Date
2015-07-31 17:00:44 -0700 (Fri, 31 Jul 2015)

Log Message

[Cocoa] Latin quotes are used with the system font on Chinese devices
https://bugs.webkit.org/show_bug.cgi?id=147504

Reviewed by Dean Jackson.

The system font has some fancy logic regarding character selection which requires
using Core Text for glyph selection.

No new tests because tests can't change the system language of the device.

* platform/graphics/mac/GlyphPageMac.cpp:
(WebCore::shouldUseCoreText):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (187692 => 187693)


--- trunk/Source/WebCore/ChangeLog	2015-07-31 23:57:22 UTC (rev 187692)
+++ trunk/Source/WebCore/ChangeLog	2015-08-01 00:00:44 UTC (rev 187693)
@@ -1,3 +1,18 @@
+2015-07-31  Myles C. Maxfield  <mmaxfi...@apple.com>
+
+        [Cocoa] Latin quotes are used with the system font on Chinese devices
+        https://bugs.webkit.org/show_bug.cgi?id=147504
+
+        Reviewed by Dean Jackson.
+
+        The system font has some fancy logic regarding character selection which requires
+        using Core Text for glyph selection.
+
+        No new tests because tests can't change the system language of the device.
+
+        * platform/graphics/mac/GlyphPageMac.cpp:
+        (WebCore::shouldUseCoreText):
+
 2015-07-31  Chris Dumez  <cdu...@apple.com>
 
         Coalesce authentication credential requests

Modified: trunk/Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp (187692 => 187693)


--- trunk/Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp	2015-07-31 23:57:22 UTC (rev 187692)
+++ trunk/Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp	2015-08-01 00:00:44 UTC (rev 187693)
@@ -42,7 +42,7 @@
 
 static bool shouldUseCoreText(const UChar* buffer, unsigned bufferLength, const Font* fontData)
 {
-    if (fontData->platformData().isCompositeFontReference())
+    if (fontData->platformData().isCompositeFontReference() || fontData->isSystemFont())
         return true;
     if (fontData->platformData().widthVariant() != RegularWidth || fontData->hasVerticalGlyphs()) {
         // Ideographs don't have a vertical variant or width variants.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to