Title: [189660] trunk
Revision
189660
Author
cdu...@apple.com
Date
2015-09-12 14:52:25 -0700 (Sat, 12 Sep 2015)

Log Message

window.EventTarget should exist
https://bugs.webkit.org/show_bug.cgi?id=149085
<rdar://problem/22546774>

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline several W3C tests now that more checks are passing.

* web-platform-tests/dom/interface-objects-expected.txt:
* web-platform-tests/dom/interfaces-expected.txt:
* web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

Drop [NoInterfaceObject] for the EventTarget interface to match Chrome,
Firefox and the specification:
https://dom.spec.whatwg.org/#interface-eventtarget

No new tests, already covered by existing tests.

* dom/EventTarget.idl:

LayoutTests:

Update / rebaseline existing test as window.EventTarget now exists.

* fast/dom/dom-constructors-expected.txt:
* fast/dom/dom-constructors.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (189659 => 189660)


--- trunk/LayoutTests/ChangeLog	2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/ChangeLog	2015-09-12 21:52:25 UTC (rev 189660)
@@ -1,5 +1,18 @@
 2015-09-12  Chris Dumez  <cdu...@apple.com>
 
+        window.EventTarget should exist
+        https://bugs.webkit.org/show_bug.cgi?id=149085
+        <rdar://problem/22546774>
+
+        Reviewed by Sam Weinig.
+
+        Update / rebaseline existing test as window.EventTarget now exists.
+
+        * fast/dom/dom-constructors-expected.txt:
+        * fast/dom/dom-constructors.html:
+
+2015-09-12  Chris Dumez  <cdu...@apple.com>
+
         ChildNode.replaceWith() without argument should replace the node with an empty DocumentFragment
         https://bugs.webkit.org/show_bug.cgi?id=149073
         <rdar://problem/22547801>

Modified: trunk/LayoutTests/fast/dom/dom-constructors-expected.txt (189659 => 189660)


--- trunk/LayoutTests/fast/dom/dom-constructors-expected.txt	2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/fast/dom/dom-constructors-expected.txt	2015-09-12 21:52:25 UTC (rev 189660)
@@ -10,6 +10,7 @@
 PASS TryAllocate('Element') is 'exception'
 PASS TryAllocate('Entity') is 'exception'
 PASS TryAllocate('EntityReference') is 'exception'
+PASS TryAllocate('EventTarget') is 'exception'
 PASS TryAllocate('HTMLDocument') is 'exception'
 PASS TryAllocate('Node') is 'exception'
 PASS TryAllocate('ProcessingInstruction') is 'exception'
@@ -120,7 +121,6 @@
 PASS TryAllocate('EventTargetNode') is 'no constructor'
 PASS TryAllocate('UndetectableHTMLCollection') is 'no constructor'
 PASS TryAllocate('XPathNSResolver') is 'no constructor'
-PASS TryAllocate('EventTarget') is 'no constructor'
 PASS TryAllocate('EventListener') is 'no constructor'
 PASS TryAllocate('NPObject') is 'no constructor'
 PASS TryAllocate('Comment') is '[object Comment]'

Modified: trunk/LayoutTests/fast/dom/dom-constructors.html (189659 => 189660)


--- trunk/LayoutTests/fast/dom/dom-constructors.html	2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/fast/dom/dom-constructors.html	2015-09-12 21:52:25 UTC (rev 189660)
@@ -20,6 +20,7 @@
     'Element',
     'Entity',
     'EntityReference',
+    'EventTarget',
     'HTMLDocument',
     'Node',
     'ProcessingInstruction',
@@ -146,7 +147,7 @@
 // These objects should have no constructor.
 var objects_no_constructor = [
     'EventTargetNode', 'UndetectableHTMLCollection',
-    'XPathNSResolver', 'EventTarget', 'EventListener', 'NPObject'
+    'XPathNSResolver', 'EventListener', 'NPObject'
 ];
 
 // These objects should have a working constructor, but their constructed

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (189659 => 189660)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2015-09-12 21:52:25 UTC (rev 189660)
@@ -1,5 +1,19 @@
 2015-09-12  Chris Dumez  <cdu...@apple.com>
 
+        window.EventTarget should exist
+        https://bugs.webkit.org/show_bug.cgi?id=149085
+        <rdar://problem/22546774>
+
+        Reviewed by Sam Weinig.
+
+        Rebaseline several W3C tests now that more checks are passing.
+
+        * web-platform-tests/dom/interface-objects-expected.txt:
+        * web-platform-tests/dom/interfaces-expected.txt:
+        * web-platform-tests/html/dom/interfaces-expected.txt:
+
+2015-09-12  Chris Dumez  <cdu...@apple.com>
+
         ChildNode.replaceWith() without argument should replace the node with an empty DocumentFragment
         https://bugs.webkit.org/show_bug.cgi?id=149073
         <rdar://problem/22547801>

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interface-objects-expected.txt (189659 => 189660)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interface-objects-expected.txt	2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interface-objects-expected.txt	2015-09-12 21:52:25 UTC (rev 189660)
@@ -2,7 +2,7 @@
 PASS Interface objects properties should not be Enumerable 
 PASS Should be able to delete Event. 
 PASS Should be able to delete CustomEvent. 
-FAIL Should be able to delete EventTarget. assert_true: Interface should exist. expected true got false
+PASS Should be able to delete EventTarget. 
 PASS Should be able to delete Node. 
 PASS Should be able to delete Document. 
 PASS Should be able to delete DOMImplementation. 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt (189659 => 189660)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt	2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt	2015-09-12 21:52:25 UTC (rev 189660)
@@ -226,13 +226,15 @@
 FAIL Event interface: calling initEvent(DOMString,boolean,boolean) on new CustomEvent("foo") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
     [native code]
 }" did not throw
-FAIL EventTarget interface: existence and properties of interface object assert_own_property: self does not have own property "EventTarget" expected property "EventTarget" missing
-FAIL EventTarget interface object length assert_own_property: self does not have own property "EventTarget" expected property "EventTarget" missing
-FAIL EventTarget interface: existence and properties of interface prototype object assert_own_property: self does not have own property "EventTarget" expected property "EventTarget" missing
-FAIL EventTarget interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "EventTarget" expected property "EventTarget" missing
-FAIL EventTarget interface: operation addEventListener(DOMString,EventListener,boolean) assert_own_property: self does not have own property "EventTarget" expected property "EventTarget" missing
-FAIL EventTarget interface: operation removeEventListener(DOMString,EventListener,boolean) assert_own_property: self does not have own property "EventTarget" expected property "EventTarget" missing
-FAIL EventTarget interface: operation dispatchEvent(Event) assert_own_property: self does not have own property "EventTarget" expected property "EventTarget" missing
+FAIL EventTarget interface: existence and properties of interface object assert_equals: prototype of self's property "EventTarget" is not Function.prototype expected (function) function "function () {
+    [native code]
+}" but got (object) object "[object Object]"
+PASS EventTarget interface object length 
+PASS EventTarget interface: existence and properties of interface prototype object 
+FAIL EventTarget interface: existence and properties of interface prototype object's "constructor" property assert_true: EventTarget.prototype.constructor is not writable expected true got false
+PASS EventTarget interface: operation addEventListener(DOMString,EventListener,boolean) 
+PASS EventTarget interface: operation removeEventListener(DOMString,EventListener,boolean) 
+PASS EventTarget interface: operation dispatchEvent(Event) 
 FAIL NodeList interface: existence and properties of interface object assert_equals: prototype of self's property "NodeList" is not Function.prototype expected (function) function "function () {
     [native code]
 }" but got (object) object "[object Object]"
@@ -312,7 +314,7 @@
     [native code]
 }" but got (object) object "[object Object]"
 PASS Node interface object length 
-FAIL Node interface: existence and properties of interface prototype object assert_own_property: should inherit from EventTarget, but self has no such property expected property "EventTarget" missing
+FAIL Node interface: existence and properties of interface prototype object assert_equals: prototype of Node.prototype is not EventTarget.prototype expected object "[object EventTargetPrototype]" but got object "[object Object]"
 FAIL Node interface: existence and properties of interface prototype object's "constructor" property assert_true: Node.prototype.constructor is not writable expected true got false
 PASS Node interface: constant ELEMENT_NODE on interface object 
 PASS Node interface: constant ELEMENT_NODE on interface prototype object 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (189659 => 189660)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt	2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt	2015-09-12 21:52:25 UTC (rev 189660)
@@ -3528,7 +3528,7 @@
     [native code]
 }" but got (object) object "[object Object]"
 PASS MediaController interface object length 
-FAIL MediaController interface: existence and properties of interface prototype object assert_own_property: should inherit from EventTarget, but self has no such property expected property "EventTarget" missing
+FAIL MediaController interface: existence and properties of interface prototype object assert_equals: prototype of MediaController.prototype is not EventTarget.prototype expected object "[object EventTargetPrototype]" but got object "[object Object]"
 FAIL MediaController interface: existence and properties of interface prototype object's "constructor" property assert_true: MediaController.prototype.constructor is not writable expected true got false
 FAIL MediaController interface: attribute readyState assert_true: The prototype object must have a property "readyState" expected true got false
 FAIL MediaController interface: attribute buffered assert_throws: getting property on prototype object must throw TypeError function "function () {
@@ -3626,7 +3626,7 @@
     [native code]
 }" but got (object) object "[object Object]"
 PASS TextTrackList interface object length 
-FAIL TextTrackList interface: existence and properties of interface prototype object assert_own_property: should inherit from EventTarget, but self has no such property expected property "EventTarget" missing
+FAIL TextTrackList interface: existence and properties of interface prototype object assert_equals: prototype of TextTrackList.prototype is not EventTarget.prototype expected object "[object EventTargetPrototype]" but got object "[object Object]"
 FAIL TextTrackList interface: existence and properties of interface prototype object's "constructor" property assert_own_property: TextTrackList.prototype does not have own property "constructor" expected property "constructor" missing
 FAIL TextTrackList interface: attribute length assert_true: The prototype object must have a property "length" expected true got false
 PASS TextTrackList interface: operation getTrackById(DOMString) 
@@ -3655,7 +3655,7 @@
     [native code]
 }" but got (object) object "[object Object]"
 PASS TextTrack interface object length 
-FAIL TextTrack interface: existence and properties of interface prototype object assert_own_property: should inherit from EventTarget, but self has no such property expected property "EventTarget" missing
+FAIL TextTrack interface: existence and properties of interface prototype object assert_equals: prototype of TextTrack.prototype is not EventTarget.prototype expected object "[object EventTargetPrototype]" but got object "[object Object]"
 FAIL TextTrack interface: existence and properties of interface prototype object's "constructor" property assert_true: TextTrack.prototype.constructor is not writable expected true got false
 FAIL TextTrack interface: attribute kind assert_true: The prototype object must have a property "kind" expected true got false
 FAIL TextTrack interface: attribute label assert_throws: getting property on prototype object must throw TypeError function "function () {
@@ -3724,7 +3724,7 @@
     [native code]
 }" but got (object) object "[object Object]"
 FAIL TextTrackCue interface object length assert_equals: wrong value for TextTrackCue.length expected 0 but got 3
-FAIL TextTrackCue interface: existence and properties of interface prototype object assert_own_property: should inherit from EventTarget, but self has no such property expected property "EventTarget" missing
+FAIL TextTrackCue interface: existence and properties of interface prototype object assert_equals: prototype of TextTrackCue.prototype is not EventTarget.prototype expected object "[object EventTargetPrototype]" but got object "[object Object]"
 FAIL TextTrackCue interface: existence and properties of interface prototype object's "constructor" property assert_true: TextTrackCue.prototype.constructor is not writable expected true got false
 FAIL TextTrackCue interface: attribute track assert_throws: getting property on prototype object must throw TypeError function "function () {
     [native code]
@@ -5654,7 +5654,7 @@
     [native code]
 }" but got (object) object "[object Object]"
 PASS Window interface object length 
-FAIL Window interface: existence and properties of interface prototype object assert_own_property: should inherit from EventTarget, but self has no such property expected property "EventTarget" missing
+FAIL Window interface: existence and properties of interface prototype object assert_equals: prototype of Window.prototype is not EventTarget.prototype expected object "[object EventTargetPrototype]" but got object "[object Object]"
 FAIL Window interface: existence and properties of interface prototype object's "constructor" property assert_own_property: Window.prototype does not have own property "constructor" expected property "constructor" missing
 FAIL Window interface: attribute self assert_true: The prototype object must have a property "self" expected true got false
 FAIL Window interface: attribute name assert_true: The prototype object must have a property "name" expected true got false
@@ -6256,7 +6256,7 @@
     [native code]
 }" but got (object) object "[object Object]"
 PASS EventSource interface object length 
-FAIL EventSource interface: existence and properties of interface prototype object assert_own_property: should inherit from EventTarget, but self has no such property expected property "EventTarget" missing
+FAIL EventSource interface: existence and properties of interface prototype object assert_equals: prototype of EventSource.prototype is not EventTarget.prototype expected object "[object EventTargetPrototype]" but got object "[object Object]"
 FAIL EventSource interface: existence and properties of interface prototype object's "constructor" property assert_true: EventSource.prototype.constructor is not writable expected true got false
 FAIL EventSource interface: attribute url assert_throws: getting property on prototype object must throw TypeError function "function () {
     [native code]
@@ -6287,7 +6287,7 @@
     [native code]
 }" but got (object) object "[object Object]"
 PASS WebSocket interface object length 
-FAIL WebSocket interface: existence and properties of interface prototype object assert_own_property: should inherit from EventTarget, but self has no such property expected property "EventTarget" missing
+FAIL WebSocket interface: existence and properties of interface prototype object assert_equals: prototype of WebSocket.prototype is not EventTarget.prototype expected object "[object EventTargetPrototype]" but got object "[object Object]"
 FAIL WebSocket interface: existence and properties of interface prototype object's "constructor" property assert_true: WebSocket.prototype.constructor is not writable expected true got false
 FAIL WebSocket interface: attribute url assert_throws: getting property on prototype object must throw TypeError function "function () {
     [native code]
@@ -6363,7 +6363,7 @@
     [native code]
 }" but got (object) object "[object Object]"
 PASS MessagePort interface object length 
-FAIL MessagePort interface: existence and properties of interface prototype object assert_own_property: should inherit from EventTarget, but self has no such property expected property "EventTarget" missing
+FAIL MessagePort interface: existence and properties of interface prototype object assert_equals: prototype of MessagePort.prototype is not EventTarget.prototype expected object "[object EventTargetPrototype]" but got object "[object Object]"
 FAIL MessagePort interface: existence and properties of interface prototype object's "constructor" property assert_true: MessagePort.prototype.constructor is not writable expected true got false
 PASS MessagePort interface: operation postMessage(any,[object Object]) 
 PASS MessagePort interface: operation start() 
@@ -6426,7 +6426,7 @@
     [native code]
 }" but got (object) object "[object Object]"
 PASS Worker interface object length 
-FAIL Worker interface: existence and properties of interface prototype object assert_own_property: should inherit from EventTarget, but self has no such property expected property "EventTarget" missing
+PASS Worker interface: existence and properties of interface prototype object 
 FAIL Worker interface: existence and properties of interface prototype object's "constructor" property assert_true: Worker.prototype.constructor is not writable expected true got false
 PASS Worker interface: operation terminate() 
 PASS Worker interface: operation postMessage(any,[object Object]) 

Modified: trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt (189659 => 189660)


--- trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt	2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt	2015-09-12 21:52:25 UTC (rev 189660)
@@ -343,6 +343,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'EventSource').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'EventSource').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'EventSource').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').value is EventTarget
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'File').value is File
 PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('set') is false

Modified: trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt (189659 => 189660)


--- trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt	2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt	2015-09-12 21:52:25 UTC (rev 189660)
@@ -348,6 +348,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'EventSource').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'EventSource').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'EventSource').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').value is EventTarget
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'File').value is File
 PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('set') is false

Modified: trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt (189659 => 189660)


--- trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt	2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt	2015-09-12 21:52:25 UTC (rev 189660)
@@ -338,6 +338,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'EventSource').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'EventSource').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'EventSource').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').value is EventTarget
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'File').value is File
 PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('set') is false

Modified: trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt (189659 => 189660)


--- trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt	2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt	2015-09-12 21:52:25 UTC (rev 189660)
@@ -338,6 +338,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'EventSource').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'EventSource').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'EventSource').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').value is EventTarget
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'File').value is File
 PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('set') is false

Modified: trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt (189659 => 189660)


--- trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt	2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt	2015-09-12 21:52:25 UTC (rev 189660)
@@ -338,6 +338,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'EventSource').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'EventSource').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'EventSource').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').value is EventTarget
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'File').value is File
 PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('set') is false

Modified: trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt (189659 => 189660)


--- trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt	2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt	2015-09-12 21:52:25 UTC (rev 189660)
@@ -268,6 +268,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'EventSource').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'EventSource').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'EventSource').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').value is EventTarget
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'File').value is File
 PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('set') is false

Modified: trunk/Source/WebCore/ChangeLog (189659 => 189660)


--- trunk/Source/WebCore/ChangeLog	2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/Source/WebCore/ChangeLog	2015-09-12 21:52:25 UTC (rev 189660)
@@ -1,3 +1,19 @@
+2015-09-12  Chris Dumez  <cdu...@apple.com>
+
+        window.EventTarget should exist
+        https://bugs.webkit.org/show_bug.cgi?id=149085
+        <rdar://problem/22546774>
+
+        Reviewed by Sam Weinig.
+
+        Drop [NoInterfaceObject] for the EventTarget interface to match Chrome,
+        Firefox and the specification:
+        https://dom.spec.whatwg.org/#interface-eventtarget
+
+        No new tests, already covered by existing tests.
+
+        * dom/EventTarget.idl:
+
 2015-09-12  Brian Burg  <bb...@apple.com>
 
         Web Inspector: disambiguate inspected/frontend controllers and pages in backend code

Modified: trunk/Source/WebCore/dom/EventTarget.idl (189659 => 189660)


--- trunk/Source/WebCore/dom/EventTarget.idl	2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/Source/WebCore/dom/EventTarget.idl	2015-09-12 21:52:25 UTC (rev 189660)
@@ -20,7 +20,6 @@
 
 // Introduced in DOM Level 2:
 [
-    NoInterfaceObject,
     ObjCProtocol,
     CPPPureInterface,
     CustomToJSObject,
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to