Title: [191166] trunk/LayoutTests
Revision
191166
Author
joep...@webkit.org
Date
2015-10-15 20:54:06 -0700 (Thu, 15 Oct 2015)

Log Message

Unreviewed gardening. Make inspector/heap/gc.html more reliable.

* inspector/heap/gc.html:
Stop outputing after we see the first Full GC. Resolving waits
for pending events which could incldue more GCs.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (191165 => 191166)


--- trunk/LayoutTests/ChangeLog	2015-10-16 03:07:25 UTC (rev 191165)
+++ trunk/LayoutTests/ChangeLog	2015-10-16 03:54:06 UTC (rev 191166)
@@ -1,3 +1,11 @@
+2015-10-15  Joseph Pecoraro  <pecor...@apple.com>
+
+        Unreviewed gardening. Make inspector/heap/gc.html more reliable.
+
+        * inspector/heap/gc.html:
+        Stop outputing after we see the first Full GC. Resolving waits
+        for pending events which could incldue more GCs.
+
 2015-10-14  Joseph Pecoraro  <pecor...@apple.com>
 
         Web Inspector: Include Garbage Collection Event in Timeline

Modified: trunk/LayoutTests/inspector/heap/gc.html (191165 => 191166)


--- trunk/LayoutTests/inspector/heap/gc.html	2015-10-16 03:07:25 UTC (rev 191165)
+++ trunk/LayoutTests/inspector/heap/gc.html	2015-10-16 03:54:06 UTC (rev 191166)
@@ -12,12 +12,14 @@
         description: "Calling Heap.gc should trigger Heap.garbageCollected event if enabled.",
         test: (resolve, reject) => {
             HeapAgent.gc();
+            let resolving = false;
             WebInspector.heapManager.addEventListener(WebInspector.HeapManager.Event.GarbageCollected, (event) => {
                 // Due to the asynchronous nature of Heap.garbageCollected events, we may see
                 // non-Full GC events before we see the Full collection triggered by HeapAgent.gc.
-                if (event.data.collection.type === WebInspector.GarbageCollection.Type.Full) {
+                if (!resolving && event.data.collection.type === WebInspector.GarbageCollection.Type.Full) {
                     InspectorTest.expectThat(event.data.collection instanceof WebInspector.GarbageCollection, "Event should have GarbageCollection data.");
                     InspectorTest.expectThat(event.data.collection.type === WebInspector.GarbageCollection.Type.Full, "GarbageCollection type should be Full.");
+                    resolving = true;
                     resolve();
                 }
             });
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to