Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (191484 => 191485)
--- trunk/Source/_javascript_Core/ChangeLog 2015-10-22 22:36:57 UTC (rev 191484)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-10-22 22:56:21 UTC (rev 191485)
@@ -1,3 +1,15 @@
+2015-10-22 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Remove unused Timeline GCEvent Record type
+ https://bugs.webkit.org/show_bug.cgi?id=150477
+
+ Reviewed by Timothy Hatcher.
+
+ Garbage Collection events go through the Heap domain, not the
+ Timeline domain (long time ago for Chromium).
+
+ * inspector/protocol/Timeline.json:
+
2015-10-22 Michael Saboff <msab...@apple.com>
REGRESSION(r191360): Repro Crash: com.apple.WebKit.WebContent at _javascript_Core:JSC::ExecState::bytecodeOffset + 174
Modified: trunk/Source/_javascript_Core/inspector/protocol/Timeline.json (191484 => 191485)
--- trunk/Source/_javascript_Core/inspector/protocol/Timeline.json 2015-10-22 22:36:57 UTC (rev 191484)
+++ trunk/Source/_javascript_Core/inspector/protocol/Timeline.json 2015-10-22 22:56:21 UTC (rev 191485)
@@ -31,7 +31,6 @@
"FunctionCall",
"ProbeSample",
"ConsoleProfile",
- "GCEvent",
"RequestAnimationFrame",
"CancelAnimationFrame",
"FireAnimationFrame",
Modified: trunk/Source/WebCore/ChangeLog (191484 => 191485)
--- trunk/Source/WebCore/ChangeLog 2015-10-22 22:36:57 UTC (rev 191484)
+++ trunk/Source/WebCore/ChangeLog 2015-10-22 22:56:21 UTC (rev 191485)
@@ -1,3 +1,16 @@
+2015-10-22 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Remove unused Timeline GCEvent Record type
+ https://bugs.webkit.org/show_bug.cgi?id=150477
+
+ Reviewed by Timothy Hatcher.
+
+ This event is dispatched through the Heap domain, not Timelines.
+
+ * inspector/TimelineRecordFactory.cpp:
+ (WebCore::TimelineRecordFactory::createGCEventData): Deleted.
+ * inspector/TimelineRecordFactory.h:
+
2015-10-22 Gordon Sheridan <gordon_sheri...@apple.com>
Fix build for clang-700.0.59.5 by replacing deprecated calls to convert points between screen and window coordinates for Mac.
Modified: trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp (191484 => 191485)
--- trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp 2015-10-22 22:36:57 UTC (rev 191484)
+++ trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp 2015-10-22 22:56:21 UTC (rev 191485)
@@ -70,13 +70,6 @@
return WTF::move(record);
}
-Ref<InspectorObject> TimelineRecordFactory::createGCEventData(const size_t usedHeapSizeDelta)
-{
- Ref<InspectorObject> data = ""
- data->setInteger("usedHeapSizeDelta", usedHeapSizeDelta);
- return WTF::move(data);
-}
-
Ref<InspectorObject> TimelineRecordFactory::createFunctionCallData(const String& scriptName, int scriptLine)
{
Ref<InspectorObject> data = ""
Modified: trunk/Source/WebCore/inspector/TimelineRecordFactory.h (191484 => 191485)
--- trunk/Source/WebCore/inspector/TimelineRecordFactory.h 2015-10-22 22:36:57 UTC (rev 191484)
+++ trunk/Source/WebCore/inspector/TimelineRecordFactory.h 2015-10-22 22:56:21 UTC (rev 191485)
@@ -58,8 +58,6 @@
static Ref<Inspector::InspectorObject> createGenericRecord(double startTime, int maxCallStackDepth);
static Ref<Inspector::InspectorObject> createBackgroundRecord(double startTime, const String& thread);
- static Ref<Inspector::InspectorObject> createGCEventData(const size_t usedHeapSizeDelta);
-
static Ref<Inspector::InspectorObject> createFunctionCallData(const String& scriptName, int scriptLine);
static Ref<Inspector::InspectorObject> createConsoleProfileData(const String& title);
Modified: trunk/Source/WebInspectorUI/ChangeLog (191484 => 191485)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-10-22 22:36:57 UTC (rev 191484)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-10-22 22:56:21 UTC (rev 191485)
@@ -1,5 +1,21 @@
2015-10-22 Joseph Pecoraro <pecor...@apple.com>
+ Web Inspector: Remove unused Timeline GCEvent Record type
+ https://bugs.webkit.org/show_bug.cgi?id=150477
+
+ Reviewed by Timothy Hatcher.
+
+ iOS backends never emitted a GCEvent timeline event.
+
+ * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
+ * Versions/Inspector-iOS-7.0.json:
+ * Versions/Inspector-iOS-8.0.json:
+ * Versions/Inspector-iOS-9.0.json:
+
+2015-10-22 Joseph Pecoraro <pecor...@apple.com>
+
Web Inspector: srcset attributes should have hyperlinks to the resources
https://bugs.webkit.org/show_bug.cgi?id=150409
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js (191484 => 191485)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js 2015-10-22 22:36:57 UTC (rev 191484)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js 2015-10-22 22:56:21 UTC (rev 191485)
@@ -244,7 +244,7 @@
// Timeline.
InspectorBackend.registerTimelineDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "Timeline");
-InspectorBackend.registerEnum("Timeline.EventType", {EventDispatch: "EventDispatch", ScheduleStyleRecalculation: "ScheduleStyleRecalculation", RecalculateStyles: "RecalculateStyles", InvalidateLayout: "InvalidateLayout", Layout: "Layout", Paint: "Paint", ScrollLayer: "ScrollLayer", ResizeImage: "ResizeImage", ParseHTML: "ParseHTML", TimerInstall: "TimerInstall", TimerRemove: "TimerRemove", TimerFire: "TimerFire", EvaluateScript: "EvaluateScript", MarkLoad: "MarkLoad", MarkDOMContent: "MarkDOMContent", TimeStamp: "TimeStamp", Time: "Time", TimeEnd: "TimeEnd", ScheduleResourceRequest: "ScheduleResourceRequest", ResourceSendRequest: "ResourceSendRequest", ResourceReceiveResponse: "ResourceReceiveResponse", ResourceReceivedData: "ResourceReceived
Data", ResourceFinish: "ResourceFinish", XHRReadyStateChange: "XHRReadyStateChange", XHRLoad: "XHRLoad", FunctionCall: "FunctionCall", GCEvent: "GCEvent", RequestAnimationFrame: "RequestAnimationFrame", CancelAnimationFrame: "CancelAnimationFrame", FireAnimationFrame: "FireAnimationFrame", WebSocketCreate: "WebSocketCreate", WebSocketSendHandshakeRequest: "WebSocketSendHandshakeRequest", WebSocketReceiveHandshakeResponse: "WebSocketReceiveHandshakeResponse", WebSocketDestroy: "WebSocketDestroy"});
+InspectorBackend.registerEnum("Timeline.EventType", {EventDispatch: "EventDispatch", ScheduleStyleRecalculation: "ScheduleStyleRecalculation", RecalculateStyles: "RecalculateStyles", InvalidateLayout: "InvalidateLayout", Layout: "Layout", Paint: "Paint", ScrollLayer: "ScrollLayer", ResizeImage: "ResizeImage", ParseHTML: "ParseHTML", TimerInstall: "TimerInstall", TimerRemove: "TimerRemove", TimerFire: "TimerFire", EvaluateScript: "EvaluateScript", MarkLoad: "MarkLoad", MarkDOMContent: "MarkDOMContent", TimeStamp: "TimeStamp", Time: "Time", TimeEnd: "TimeEnd", ScheduleResourceRequest: "ScheduleResourceRequest", ResourceSendRequest: "ResourceSendRequest", ResourceReceiveResponse: "ResourceReceiveResponse", ResourceReceivedData: "ResourceReceivedD
ata", ResourceFinish: "ResourceFinish", XHRReadyStateChange: "XHRReadyStateChange", XHRLoad: "XHRLoad", FunctionCall: "FunctionCall", RequestAnimationFrame: "RequestAnimationFrame", CancelAnimationFrame: "CancelAnimationFrame", FireAnimationFrame: "FireAnimationFrame", WebSocketCreate: "WebSocketCreate", WebSocketSendHandshakeRequest: "WebSocketSendHandshakeRequest", WebSocketReceiveHandshakeResponse: "WebSocketReceiveHandshakeResponse", WebSocketDestroy: "WebSocketDestroy"});
InspectorBackend.registerEvent("Timeline.eventRecorded", ["record"]);
InspectorBackend.registerCommand("Timeline.start", [{"name": "maxCallStackDepth", "type": "number", "optional": true}], []);
InspectorBackend.registerCommand("Timeline.stop", [], []);
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js (191484 => 191485)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js 2015-10-22 22:36:57 UTC (rev 191484)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js 2015-10-22 22:56:21 UTC (rev 191485)
@@ -336,7 +336,7 @@
// Timeline.
InspectorBackend.registerTimelineDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "Timeline");
-InspectorBackend.registerEnum("Timeline.EventType", {EventDispatch: "EventDispatch", ScheduleStyleRecalculation: "ScheduleStyleRecalculation", RecalculateStyles: "RecalculateStyles", InvalidateLayout: "InvalidateLayout", Layout: "Layout", Paint: "Paint", ScrollLayer: "ScrollLayer", ResizeImage: "ResizeImage", ParseHTML: "ParseHTML", TimerInstall: "TimerInstall", TimerRemove: "TimerRemove", TimerFire: "TimerFire", EvaluateScript: "EvaluateScript", MarkLoad: "MarkLoad", MarkDOMContent: "MarkDOMContent", TimeStamp: "TimeStamp", Time: "Time", TimeEnd: "TimeEnd", ScheduleResourceRequest: "ScheduleResourceRequest", ResourceSendRequest: "ResourceSendRequest", ResourceReceiveResponse: "ResourceReceiveResponse", ResourceReceivedData: "ResourceReceived
Data", ResourceFinish: "ResourceFinish", XHRReadyStateChange: "XHRReadyStateChange", XHRLoad: "XHRLoad", FunctionCall: "FunctionCall", ProbeSample: "ProbeSample", ConsoleProfile: "ConsoleProfile", GCEvent: "GCEvent", RequestAnimationFrame: "RequestAnimationFrame", CancelAnimationFrame: "CancelAnimationFrame", FireAnimationFrame: "FireAnimationFrame", WebSocketCreate: "WebSocketCreate", WebSocketSendHandshakeRequest: "WebSocketSendHandshakeRequest", WebSocketReceiveHandshakeResponse: "WebSocketReceiveHandshakeResponse", WebSocketDestroy: "WebSocketDestroy"});
+InspectorBackend.registerEnum("Timeline.EventType", {EventDispatch: "EventDispatch", ScheduleStyleRecalculation: "ScheduleStyleRecalculation", RecalculateStyles: "RecalculateStyles", InvalidateLayout: "InvalidateLayout", Layout: "Layout", Paint: "Paint", ScrollLayer: "ScrollLayer", ResizeImage: "ResizeImage", ParseHTML: "ParseHTML", TimerInstall: "TimerInstall", TimerRemove: "TimerRemove", TimerFire: "TimerFire", EvaluateScript: "EvaluateScript", MarkLoad: "MarkLoad", MarkDOMContent: "MarkDOMContent", TimeStamp: "TimeStamp", Time: "Time", TimeEnd: "TimeEnd", ScheduleResourceRequest: "ScheduleResourceRequest", ResourceSendRequest: "ResourceSendRequest", ResourceReceiveResponse: "ResourceReceiveResponse", ResourceReceivedData: "ResourceReceivedD
ata", ResourceFinish: "ResourceFinish", XHRReadyStateChange: "XHRReadyStateChange", XHRLoad: "XHRLoad", FunctionCall: "FunctionCall", ProbeSample: "ProbeSample", ConsoleProfile: "ConsoleProfile", RequestAnimationFrame: "RequestAnimationFrame", CancelAnimationFrame: "CancelAnimationFrame", FireAnimationFrame: "FireAnimationFrame", WebSocketCreate: "WebSocketCreate", WebSocketSendHandshakeRequest: "WebSocketSendHandshakeRequest", WebSocketReceiveHandshakeResponse: "WebSocketReceiveHandshakeResponse", WebSocketDestroy: "WebSocketDestroy"});
InspectorBackend.registerEvent("Timeline.eventRecorded", ["record"]);
InspectorBackend.registerEvent("Timeline.recordingStarted", []);
InspectorBackend.registerEvent("Timeline.recordingStopped", []);
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js (191484 => 191485)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js 2015-10-22 22:36:57 UTC (rev 191484)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js 2015-10-22 22:56:21 UTC (rev 191485)
@@ -333,7 +333,7 @@
// Timeline.
InspectorBackend.registerTimelineDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "Timeline");
-InspectorBackend.registerEnum("Timeline.EventType", {EventDispatch: "EventDispatch", ScheduleStyleRecalculation: "ScheduleStyleRecalculation", RecalculateStyles: "RecalculateStyles", InvalidateLayout: "InvalidateLayout", Layout: "Layout", Paint: "Paint", Composite: "Composite", RenderingFrame: "RenderingFrame", ScrollLayer: "ScrollLayer", ParseHTML: "ParseHTML", TimerInstall: "TimerInstall", TimerRemove: "TimerRemove", TimerFire: "TimerFire", EvaluateScript: "EvaluateScript", MarkLoad: "MarkLoad", MarkDOMContent: "MarkDOMContent", TimeStamp: "TimeStamp", Time: "Time", TimeEnd: "TimeEnd", XHRReadyStateChange: "XHRReadyStateChange", XHRLoad: "XHRLoad", FunctionCall: "FunctionCall", ProbeSample: "ProbeSample", ConsoleProfile: &quo
t;ConsoleProfile", GCEvent: "GCEvent", RequestAnimationFrame: "RequestAnimationFrame", CancelAnimationFrame: "CancelAnimationFrame", FireAnimationFrame: "FireAnimationFrame", WebSocketCreate: "WebSocketCreate", WebSocketSendHandshakeRequest: "WebSocketSendHandshakeRequest", WebSocketReceiveHandshakeResponse: "WebSocketReceiveHandshakeResponse", WebSocketDestroy: "WebSocketDestroy"});
+InspectorBackend.registerEnum("Timeline.EventType", {EventDispatch: "EventDispatch", ScheduleStyleRecalculation: "ScheduleStyleRecalculation", RecalculateStyles: "RecalculateStyles", InvalidateLayout: "InvalidateLayout", Layout: "Layout", Paint: "Paint", Composite: "Composite", RenderingFrame: "RenderingFrame", ScrollLayer: "ScrollLayer", ParseHTML: "ParseHTML", TimerInstall: "TimerInstall", TimerRemove: "TimerRemove", TimerFire: "TimerFire", EvaluateScript: "EvaluateScript", MarkLoad: "MarkLoad", MarkDOMContent: "MarkDOMContent", TimeStamp: "TimeStamp", Time: "Time", TimeEnd: "TimeEnd", XHRReadyStateChange: "XHRReadyStateChange", XHRLoad: "XHRLoad", FunctionCall: "FunctionCall", ProbeSample: "ProbeSample", ConsoleProfile: "
;ConsoleProfile", RequestAnimationFrame: "RequestAnimationFrame", CancelAnimationFrame: "CancelAnimationFrame", FireAnimationFrame: "FireAnimationFrame", WebSocketCreate: "WebSocketCreate", WebSocketSendHandshakeRequest: "WebSocketSendHandshakeRequest", WebSocketReceiveHandshakeResponse: "WebSocketReceiveHandshakeResponse", WebSocketDestroy: "WebSocketDestroy"});
InspectorBackend.registerEvent("Timeline.eventRecorded", ["record"]);
InspectorBackend.registerEvent("Timeline.recordingStarted", []);
InspectorBackend.registerEvent("Timeline.recordingStopped", []);
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json (191484 => 191485)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json 2015-10-22 22:36:57 UTC (rev 191484)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json 2015-10-22 22:56:21 UTC (rev 191485)
@@ -2102,7 +2102,7 @@
{
"id": "EventType",
"type": "string",
- "enum": ["EventDispatch", "ScheduleStyleRecalculation", "RecalculateStyles", "InvalidateLayout", "Layout", "Paint", "ScrollLayer", "ResizeImage", "ParseHTML", "TimerInstall", "TimerRemove", "TimerFire", "EvaluateScript", "MarkLoad", "MarkDOMContent", "TimeStamp", "Time", "TimeEnd", "ScheduleResourceRequest", "ResourceSendRequest", "ResourceReceiveResponse", "ResourceReceivedData", "ResourceFinish", "XHRReadyStateChange", "XHRLoad", "FunctionCall", "GCEvent", "RequestAnimationFrame", "CancelAnimationFrame", "FireAnimationFrame", "WebSocketCreate", "WebSocketSendHandshakeRequest", "WebSocketReceiveHandshakeResponse"
, "WebSocketDestroy"],
+ "enum": ["EventDispatch", "ScheduleStyleRecalculation", "RecalculateStyles", "InvalidateLayout", "Layout", "Paint", "ScrollLayer", "ResizeImage", "ParseHTML", "TimerInstall", "TimerRemove", "TimerFire", "EvaluateScript", "MarkLoad", "MarkDOMContent", "TimeStamp", "Time", "TimeEnd", "ScheduleResourceRequest", "ResourceSendRequest", "ResourceReceiveResponse", "ResourceReceivedData", "ResourceFinish", "XHRReadyStateChange", "XHRLoad", "FunctionCall", "RequestAnimationFrame", "CancelAnimationFrame", "FireAnimationFrame", "WebSocketCreate", "WebSocketSendHandshakeRequest", "WebSocketReceiveHandshakeResponse", "WebSocketDestr
oy"],
"description": "Timeline record type."
},
{
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json (191484 => 191485)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json 2015-10-22 22:36:57 UTC (rev 191484)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json 2015-10-22 22:56:21 UTC (rev 191485)
@@ -2970,7 +2970,7 @@
{
"id": "EventType",
"type": "string",
- "enum": ["EventDispatch", "ScheduleStyleRecalculation", "RecalculateStyles", "InvalidateLayout", "Layout", "Paint", "ScrollLayer", "ResizeImage", "ParseHTML", "TimerInstall", "TimerRemove", "TimerFire", "EvaluateScript", "MarkLoad", "MarkDOMContent", "TimeStamp", "Time", "TimeEnd", "ScheduleResourceRequest", "ResourceSendRequest", "ResourceReceiveResponse", "ResourceReceivedData", "ResourceFinish", "XHRReadyStateChange", "XHRLoad", "FunctionCall", "ProbeSample", "ConsoleProfile", "GCEvent", "RequestAnimationFrame", "CancelAnimationFrame", "FireAnimationFrame", "WebSocketCreate", "WebSocketSendHandshakeRequest&quo
t;, "WebSocketReceiveHandshakeResponse", "WebSocketDestroy"],
+ "enum": ["EventDispatch", "ScheduleStyleRecalculation", "RecalculateStyles", "InvalidateLayout", "Layout", "Paint", "ScrollLayer", "ResizeImage", "ParseHTML", "TimerInstall", "TimerRemove", "TimerFire", "EvaluateScript", "MarkLoad", "MarkDOMContent", "TimeStamp", "Time", "TimeEnd", "ScheduleResourceRequest", "ResourceSendRequest", "ResourceReceiveResponse", "ResourceReceivedData", "ResourceFinish", "XHRReadyStateChange", "XHRLoad", "FunctionCall", "ProbeSample", "ConsoleProfile", "RequestAnimationFrame", "CancelAnimationFrame", "FireAnimationFrame", "WebSocketCreate", "WebSocketSendHandshakeRequest", "WebSocketRec
eiveHandshakeResponse", "WebSocketDestroy"],
"description": "Timeline record type."
},
{
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json (191484 => 191485)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json 2015-10-22 22:36:57 UTC (rev 191484)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json 2015-10-22 22:56:21 UTC (rev 191485)
@@ -3226,7 +3226,6 @@
"FunctionCall",
"ProbeSample",
"ConsoleProfile",
- "GCEvent",
"RequestAnimationFrame",
"CancelAnimationFrame",
"FireAnimationFrame",
