Title: [193817] trunk/Source/WebCore
Revision
193817
Author
zandober...@gmail.com
Date
2015-12-09 03:20:33 -0800 (Wed, 09 Dec 2015)

Log Message

[Soup] SocketStreamHandle should call g_source_destroy() on the write-ready source
https://bugs.webkit.org/show_bug.cgi?id=152040

Reviewed by Carlos Garcia Campos.

* platform/network/soup/SocketStreamHandleSoup.cpp:
(WebCore::SocketStreamHandle::stopWaitingForSocketWritability): Instead of
calling the g_source_get_id()-g_source_remove() pair, destroy the source via
the g_source_destroy() call. Also use nullptr to clear out the pointer
variable.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (193816 => 193817)


--- trunk/Source/WebCore/ChangeLog	2015-12-09 11:12:52 UTC (rev 193816)
+++ trunk/Source/WebCore/ChangeLog	2015-12-09 11:20:33 UTC (rev 193817)
@@ -1,5 +1,18 @@
 2015-12-09  Zan Dobersek  <zdober...@igalia.com>
 
+        [Soup] SocketStreamHandle should call g_source_destroy() on the write-ready source
+        https://bugs.webkit.org/show_bug.cgi?id=152040
+
+        Reviewed by Carlos Garcia Campos.
+
+        * platform/network/soup/SocketStreamHandleSoup.cpp:
+        (WebCore::SocketStreamHandle::stopWaitingForSocketWritability): Instead of
+        calling the g_source_get_id()-g_source_remove() pair, destroy the source via
+        the g_source_destroy() call. Also use nullptr to clear out the pointer
+        variable.
+
+2015-12-09  Zan Dobersek  <zdober...@igalia.com>
+
         Make AudioBusGtk implementation GLib-specific
         https://bugs.webkit.org/show_bug.cgi?id=152049
 

Modified: trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp (193816 => 193817)


--- trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp	2015-12-09 11:12:52 UTC (rev 193816)
+++ trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp	2015-12-09 11:20:33 UTC (rev 193817)
@@ -253,8 +253,8 @@
     if (!m_writeReadySource) // Not waiting.
         return;
 
-    g_source_remove(g_source_get_id(m_writeReadySource.get()));
-    m_writeReadySource = 0;
+    g_source_destroy(m_writeReadySource.get());
+    m_writeReadySource = nullptr;
 }
 
 static void connectedCallback(GSocketClient* client, GAsyncResult* result, void* id)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to