Title: [193864] trunk/Source/WebKit2
- Revision
- 193864
- Author
- bb...@apple.com
- Date
- 2015-12-09 14:11:41 -0800 (Wed, 09 Dec 2015)
Log Message
Web Inspector: reproducible debug ASSERT when inspecting the inspector (WK2)
https://bugs.webkit.org/show_bug.cgi?id=152080
Reviewed by Timothy Hatcher.
We hit an assert underneath ChildProcessProxy::addMessageReceiver because
we tried to connect the inspector page and inspected page more than once.
This relationship is already set up in the constructor of WebProcessProxy.
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::eagerlyCreateInspectorPage):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (193863 => 193864)
--- trunk/Source/WebKit2/ChangeLog 2015-12-09 22:11:12 UTC (rev 193863)
+++ trunk/Source/WebKit2/ChangeLog 2015-12-09 22:11:41 UTC (rev 193864)
@@ -1,3 +1,17 @@
+2015-12-09 Brian Burg <bb...@apple.com>
+
+ Web Inspector: reproducible debug ASSERT when inspecting the inspector (WK2)
+ https://bugs.webkit.org/show_bug.cgi?id=152080
+
+ Reviewed by Timothy Hatcher.
+
+ We hit an assert underneath ChildProcessProxy::addMessageReceiver because
+ we tried to connect the inspector page and inspected page more than once.
+ This relationship is already set up in the constructor of WebProcessProxy.
+
+ * UIProcess/WebInspectorProxy.cpp:
+ (WebKit::WebInspectorProxy::eagerlyCreateInspectorPage):
+
2015-12-09 Gyuyoung Kim <gyuyoung....@webkit.org>
[EFL] Need to change expectation result in ewk_settings_offline_web_application_cache_enabled API test
Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp (193863 => 193864)
--- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp 2015-12-09 22:11:12 UTC (rev 193863)
+++ trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp 2015-12-09 22:11:41 UTC (rev 193864)
@@ -510,7 +510,6 @@
WKPageSetPageLoaderClient(toAPI(m_inspectorPage), &loaderClient.base);
WKPageSetPageContextMenuClient(toAPI(m_inspectorPage), &contextMenuClient.base);
- m_inspectorPage->process().addMessageReceiver(Messages::WebInspectorProxy::messageReceiverName(), m_inspectedPage->pageID(), *this);
m_inspectorPage->process().assumeReadAccessToBaseURL(WebInspectorProxy::inspectorBaseURL());
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
