Title: [194768] trunk/Tools
Revision
194768
Author
aakash_j...@apple.com
Date
2016-01-08 10:20:27 -0800 (Fri, 08 Jan 2016)

Log Message

run-webkit-tests mis-counts totals when there are other crashes
https://bugs.webkit.org/show_bug.cgi?id=152894
<rdar://problem/24098697>

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/layout_tests/models/test_run_results.py:
(TestRunResults.add): Do not update result counters for other crashes.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (194767 => 194768)


--- trunk/Tools/ChangeLog	2016-01-08 18:10:36 UTC (rev 194767)
+++ trunk/Tools/ChangeLog	2016-01-08 18:20:27 UTC (rev 194768)
@@ -1,3 +1,14 @@
+2016-01-08  Aakash Jain  <aakash_j...@apple.com>
+
+        run-webkit-tests mis-counts totals when there are other crashes
+        https://bugs.webkit.org/show_bug.cgi?id=152894
+        <rdar://problem/24098697>
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Scripts/webkitpy/layout_tests/models/test_run_results.py:
+        (TestRunResults.add): Do not update result counters for other crashes.
+
 2016-01-08  Youenn Fablet  <youenn.fab...@crf.canon.fr>
 
         webkit-patch build-and-test should have an option to iterate over new tests

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py (194767 => 194768)


--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py	2016-01-08 18:10:36 UTC (rev 194767)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py	2016-01-08 18:20:27 UTC (rev 194768)
@@ -67,6 +67,8 @@
     def add(self, test_result, expected, test_is_slow):
         self.tests_by_expectation[test_result.type].add(test_result.test_name)
         self.results_by_name[test_result.test_name] = test_result
+        if test_result.is_other_crash:
+            return
         if test_result.type != test_expectations.SKIP:
             self.all_results.append(test_result)
         self.remaining -= 1
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to