Title: [196336] trunk/Source/WebInspectorUI
- Revision
- 196336
- Author
- commit-qu...@webkit.org
- Date
- 2016-02-09 14:16:14 -0800 (Tue, 09 Feb 2016)
Log Message
Web Inspector: Expiration column in Storage tab can't be sorted
https://bugs.webkit.org/show_bug.cgi?id=154043
<rdar://problem/24572272>
Patch by Joseph Pecoraro <pecor...@apple.com> on 2016-02-09
Reviewed by Brian Burg.
* UserInterface/Views/CookieStorageContentView.js:
(WebInspector.CookieStorageContentView.prototype._sortDataGrid.expiresCompare):
Sort Session as the shortest time, not the longest time. Use the
cookie.expires date when sorting, not the locale string.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (196335 => 196336)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-02-09 22:09:44 UTC (rev 196335)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-02-09 22:16:14 UTC (rev 196336)
@@ -1,5 +1,18 @@
2016-02-09 Joseph Pecoraro <pecor...@apple.com>
+ Web Inspector: Expiration column in Storage tab can't be sorted
+ https://bugs.webkit.org/show_bug.cgi?id=154043
+ <rdar://problem/24572272>
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/CookieStorageContentView.js:
+ (WebInspector.CookieStorageContentView.prototype._sortDataGrid.expiresCompare):
+ Sort Session as the shortest time, not the longest time. Use the
+ cookie.expires date when sorting, not the locale string.
+
+2016-02-09 Joseph Pecoraro <pecor...@apple.com>
+
Web Inspector: Limit max and min zoom factor of Inspector
https://bugs.webkit.org/show_bug.cgi?id=154041
<rdar://problem/24571326>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js (196335 => 196336)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js 2016-02-09 22:09:44 UTC (rev 196335)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js 2016-02-09 22:16:14 UTC (rev 196336)
@@ -185,12 +185,12 @@
function expiresCompare(nodeA, nodeB)
{
if (nodeA.cookie.session !== nodeB.cookie.session)
- return nodeA.cookie.session ? 1 : -1;
+ return nodeA.cookie.session ? -1 : 1;
if (nodeA.cookie.session)
return 0;
- return nodeA.data["expires"] - nodeB.data["expires"];
+ return nodeA.cookie.expires - nodeB.cookie.expires;
}
var comparator;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
