Title: [197138] trunk/LayoutTests
- Revision
- 197138
- Author
- beid...@apple.com
- Date
- 2016-02-25 15:12:50 -0800 (Thu, 25 Feb 2016)
Log Message
Unreviewed test gardening.
Fix a test flake where order doesn't matter.
* platform/wk2/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt: Removed.
* storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt:
* storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-private-expected.txt:
* storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js:
(prepareDatabase.request.onblocked):
(onOpenSuccess):
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (197137 => 197138)
--- trunk/LayoutTests/ChangeLog 2016-02-25 23:10:31 UTC (rev 197137)
+++ trunk/LayoutTests/ChangeLog 2016-02-25 23:12:50 UTC (rev 197138)
@@ -12,6 +12,19 @@
Unreviewed test gardening.
+ Fix a test flake where order doesn't matter.
+
+ * platform/wk2/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt: Removed.
+ * storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt:
+ * storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-private-expected.txt:
+ * storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js:
+ (prepareDatabase.request.onblocked):
+ (onOpenSuccess):
+
+2016-02-25 Brady Eidson <beid...@apple.com>
+
+ Unreviewed test gardening.
+
* TestExpectations: Skip a web inspector IndexedDB test for now.
2016-02-25 Ryan Haddad <ryanhad...@apple.com>
Deleted: trunk/LayoutTests/platform/wk2/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt (197137 => 197138)
--- trunk/LayoutTests/platform/wk2/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt 2016-02-25 23:10:31 UTC (rev 197137)
+++ trunk/LayoutTests/platform/wk2/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt 2016-02-25 23:12:50 UTC (rev 197138)
@@ -1,35 +0,0 @@
-Test that deleteDatabase is delayed if a VERSION_CHANGE transaction is running
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
-
-indexedDB.deleteDatabase(dbname)
-indexedDB.open(dbname)
-
-prepareDatabase():
-versionChangeComplete = false
-h = event.target.result
-indexedDB.deleteDatabase(dbname)
-
-onVersionChange():
-PASS event.target.version is 1
-PASS event.oldVersion is 1
-PASS event.newVersion is null
-
-transactionOnComplete():
-versionChangeComplete = true
-
-deleteDatabaseOnBlocked():
-
-onOpenSuccess():
-h = event.target.result
-h.close()
-
-deleteDatabaseOnSuccess():
-PASS versionChangeComplete is true
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Modified: trunk/LayoutTests/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt (197137 => 197138)
--- trunk/LayoutTests/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt 2016-02-25 23:10:31 UTC (rev 197137)
+++ trunk/LayoutTests/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt 2016-02-25 23:12:50 UTC (rev 197138)
@@ -18,12 +18,11 @@
PASS event.oldVersion is 1
PASS event.newVersion is null
-deleteDatabaseOnBlocked():
-
transactionOnComplete():
versionChangeComplete = true
onOpenSuccess():
+PASS blockedCalled is true
h = event.target.result
h.close()
Modified: trunk/LayoutTests/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-private-expected.txt (197137 => 197138)
--- trunk/LayoutTests/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-private-expected.txt 2016-02-25 23:10:31 UTC (rev 197137)
+++ trunk/LayoutTests/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-private-expected.txt 2016-02-25 23:12:50 UTC (rev 197138)
@@ -18,12 +18,11 @@
PASS event.oldVersion is 1
PASS event.newVersion is null
-deleteDatabaseOnBlocked():
-
transactionOnComplete():
versionChangeComplete = true
onOpenSuccess():
+PASS blockedCalled is true
h = event.target.result
h.close()
Modified: trunk/LayoutTests/storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js (197137 => 197138)
--- trunk/LayoutTests/storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js 2016-02-25 23:10:31 UTC (rev 197137)
+++ trunk/LayoutTests/storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js 2016-02-25 23:12:50 UTC (rev 197138)
@@ -6,6 +6,7 @@
description("Test that deleteDatabase is delayed if a VERSION_CHANGE transaction is running");
indexedDBTest(prepareDatabase, onOpenSuccess);
+
function prepareDatabase(evt)
{
preamble(evt);
@@ -28,7 +29,7 @@
request = evalAndLog("indexedDB.deleteDatabase(dbname)");
request._onerror_ = unexpectedErrorCallback;
request._onblocked_ = function deleteDatabaseOnBlocked(evt) {
- preamble(evt);
+ eval("blockedCalled = true");
};
request._onsuccess_ = function deleteDatabaseOnSuccess(evt) {
preamble(evt);
@@ -40,6 +41,7 @@
function onOpenSuccess(evt)
{
preamble(evt);
+ shouldBeTrue("blockedCalled");
evalAndLog("h = event.target.result");
evalAndLog("h.close()");
}
\ No newline at end of file
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
