Title: [199774] trunk
- Revision
- 199774
- Author
- beid...@apple.com
- Date
- 2016-04-20 09:14:14 -0700 (Wed, 20 Apr 2016)
Log Message
Addressing additional review feedback for:
Modern IDB: Lots of IDB bindings cleanup (including making IDBVersionChangeEvent constructible).
https://bugs.webkit.org/show_bug.cgi?id=156760
Source/WebCore:
* Modules/indexeddb/IDBVersionChangeEvent.h:
LayoutTests:
* storage/indexeddb/modern/idbversionchangeevent-constructor-expected.txt:
* storage/indexeddb/modern/idbversionchangeevent-constructor.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (199773 => 199774)
--- trunk/LayoutTests/ChangeLog 2016-04-20 15:43:51 UTC (rev 199773)
+++ trunk/LayoutTests/ChangeLog 2016-04-20 16:14:14 UTC (rev 199774)
@@ -1,3 +1,12 @@
+2016-04-20 Brady Eidson <beid...@apple.com>
+
+ Addressing additional review feedback for:
+ Modern IDB: Lots of IDB bindings cleanup (including making IDBVersionChangeEvent constructible).
+ https://bugs.webkit.org/show_bug.cgi?id=156760
+
+ * storage/indexeddb/modern/idbversionchangeevent-constructor-expected.txt:
+ * storage/indexeddb/modern/idbversionchangeevent-constructor.html:
+
2016-04-20 Frederic Wang <fw...@igalia.com>
Refactor RenderMathMLSpace to avoid using flexbox
Modified: trunk/LayoutTests/storage/indexeddb/modern/idbversionchangeevent-constructor-expected.txt (199773 => 199774)
--- trunk/LayoutTests/storage/indexeddb/modern/idbversionchangeevent-constructor-expected.txt 2016-04-20 15:43:51 UTC (rev 199773)
+++ trunk/LayoutTests/storage/indexeddb/modern/idbversionchangeevent-constructor-expected.txt 2016-04-20 16:14:14 UTC (rev 199774)
@@ -10,6 +10,9 @@
event = new IDBVersionChangeEvent('bar', { oldVersion: 6, newVersion: null });
PASS event.oldVersion is 6
PASS event.newVersion is null
+event = new IDBVersionChangeEvent('bar', { oldVersion: 4, newVersion: undefined });
+PASS event.oldVersion is 4
+PASS event.newVersion is null
event = new IDBVersionChangeEvent('bar', { oldVersion: 0, newVersion: 17 });
PASS event.oldVersion is 0
PASS event.newVersion is 17
Modified: trunk/LayoutTests/storage/indexeddb/modern/idbversionchangeevent-constructor.html (199773 => 199774)
--- trunk/LayoutTests/storage/indexeddb/modern/idbversionchangeevent-constructor.html 2016-04-20 15:43:51 UTC (rev 199773)
+++ trunk/LayoutTests/storage/indexeddb/modern/idbversionchangeevent-constructor.html 2016-04-20 16:14:14 UTC (rev 199774)
@@ -23,6 +23,10 @@
shouldBeEqualToNumber("event.oldVersion", 6);
shouldBeNull("event.newVersion");
+evalAndLog("event = new IDBVersionChangeEvent('bar', { oldVersion: 4, newVersion: undefined });");
+shouldBeEqualToNumber("event.oldVersion", 4);
+shouldBeNull("event.newVersion");
+
evalAndLog("event = new IDBVersionChangeEvent('bar', { oldVersion: 0, newVersion: 17 });");
shouldBeEqualToNumber("event.oldVersion", 0);
shouldBeEqualToNumber("event.newVersion", 17);
Modified: trunk/Source/WebCore/ChangeLog (199773 => 199774)
--- trunk/Source/WebCore/ChangeLog 2016-04-20 15:43:51 UTC (rev 199773)
+++ trunk/Source/WebCore/ChangeLog 2016-04-20 16:14:14 UTC (rev 199774)
@@ -1,3 +1,11 @@
+2016-04-20 Brady Eidson <beid...@apple.com>
+
+ Addressing additional review feedback for:
+ Modern IDB: Lots of IDB bindings cleanup (including making IDBVersionChangeEvent constructible).
+ https://bugs.webkit.org/show_bug.cgi?id=156760
+
+ * Modules/indexeddb/IDBVersionChangeEvent.h:
+
2016-04-20 Frederic Wang <fw...@igalia.com>
Use OpenType MATH fonts by default
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.h (199773 => 199774)
--- trunk/Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.h 2016-04-20 15:43:51 UTC (rev 199773)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.h 2016-04-20 16:14:14 UTC (rev 199774)
@@ -35,7 +35,7 @@
struct IDBVersionChangeEventInit : public EventInit {
uint64_t oldVersion { 0 };
- Optional<uint64_t> newVersion { Nullopt };
+ Optional<uint64_t> newVersion;
};
class IDBVersionChangeEvent final : public Event {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
