Title: [205890] trunk
- Revision
- 205890
- Author
- jer.no...@apple.com
- Date
- 2016-09-13 17:11:42 -0700 (Tue, 13 Sep 2016)
Log Message
[media-source] MediaSource.addSourceBuffer(null) should throw an exception
https://bugs.webkit.org/show_bug.cgi?id=161884
Reviewed by Eric Carlson.
Source/WebCore:
Fixes test: imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer.html
* Modules/mediasource/MediaSource.idl: The addSourceBuffer() parameter is not optional
and not nullable.
LayoutTests:
* platform/mac/TestExpectations:
* platform/mac/imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-expected.txt: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (205889 => 205890)
--- trunk/LayoutTests/ChangeLog 2016-09-14 00:10:50 UTC (rev 205889)
+++ trunk/LayoutTests/ChangeLog 2016-09-14 00:11:42 UTC (rev 205890)
@@ -1,3 +1,13 @@
+2016-09-13 Jer Noble <jer.no...@apple.com>
+
+ [media-source] MediaSource.addSourceBuffer(null) should throw an exception
+ https://bugs.webkit.org/show_bug.cgi?id=161884
+
+ Reviewed by Eric Carlson.
+
+ * platform/mac/TestExpectations:
+ * platform/mac/imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-expected.txt: Added.
+
2016-09-13 Myles C. Maxfield <mmaxfi...@apple.com>
[Cocoa] Unify font's ascent, descent, and x-height between macOS and iOS
Modified: trunk/LayoutTests/platform/mac/TestExpectations (205889 => 205890)
--- trunk/LayoutTests/platform/mac/TestExpectations 2016-09-14 00:10:50 UTC (rev 205889)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2016-09-14 00:11:42 UTC (rev 205890)
@@ -1046,6 +1046,7 @@
[ Yosemite+ ] imported/w3c/web-platform-tests/media-source/SourceBuffer-abort-readyState.html [ Pass ]
[ Yosemite+ ] imported/w3c/web-platform-tests/media-source/SourceBuffer-abort-removed.html [ Pass ]
[ Yosemite+ ] imported/w3c/web-platform-tests/media-source/SourceBuffer-abort.html [ Pass ]
+[ Yosemite+ ] imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer.html [ Pass ]
[ Yosemite+ ] imported/w3c/web-platform-tests/media-source/mediasource-closed.html [ Pass ]
[ Yosemite+ ] imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-v-bitrate.html [ Pass ]
[ Yosemite+ ] imported/w3c/web-platform-tests/media-source/mediasource-endofstream-invaliderror.html [ Pass ]
@@ -1058,7 +1059,6 @@
webkit.org/b/161391 [ Yosemite+ ] imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-v-framerate.html [ Pass Failure ]
# Newly failing Media Source tests
-webkit.org/b/161725 [ Yosemite+ ] imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer.html [ Failure ]
webkit.org/b/161725 [ Yosemite+ ] imported/w3c/web-platform-tests/media-source/mediasource-append-buffer.html [ Failure ]
webkit.org/b/161725 [ Yosemite+ ] imported/w3c/web-platform-tests/media-source/mediasource-is-type-supported.html [ Failure ]
webkit.org/b/161725 [ Yosemite+ ] imported/w3c/web-platform-tests/media-source/mediasource-remove.html [ Failure ]
Added: trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-expected.txt (0 => 205890)
--- trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-expected.txt 2016-09-14 00:11:42 UTC (rev 205890)
@@ -0,0 +1,13 @@
+
+PASS Test addSourceBuffer() in 'ended' state.
+PASS Test addSourceBuffer() with empty type
+PASS Test addSourceBuffer() with null
+PASS Test addSourceBuffer() with unsupported type
+FAIL Test addSourceBuffer() with Vorbis and VP8 assert_true: video/webm;codecs="vp8,vorbis" is supported expected true got false
+FAIL Test addSourceBuffer() with Vorbis and VP8 in separate SourceBuffers assert_true: video/webm;codecs="vp8" is supported expected true got false
+PASS Test addSourceBuffer() video only
+PASS Test addSourceBuffer() audio only
+PASS Test addSourceBuffer() with AAC and H.264
+PASS Test addSourceBuffer() with AAC and H.264 in separate SourceBuffers
+FAIL Test addSourceBuffer() QuotaExceededError. assert_true: Reached SourceBuffer limit. expected true got false
+
Modified: trunk/Source/WebCore/ChangeLog (205889 => 205890)
--- trunk/Source/WebCore/ChangeLog 2016-09-14 00:10:50 UTC (rev 205889)
+++ trunk/Source/WebCore/ChangeLog 2016-09-14 00:11:42 UTC (rev 205890)
@@ -1,3 +1,15 @@
+2016-09-13 Jer Noble <jer.no...@apple.com>
+
+ [media-source] MediaSource.addSourceBuffer(null) should throw an exception
+ https://bugs.webkit.org/show_bug.cgi?id=161884
+
+ Reviewed by Eric Carlson.
+
+ Fixes test: imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer.html
+
+ * Modules/mediasource/MediaSource.idl: The addSourceBuffer() parameter is not optional
+ and not nullable.
+
2016-09-13 Daniel Bates <daba...@apple.com>
Remove Chrome app-specific CSS property -webkit-app-region
Modified: trunk/Source/WebCore/Modules/mediasource/MediaSource.idl (205889 => 205890)
--- trunk/Source/WebCore/Modules/mediasource/MediaSource.idl 2016-09-14 00:10:50 UTC (rev 205889)
+++ trunk/Source/WebCore/Modules/mediasource/MediaSource.idl 2016-09-14 00:11:42 UTC (rev 205890)
@@ -48,8 +48,7 @@
[SetterRaisesException] attribute unrestricted double duration;
- // FIXME: type should not be nullable.
- [RaisesException] SourceBuffer addSourceBuffer(DOMString? type);
+ [RaisesException] SourceBuffer addSourceBuffer(DOMString type);
[RaisesException] void removeSourceBuffer(SourceBuffer buffer);
readonly attribute DOMString readyState;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
