Title: [206493] trunk/LayoutTests
Revision
206493
Author
rn...@webkit.org
Date
2016-09-27 20:03:40 -0700 (Tue, 27 Sep 2016)

Log Message

Toggling display: none on a parent element of a slot which shares style with its parent doesn't update the slot's visibility
https://bugs.webkit.org/show_bug.cgi?id=158421

Reviewed by Darin Adler.

Add a regression test now that the bug has been fixed by r206403.

* fast/shadow-dom/shadow-layout-after-toggling-display-slot-parent-expected.html: Added.
* fast/shadow-dom/shadow-layout-after-toggling-display-slot-parent.html: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (206492 => 206493)


--- trunk/LayoutTests/ChangeLog	2016-09-28 01:58:45 UTC (rev 206492)
+++ trunk/LayoutTests/ChangeLog	2016-09-28 03:03:40 UTC (rev 206493)
@@ -1,3 +1,15 @@
+2016-09-27  Ryosuke Niwa  <rn...@webkit.org>
+
+        Toggling display: none on a parent element of a slot which shares style with its parent doesn't update the slot's visibility
+        https://bugs.webkit.org/show_bug.cgi?id=158421
+
+        Reviewed by Darin Adler.
+
+        Add a regression test now that the bug has been fixed by r206403.
+
+        * fast/shadow-dom/shadow-layout-after-toggling-display-slot-parent-expected.html: Added.
+        * fast/shadow-dom/shadow-layout-after-toggling-display-slot-parent.html: Added.
+
 2016-09-27  Chris Dumez  <cdu...@apple.com>
 
         [iOS] Fix several Touch-related layout tests

Added: trunk/LayoutTests/fast/shadow-dom/shadow-layout-after-toggling-display-slot-parent-expected.html (0 => 206493)


--- trunk/LayoutTests/fast/shadow-dom/shadow-layout-after-toggling-display-slot-parent-expected.html	                        (rev 0)
+++ trunk/LayoutTests/fast/shadow-dom/shadow-layout-after-toggling-display-slot-parent-expected.html	2016-09-28 03:03:40 UTC (rev 206493)
@@ -0,0 +1,7 @@
+<!DOCTYPE html>
+<html>
+<body>
+    <p>Test passes if you see a single 100px by 100px green box below.</p>
+    <div style="width: 100px; height: 100px; background: green;"></div>
+</body>
+</html>

Added: trunk/LayoutTests/fast/shadow-dom/shadow-layout-after-toggling-display-slot-parent.html (0 => 206493)


--- trunk/LayoutTests/fast/shadow-dom/shadow-layout-after-toggling-display-slot-parent.html	                        (rev 0)
+++ trunk/LayoutTests/fast/shadow-dom/shadow-layout-after-toggling-display-slot-parent.html	2016-09-28 03:03:40 UTC (rev 206493)
@@ -0,0 +1,38 @@
+<!DOCTYPE html>
+<html>
+<body>
+<p>Test passes if you see a single 100px by 100px green box below.</p> 
+<style>
+
+#test {
+    width: 100px;
+    height: 100px;
+    background: red;
+}
+
+div[slot=green] {
+    width: 100px;
+    height: 100px;
+    background: green;
+    color: green;
+}
+
+</style>
+<div id="test"><div slot="green">PASS</div></div>
+<script>
+var rootElement = document.getElementById('test'); 
+var root = rootElement.attachShadow({mode:'open'});
+root.innerHTML = `
+<style>
+    #container { display: none; }
+    #container.visible { display: block; }
+</style>
+<div><div id="container"><slot name="green">FAIL</slot></div></div>
+`;
+
+rootElement.getBoundingClientRect();
+root.getElementById('container').classList.toggle('visible');
+
+</script>
+</body>
+</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to