Title: [207425] trunk/Source/_javascript_Core
- Revision
- 207425
- Author
- sbar...@apple.com
- Date
- 2016-10-17 13:34:15 -0700 (Mon, 17 Oct 2016)
Log Message
Build fix for HasOwnPropertyCache::Entry caused slowdown by introducing a constructor that doesn't use move semantics for the RefPtr<UniquedStringImpl> parameter
https://bugs.webkit.org/show_bug.cgi?id=163490
Reviewed by Darin Adler.
* runtime/HasOwnPropertyCache.h:
(JSC::HasOwnPropertyCache::Entry::Entry):
(JSC::HasOwnPropertyCache::tryAdd):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (207424 => 207425)
--- trunk/Source/_javascript_Core/ChangeLog 2016-10-17 20:18:38 UTC (rev 207424)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-10-17 20:34:15 UTC (rev 207425)
@@ -1,3 +1,14 @@
+2016-10-17 Saam Barati <sbar...@apple.com>
+
+ Build fix for HasOwnPropertyCache::Entry caused slowdown by introducing a constructor that doesn't use move semantics for the RefPtr<UniquedStringImpl> parameter
+ https://bugs.webkit.org/show_bug.cgi?id=163490
+
+ Reviewed by Darin Adler.
+
+ * runtime/HasOwnPropertyCache.h:
+ (JSC::HasOwnPropertyCache::Entry::Entry):
+ (JSC::HasOwnPropertyCache::tryAdd):
+
2016-10-17 Mark Lam <mark....@apple.com>
Use the reject() helper function for conditionally throwing TypeErrors.
Modified: trunk/Source/_javascript_Core/runtime/HasOwnPropertyCache.h (207424 => 207425)
--- trunk/Source/_javascript_Core/runtime/HasOwnPropertyCache.h 2016-10-17 20:18:38 UTC (rev 207424)
+++ trunk/Source/_javascript_Core/runtime/HasOwnPropertyCache.h 2016-10-17 20:34:15 UTC (rev 207425)
@@ -44,12 +44,11 @@
Entry() = default;
- Entry(RefPtr<UniquedStringImpl> impl, StructureID structureID, bool result)
- : impl(impl)
+ Entry(RefPtr<UniquedStringImpl>&& impl, StructureID structureID, bool result)
+ : impl(WTFMove(impl))
, structureID(structureID)
, result(result)
- {
- }
+ { }
Entry& operator=(Entry&& other)
{
@@ -122,7 +121,7 @@
UniquedStringImpl* impl = propName.uid();
StructureID id = structure->id();
uint32_t index = HasOwnPropertyCache::hash(id, impl) & mask;
- bitwise_cast<Entry*>(this)[index] = Entry{ RefPtr<UniquedStringImpl>(impl), id, result };
+ bitwise_cast<Entry*>(this)[index] = Entry { RefPtr<UniquedStringImpl>(impl), id, result };
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
