Title: [207581] trunk
- Revision
- 207581
- Author
- mmaxfi...@apple.com
- Date
- 2016-10-19 17:39:09 -0700 (Wed, 19 Oct 2016)
Log Message
CSS font-variation-settings does not handle uppercase axis names in variable fonts
https://bugs.webkit.org/show_bug.cgi?id=163546
Reviewed by Dean Jackson.
Source/WebCore:
Remove the extra toASCIILower() call.
Test: fast/text/variations/case-axis-names.html
* css/parser/CSSParser.cpp:
(WebCore::CSSParser::parseFontVariationTag):
LayoutTests:
* fast/text/variations/case-axis-names-expected.html: Added.
* fast/text/variations/case-axis-names.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (207580 => 207581)
--- trunk/LayoutTests/ChangeLog 2016-10-20 00:31:56 UTC (rev 207580)
+++ trunk/LayoutTests/ChangeLog 2016-10-20 00:39:09 UTC (rev 207581)
@@ -1,3 +1,13 @@
+2016-10-19 Myles C. Maxfield <mmaxfi...@apple.com>
+
+ CSS font-variation-settings does not handle uppercase axis names in variable fonts
+ https://bugs.webkit.org/show_bug.cgi?id=163546
+
+ Reviewed by Dean Jackson.
+
+ * fast/text/variations/case-axis-names-expected.html: Added.
+ * fast/text/variations/case-axis-names.html: Added.
+
2016-10-19 Joone Hur <joone....@intel.com>
Add a plain space instead of between text nodes
Added: trunk/LayoutTests/fast/text/variations/case-axis-names-expected.html (0 => 207581)
--- trunk/LayoutTests/fast/text/variations/case-axis-names-expected.html (rev 0)
+++ trunk/LayoutTests/fast/text/variations/case-axis-names-expected.html 2016-10-20 00:39:09 UTC (rev 207581)
@@ -0,0 +1,9 @@
+<!DOCTYPE html>
+<html>
+<head>
+</head>
+<body>
+This test passes if capitalized and lowercased axis names are distinct.
+<div style="font: 100px '-apple-system';">Hello</div>
+</body>
+</html>
\ No newline at end of file
Added: trunk/LayoutTests/fast/text/variations/case-axis-names.html (0 => 207581)
--- trunk/LayoutTests/fast/text/variations/case-axis-names.html (rev 0)
+++ trunk/LayoutTests/fast/text/variations/case-axis-names.html 2016-10-20 00:39:09 UTC (rev 207581)
@@ -0,0 +1,9 @@
+<!DOCTYPE html>
+<html>
+<head>
+</head>
+<body>
+This test passes if capitalized and lowercased axis names are distinct.
+<div style="font: 100px '-apple-system'; font-variation-settings: 'WGHT' 1.8;">Hello</div>
+</body>
+</html>
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (207580 => 207581)
--- trunk/Source/WebCore/ChangeLog 2016-10-20 00:31:56 UTC (rev 207580)
+++ trunk/Source/WebCore/ChangeLog 2016-10-20 00:39:09 UTC (rev 207581)
@@ -1,3 +1,17 @@
+2016-10-19 Myles C. Maxfield <mmaxfi...@apple.com>
+
+ CSS font-variation-settings does not handle uppercase axis names in variable fonts
+ https://bugs.webkit.org/show_bug.cgi?id=163546
+
+ Reviewed by Dean Jackson.
+
+ Remove the extra toASCIILower() call.
+
+ Test: fast/text/variations/case-axis-names.html
+
+ * css/parser/CSSParser.cpp:
+ (WebCore::CSSParser::parseFontVariationTag):
+
2016-10-19 Anders Carlsson <ander...@apple.com>
Remove m_redirectURLs from HistoryItem
Modified: trunk/Source/WebCore/css/parser/CSSParser.cpp (207580 => 207581)
--- trunk/Source/WebCore/css/parser/CSSParser.cpp 2016-10-20 00:31:56 UTC (rev 207580)
+++ trunk/Source/WebCore/css/parser/CSSParser.cpp 2016-10-20 00:39:09 UTC (rev 207581)
@@ -10593,7 +10593,7 @@
UChar character = value->string[i];
if (character < 0x20 || character > 0x7E)
return false;
- tag[i] = toASCIILower(character);
+ tag[i] = character;
}
value = m_valueList->next();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
